Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

improve VNode typings when generic is passed in #4050

Merged
merged 1 commit into from
Jun 25, 2023
Merged

improve VNode typings when generic is passed in #4050

merged 1 commit into from
Jun 25, 2023

Conversation

JoviDeCroock
Copy link
Member

@JoviDeCroock JoviDeCroock commented Jun 24, 2023 •
edited
Loading

There is also an opportunity to improve the types we infer for the second argument when we pass in a generic i.e. we probably don't need to show all attributes

Resolves #4040

@coveralls
Copy link

Coverage Status

coverage: 99.706%. remained the same when pulling f8b75be on better-types into 56d8f41 on master.

@JoviDeCroock JoviDeCroock merged commit 0ef740b into master Jun 25, 2023
@JoviDeCroock JoviDeCroock deleted the better-types branch June 25, 2023 07:20
@JoviDeCroock JoviDeCroock mentioned this pull request Jul 8, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rschristian rschristian rschristian approved these changes

@marvinhagemeister marvinhagemeister marvinhagemeister approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Creating a Preact element with props passed as a generic stil returns a VNode<any>
4 participants
@JoviDeCroock @coveralls @marvinhagemeister @rschristian