Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

reduce stack size of try catch by excluding non components #4067

Merged
merged 5 commits into from
Jul 14, 2023
Merged

reduce stack size of try catch by excluding non components #4067

merged 5 commits into from
Jul 14, 2023

Conversation

JoviDeCroock
Copy link
Member

Been thinking about solutions for #2323, wrapping only when componentDidCatch is present does not work as we don't render other children then i.e. Suspense would lose the parallel capabilities and componentDidCatch would throw once when two children error...

Thinking about more ways we can improve this atm

@github-actions
Copy link

github-actions bot commented Jul 10, 2023 •
edited
Loading

📊 Tachometer Benchmark Results

Summary

duration

  • 02_replace1k: unsure 🔍 -1% - +1% (-1.60ms - +2.01ms)
    preact-local vs preact-master
  • 02_replace1k: Could not find benchmark matching base-bench-name input: preact-main
    preact-local vs preact-main
  • 03_update10th1k_x16: unsure 🔍 -3% - +3% (-1.37ms - +1.38ms)
    preact-local vs preact-master
  • 03_update10th1k_x16: Could not find benchmark matching base-bench-name input: preact-main
    preact-local vs preact-main
  • 07_create10k: unsure 🔍 -1% - +1% (-9.20ms - +6.27ms)
    preact-local vs preact-master
  • 07_create10k: Could not find benchmark matching base-bench-name input: preact-main
    preact-local vs preact-main
  • filter_list: unsure 🔍 -0% - +3% (-0.13ms - +0.89ms)
    preact-local vs preact-master
  • filter_list: Could not find benchmark matching base-bench-name input: preact-main
    preact-local vs preact-main
  • hydrate1k: unsure 🔍 -3% - +1% (-4.00ms - +0.96ms)
    preact-local vs preact-master
  • hydrate1k: Could not find benchmark matching base-bench-name input: preact-main
    preact-local vs preact-main
  • many_updates: unsure 🔍 -3% - +2% (-0.74ms - +0.55ms)
    preact-local vs preact-master
  • many_updates: Could not find benchmark matching base-bench-name input: preact-main
    preact-local vs preact-main
  • text_update: unsure 🔍 -8% - +1% (-0.27ms - +0.04ms)
    preact-local vs preact-master
  • text_update: Could not find benchmark matching base-bench-name input: preact-main
    preact-local vs preact-main
  • todo: unsure 🔍 -3% - +1% (-1.39ms - +0.35ms)
    preact-local vs preact-master
  • todo: Could not find benchmark matching base-bench-name input: preact-main
    preact-local vs preact-main

usedJSHeapSize

  • 02_replace1k: unsure 🔍 -0% - +0% (-0.01ms - +0.01ms)
    preact-local vs preact-master
  • 02_replace1k: Could not find benchmark matching base-bench-name input: preact-main
    preact-local vs preact-main
  • 03_update10th1k_x16: unsure 🔍 -0% - +0% (-0.01ms - +0.01ms)
    preact-local vs preact-master
  • 03_update10th1k_x16: Could not find benchmark matching base-bench-name input: preact-main
    preact-local vs preact-main
  • 07_create10k: unsure 🔍 -0% - +0% (-0.00ms - +0.00ms)
    preact-local vs preact-master
  • 07_create10k: Could not find benchmark matching base-bench-name input: preact-main
    preact-local vs preact-main
  • filter_list: unsure 🔍 -2% - +1% (-0.02ms - +0.01ms)
    preact-local vs preact-master
  • filter_list: Could not find benchmark matching base-bench-name input: preact-main
    preact-local vs preact-main
  • hydrate1k: unsure 🔍 -1% - +0% (-0.05ms - +0.01ms)
    preact-local vs preact-master
  • hydrate1k: Could not find benchmark matching base-bench-name input: preact-main
    preact-local vs preact-main
  • many_updates: unsure 🔍 -1% - +1% (-0.03ms - +0.03ms)
    preact-local vs preact-master
  • many_updates: Could not find benchmark matching base-bench-name input: preact-main
    preact-local vs preact-main
  • text_update: unsure 🔍 -0% - +1% (-0.00ms - +0.00ms)
    preact-local vs preact-master
  • text_update: Could not find benchmark matching base-bench-name input: preact-main
    preact-local vs preact-main
  • todo: unsure 🔍 -1% - +0% (-0.01ms - +0.00ms)
    preact-local vs preact-master
  • todo: Could not find benchmark matching base-bench-name input: preact-main
    preact-local vs preact-main

Results

02_replace1k
  • Browser: chrome-headless 114.0.5735.198
  • Sample size: 70
  • Built by: Benchmarks #1137

  • Commit: 7a0764f

duration

VersionAvg timevs preact-mastervs preact-localvs preact-hooks
preact-master146.22ms - 149.04ms-unsure 🔍
-1% - +1%
-2.01ms - +1.60ms		unsure 🔍
-1% - +1%
-1.84ms - +1.89ms
preact-local146.71ms - 148.95msunsure 🔍
-1% - +1%
-1.60ms - +2.01ms		-unsure 🔍
-1% - +1%
-1.42ms - +1.88ms
preact-hooks146.39ms - 148.82msunsure 🔍
-1% - +1%
-1.89ms - +1.84ms		unsure 🔍
-1% - +1%
-1.88ms - +1.42ms		-

usedJSHeapSize

VersionAvg timevs preact-mastervs preact-localvs preact-hooks
preact-master3.28ms - 3.29ms-unsure 🔍
-0% - +0%
-0.01ms - +0.01ms		faster ✔
1% - 2%
0.02ms - 0.05ms
preact-local3.28ms - 3.29msunsure 🔍
-0% - +0%
-0.01ms - +0.01ms		-faster ✔
1% - 2%
0.02ms - 0.05ms
preact-hooks3.31ms - 3.33msslower ❌
1% - 2%
0.02ms - 0.05ms		slower ❌
1% - 2%
0.02ms - 0.05ms		-

run-warmup-0

VersionAvg timevs preact-mastervs preact-localvs preact-hooks
preact-master47.52ms - 49.62ms-unsure 🔍
-2% - +4%
-0.73ms - +1.87ms		unsure 🔍
-4% - +1%
-2.10ms - +0.65ms
preact-local47.23ms - 48.77msunsure 🔍
-4% - +1%
-1.87ms - +0.73ms		-faster ✔
0% - 5%
0.12ms - 2.48ms
preact-hooks48.41ms - 50.19msunsure 🔍
-1% - +4%
-0.65ms - +2.10ms		slower ❌
0% - 5%
0.12ms - 2.48ms		-

run-warmup-1

VersionAvg timevs preact-mastervs preact-localvs preact-hooks
preact-master63.11ms - 65.40ms-unsure 🔍
-2% - +3%
-1.49ms - +1.68ms		unsure 🔍
-6% - +0%
-3.89ms - +0.27ms
preact-local63.07ms - 65.26msunsure 🔍
-3% - +2%
-1.68ms - +1.49ms		-unsure 🔍
-6% - +0%
-3.96ms - +0.15ms
preact-hooks64.33ms - 67.80msunsure 🔍
-0% - +6%
-0.27ms - +3.89ms		unsure 🔍
-0% - +6%
-0.15ms - +3.96ms		-

run-warmup-2

VersionAvg timevs preact-mastervs preact-localvs preact-hooks
preact-master53.49ms - 57.06ms-unsure 🔍
-4% - +5%
-2.38ms - +2.66ms		unsure 🔍
-2% - +7%
-1.00ms - +3.66ms
preact-local53.36ms - 56.90msunsure 🔍
-5% - +4%
-2.66ms - +2.38ms		-unsure 🔍
-2% - +7%
-1.13ms - +3.51ms
preact-hooks52.45ms - 55.44msunsure 🔍
-7% - +2%
-3.66ms - +1.00ms		unsure 🔍
-6% - +2%
-3.51ms - +1.13ms		-

run-warmup-3

VersionAvg timevs preact-mastervs preact-localvs preact-hooks
preact-master44.56ms - 48.08ms-unsure 🔍
-6% - +4%
-2.97ms - +1.92ms		unsure 🔍
-9% - +1%
-4.36ms - +0.59ms
preact-local45.15ms - 48.54msunsure 🔍
-4% - +6%
-1.92ms - +2.97ms		-unsure 🔍
-8% - +2%
-3.79ms - +1.07ms
preact-hooks46.47ms - 49.94msunsure 🔍
-1% - +10%
-0.59ms - +4.36ms		unsure 🔍
-2% - +8%
-1.07ms - +3.79ms		-

run-warmup-4

VersionAvg timevs preact-mastervs preact-localvs preact-hooks
preact-master54.63ms - 57.46ms-unsure 🔍
-3% - +4%
-1.91ms - +2.42ms		unsure 🔍
-3% - +4%
-1.74ms - +2.11ms
preact-local54.16ms - 57.43msunsure 🔍
-4% - +3%
-2.42ms - +1.91ms		-unsure 🔍
-4% - +4%
-2.17ms - +2.03ms
preact-hooks54.56ms - 57.17msunsure 🔍
-4% - +3%
-2.11ms - +1.74ms		unsure 🔍
-4% - +4%
-2.03ms - +2.17ms		-

run-final

VersionAvg timevs preact-mastervs preact-localvs preact-hooks
preact-master36.66ms - 38.08ms-unsure 🔍
-5% - +1%
-1.76ms - +0.45ms		unsure 🔍
-4% - +1%
-1.59ms - +0.38ms
preact-local37.18ms - 38.86msunsure 🔍
-1% - +5%
-0.45ms - +1.76ms		-unsure 🔍
-3% - +3%
-1.04ms - +1.14ms
preact-hooks37.28ms - 38.66msunsure 🔍
-1% - +4%
-0.38ms - +1.59ms		unsure 🔍
-3% - +3%
-1.14ms - +1.04ms		-
02_replace1k

duration

VersionAvg timevs preact-localvs preact-hooks
preact-local173.21ms - 176.67ms-unsure 🔍
-1% - +2%
-2.08ms - +2.99ms
preact-hooks172.62ms - 176.34msunsure 🔍
-2% - +1%
-2.99ms - +2.08ms		-

usedJSHeapSize

VersionAvg timevs preact-localvs preact-hooks
preact-local3.28ms - 3.29ms-faster ✔
0% - 1%
0.01ms - 0.03ms
preact-hooks3.30ms - 3.31msslower ❌
0% - 1%
0.01ms - 0.03ms		-

run-warmup-0

VersionAvg timevs preact-localvs preact-hooks
preact-local58.42ms - 60.25ms-faster ✔
2% - 7%
1.45ms - 4.66ms
preact-hooks61.07ms - 63.71msslower ❌
2% - 8%
1.45ms - 4.66ms		-

run-warmup-1

VersionAvg timevs preact-localvs preact-hooks
preact-local77.55ms - 80.38ms-faster ✔
1% - 6%
0.88ms - 4.94ms
preact-hooks80.42ms - 83.32msslower ❌
1% - 6%
0.88ms - 4.94ms		-

run-warmup-2

VersionAvg timevs preact-localvs preact-hooks
preact-local64.24ms - 67.99ms-faster ✔
5% - 13%
3.50ms - 9.45ms
preact-hooks70.27ms - 74.90msslower ❌
5% - 14%
3.50ms - 9.45ms		-

run-warmup-3

VersionAvg timevs preact-localvs preact-hooks
preact-local56.98ms - 60.28ms-unsure 🔍
-3% - +6%
-1.52ms - +3.35ms
preact-hooks55.92ms - 59.51msunsure 🔍
-6% - +3%
-3.35ms - +1.52ms		-

run-warmup-4

VersionAvg timevs preact-localvs preact-hooks
preact-local69.85ms - 74.07ms-unsure 🔍
-3% - +5%
-2.05ms - +3.73ms
preact-hooks69.14ms - 73.09msunsure 🔍
-5% - +3%
-3.73ms - +2.05ms		-

run-final

VersionAvg timevs preact-localvs preact-hooks
preact-local50.47ms - 52.47ms-unsure 🔍
-2% - +3%
-1.26ms - +1.64ms
preact-hooks50.23ms - 52.33msunsure 🔍
-3% - +2%
-1.64ms - +1.26ms		-
03_update10th1k_x16
  • Browser: chrome-headless 114.0.5735.198
  • Sample size: 100
  • Built by: Benchmarks #1137

  • Commit: 7a0764f

duration

VersionAvg timevs preact-mastervs preact-localvs preact-hooks
preact-master41.48ms - 43.31ms-unsure 🔍
-3% - +3%
-1.38ms - +1.37ms		faster ✔
2% - 8%
0.78ms - 3.47ms
preact-local41.37ms - 43.42msunsure 🔍
-3% - +3%
-1.37ms - +1.38ms		-faster ✔
2% - 8%
0.70ms - 3.54ms
preact-hooks43.53ms - 45.50msslower ❌
2% - 8%
0.78ms - 3.47ms		slower ❌
2% - 8%
0.70ms - 3.54ms		-

usedJSHeapSize

VersionAvg timevs preact-mastervs preact-localvs preact-hooks
preact-master3.23ms - 3.24ms-unsure 🔍
-0% - +0%
-0.01ms - +0.01ms		faster ✔
1% - 1%
0.02ms - 0.03ms
preact-local3.23ms - 3.24msunsure 🔍
-0% - +0%
-0.01ms - +0.01ms		-faster ✔
1% - 1%
0.02ms - 0.03ms
preact-hooks3.26ms - 3.27msslower ❌
1% - 1%
0.02ms - 0.03ms		slower ❌
1% - 1%
0.02ms - 0.03ms		-
03_update10th1k_x16

duration

VersionAvg timevs preact-localvs preact-hooks
preact-local31.43ms - 33.51ms-unsure 🔍
-5% - +5%
-1.48ms - +1.48ms
preact-hooks31.41ms - 33.52msunsure 🔍
-5% - +5%
-1.48ms - +1.48ms		-

usedJSHeapSize

VersionAvg timevs preact-localvs preact-hooks
preact-local3.24ms - 3.25ms-faster ✔
0% - 1%
0.02ms - 0.03ms
preact-hooks3.26ms - 3.27msslower ❌
0% - 1%
0.02ms - 0.03ms		-
07_create10k
  • Browser: chrome-headless 114.0.5735.198
  • Sample size: 50
  • Built by: Benchmarks #1137

  • Commit: 7a0764f

duration

VersionAvg timevs preact-mastervs preact-localvs preact-hooks
preact-master1161.73ms - 1173.77ms-unsure 🔍
-1% - +1%
-6.27ms - +9.20ms		unsure 🔍
-1% - +0%
-9.37ms - +5.79ms
preact-local1161.43ms - 1171.14msunsure 🔍
-1% - +1%
-9.20ms - +6.27ms		-unsure 🔍
-1% - +0%
-9.94ms - +3.43ms
preact-hooks1164.94ms - 1174.14msunsure 🔍
-0% - +1%
-5.79ms - +9.37ms		unsure 🔍
-0% - +1%
-3.43ms - +9.94ms		-

usedJSHeapSize

VersionAvg timevs preact-mastervs preact-localvs preact-hooks
preact-master25.32ms - 25.32ms-unsure 🔍
-0% - +0%
-0.00ms - +0.00ms		unsure 🔍
-0% - -0%
-0.02ms - -0.02ms
preact-local25.32ms - 25.32msunsure 🔍
-0% - +0%
-0.00ms - +0.00ms		-unsure 🔍
-0% - -0%
-0.02ms - -0.02ms
preact-hooks25.34ms - 25.34msunsure 🔍
+0% - +0%
+0.02ms - +0.02ms		unsure 🔍
+0% - +0%
+0.02ms - +0.02ms		-
07_create10k

duration

VersionAvg timevs preact-localvs preact-hooks
preact-local1489.79ms - 1510.17ms-unsure 🔍
-1% - +1%
-17.07ms - +11.06ms
preact-hooks1493.29ms - 1512.67msunsure 🔍
-1% - +1%
-11.06ms - +17.07ms		-

usedJSHeapSize

VersionAvg timevs preact-localvs preact-hooks
preact-local25.32ms - 25.32ms-unsure 🔍
-0% - -0%
-0.02ms - -0.02ms
preact-hooks25.34ms - 25.34msunsure 🔍
+0% - +0%
+0.02ms - +0.02ms		-
filter_list
  • Browser: chrome-headless 114.0.5735.198
  • Sample size: 50
  • Built by: Benchmarks #1137

  • Commit: 7a0764f

duration

VersionAvg timevs preact-mastervs preact-localvs preact-hooks
preact-master28.08ms - 28.79ms-unsure 🔍
-3% - +0%
-0.89ms - +0.13ms		unsure 🔍
-2% - +2%
-0.56ms - +0.44ms
preact-local28.45ms - 29.17msunsure 🔍
-0% - +3%
-0.13ms - +0.89ms		-unsure 🔍
-1% - +3%
-0.19ms - +0.82ms
preact-hooks28.15ms - 28.84msunsure 🔍
-2% - +2%
-0.44ms - +0.56ms		unsure 🔍
-3% - +1%
-0.82ms - +0.19ms		-

usedJSHeapSize

VersionAvg timevs preact-mastervs preact-localvs preact-hooks
preact-master1.40ms - 1.42ms-unsure 🔍
-1% - +2%
-0.01ms - +0.02ms		faster ✔
1% - 4%
0.01ms - 0.06ms
preact-local1.39ms - 1.42msunsure 🔍
-2% - +1%
-0.02ms - +0.01ms		-faster ✔
1% - 4%
0.01ms - 0.06ms
preact-hooks1.42ms - 1.46msslower ❌
1% - 4%
0.01ms - 0.06ms		slower ❌
1% - 4%
0.01ms - 0.06ms		-
filter_list

duration

VersionAvg timevs preact-localvs preact-hooks
preact-local28.86ms - 29.92ms-unsure 🔍
-3% - +2%
-0.93ms - +0.70ms
preact-hooks28.88ms - 30.13msunsure 🔍
-2% - +3%
-0.70ms - +0.93ms		-

usedJSHeapSize

VersionAvg timevs preact-localvs preact-hooks
preact-local1.39ms - 1.41ms-faster ✔
1% - 5%
0.02ms - 0.07ms
preact-hooks1.42ms - 1.47msslower ❌
1% - 5%
0.02ms - 0.07ms		-
hydrate1k
  • Browser: chrome-headless 114.0.5735.198
  • Sample size: 50
  • Built by: Benchmarks #1137

  • Commit: 7a0764f

duration

VersionAvg timevs preact-mastervs preact-localvs preact-hooks
preact-master145.63ms - 149.26ms-unsure 🔍
-1% - +3%
-0.96ms - +4.00ms		unsure 🔍
-2% - +1%
-3.58ms - +1.89ms
preact-local144.23ms - 147.61msunsure 🔍
-3% - +1%
-4.00ms - +0.96ms		-unsure 🔍
-3% - +0%
-5.03ms - +0.29ms
preact-hooks146.24ms - 150.33msunsure 🔍
-1% - +2%
-1.89ms - +3.58ms		unsure 🔍
-0% - +3%
-0.29ms - +5.03ms		-

usedJSHeapSize

VersionAvg timevs preact-mastervs preact-localvs preact-hooks
preact-master5.97ms - 6.01ms-unsure 🔍
-0% - +1%
-0.01ms - +0.05ms		faster ✔
0% - 1%
0.00ms - 0.05ms
preact-local5.95ms - 5.99msunsure 🔍
-1% - +0%
-0.05ms - +0.01ms		-faster ✔
0% - 1%
0.02ms - 0.07ms
preact-hooks6.00ms - 6.03msslower ❌
0% - 1%
0.00ms - 0.05ms		slower ❌
0% - 1%
0.02ms - 0.07ms		-
hydrate1k

duration

VersionAvg timevs preact-localvs preact-hooks
preact-local114.62ms - 116.86ms-unsure 🔍
-2% - +1%
-2.75ms - +0.94ms
preact-hooks115.19ms - 118.11msunsure 🔍
-1% - +2%
-0.94ms - +2.75ms		-

usedJSHeapSize

VersionAvg timevs preact-localvs preact-hooks
preact-local5.97ms - 6.02ms-unsure 🔍
-1% - +0%
-0.04ms - +0.02ms
preact-hooks5.99ms - 6.03msunsure 🔍
-0% - +1%
-0.02ms - +0.04ms		-
many_updates
  • Browser: chrome-headless 114.0.5735.198
  • Sample size: 50
  • Built by: Benchmarks #1137

  • Commit: 7a0764f

duration

VersionAvg timevs preact-mastervs preact-localvs preact-hooks
preact-master26.92ms - 27.81ms-unsure 🔍
-2% - +3%
-0.55ms - +0.74ms		unsure 🔍
-4% - +1%
-1.06ms - +0.20ms
preact-local26.80ms - 27.74msunsure 🔍
-3% - +2%
-0.74ms - +0.55ms		-unsure 🔍
-4% - +0%
-1.18ms - +0.12ms
preact-hooks27.35ms - 28.25msunsure 🔍
-1% - +4%
-0.20ms - +1.06ms		unsure 🔍
-0% - +4%
-0.12ms - +1.18ms		-

usedJSHeapSize

VersionAvg timevs preact-mastervs preact-localvs preact-hooks
preact-master4.47ms - 4.51ms-unsure 🔍
-1% - +1%
-0.03ms - +0.03ms		unsure 🔍
-1% - +0%
-0.05ms - +0.02ms
preact-local4.47ms - 4.51msunsure 🔍
-1% - +1%
-0.03ms - +0.03ms		-unsure 🔍
-1% - +0%
-0.05ms - +0.02ms
preact-hooks4.48ms - 4.53msunsure 🔍
-0% - +1%
-0.02ms - +0.05ms		unsure 🔍
-0% - +1%
-0.02ms - +0.05ms		-
many_updates

duration

VersionAvg timevs preact-localvs preact-hooks
preact-local28.40ms - 29.42ms-faster ✔
1% - 6%
0.13ms - 1.81ms
preact-hooks29.21ms - 30.55msslower ❌
0% - 6%
0.13ms - 1.81ms		-

usedJSHeapSize

VersionAvg timevs preact-localvs preact-hooks
preact-local4.47ms - 4.51ms-unsure 🔍
-1% - +0%
-0.03ms - +0.02ms
preact-hooks4.48ms - 4.52msunsure 🔍
-0% - +1%
-0.02ms - +0.03ms		-
text_update
  • Browser: chrome-headless 114.0.5735.198
  • Sample size: 180
  • Built by: Benchmarks #1137

  • Commit: 7a0764f

duration

VersionAvg timevs preact-mastervs preact-localvs preact-hooks
preact-master3.34ms - 3.60ms-unsure 🔍
-1% - +8%
-0.04ms - +0.27ms		unsure 🔍
-9% - +1%
-0.32ms - +0.05ms
preact-local3.27ms - 3.44msunsure 🔍
-8% - +1%
-0.27ms - +0.04ms		-faster ✔
3% - 11%
0.10ms - 0.40ms
preact-hooks3.48ms - 3.73msunsure 🔍
-1% - +9%
-0.05ms - +0.32ms		slower ❌
3% - 12%
0.10ms - 0.40ms		-

usedJSHeapSize

VersionAvg timevs preact-mastervs preact-localvs preact-hooks
preact-master0.62ms - 0.62ms-unsure 🔍
-1% - +0%
-0.00ms - +0.00ms		faster ✔
9% - 11%
0.06ms - 0.08ms
preact-local0.62ms - 0.62msunsure 🔍
-0% - +1%
-0.00ms - +0.00ms		-faster ✔
9% - 11%
0.06ms - 0.08ms
preact-hooks0.68ms - 0.70msslower ❌
10% - 13%
0.06ms - 0.08ms		slower ❌
10% - 12%
0.06ms - 0.08ms		-
text_update

duration

VersionAvg timevs preact-localvs preact-hooks
preact-local2.67ms - 2.78ms-faster ✔
5% - 12%
0.14ms - 0.36ms
preact-hooks2.88ms - 3.07msslower ❌
5% - 13%
0.14ms - 0.36ms		-

usedJSHeapSize

VersionAvg timevs preact-localvs preact-hooks
preact-local0.62ms - 0.62ms-faster ✔
9% - 12%
0.06ms - 0.08ms
preact-hooks0.68ms - 0.70msslower ❌
10% - 14%
0.06ms - 0.08ms		-
todo
  • Browser: chrome-headless 114.0.5735.198
  • Sample size: 90
  • Built by: Benchmarks #1137

  • Commit: 7a0764f

duration

VersionAvg timevs preact-mastervs preact-localvs preact-hooks
preact-master51.29ms - 52.66ms-unsure 🔍
-1% - +3%
-0.35ms - +1.39ms		faster ✔
4% - 7%
2.20ms - 4.13ms
preact-local50.92ms - 51.99msunsure 🔍
-3% - +1%
-1.39ms - +0.35ms		-faster ✔
5% - 8%
2.81ms - 4.55ms
preact-hooks54.46ms - 55.82msslower ❌
4% - 8%
2.20ms - 4.13ms		slower ❌
5% - 9%
2.81ms - 4.55ms		-

usedJSHeapSize

VersionAvg timevs preact-mastervs preact-localvs preact-hooks
preact-master0.85ms - 0.86ms-unsure 🔍
-0% - +1%
-0.00ms - +0.01ms		faster ✔
3% - 4%
0.03ms - 0.03ms
preact-local0.85ms - 0.86msunsure 🔍
-1% - +0%
-0.01ms - +0.00ms		-faster ✔
3% - 4%
0.03ms - 0.03ms
preact-hooks0.89ms - 0.89msslower ❌
3% - 4%
0.03ms - 0.03ms		slower ❌
4% - 4%
0.03ms - 0.03ms		-
todo

duration

VersionAvg timevs preact-localvs preact-hooks
preact-local53.65ms - 54.83ms-faster ✔
5% - 8%
2.88ms - 4.70ms
preact-hooks57.34ms - 58.72msslower ❌
5% - 9%
2.88ms - 4.70ms		-

usedJSHeapSize

VersionAvg timevs preact-localvs preact-hooks
preact-local0.85ms - 0.86ms-faster ✔
3% - 4%
0.02ms - 0.04ms
preact-hooks0.88ms - 0.89msslower ❌
3% - 4%
0.02ms - 0.04ms		-

tachometer-reporter-action v2 for Benchmarks

@coveralls
Copy link

coveralls commented Jul 10, 2023 •
edited
Loading

Coverage Status

coverage: 99.561%. remained the same when pulling 6ac290c on reduce-stack-size into 2258d7d on main.

@github-actions
Copy link

github-actions bot commented Jul 10, 2023 •
edited
Loading

Size Change: -2 B (0%)

Total Size: 57 kB

Filename Size Change
dist/preact.js 4.35 kB -1 B
dist/preact.min.module.js 4.38 kB -1 B
dist/preact.min.umd.js 4.4 kB -1 B
dist/preact.umd.js 4.41 kB +1 B
ℹ️ View Unchanged
Filename Size Change
compat/dist/compat.js 3.91 kB 0 B
compat/dist/compat.module.js 3.83 kB 0 B
compat/dist/compat.umd.js 3.97 kB 0 B
debug/dist/debug.js 3.64 kB 0 B
debug/dist/debug.module.js 3.62 kB 0 B
debug/dist/debug.umd.js 3.71 kB 0 B
devtools/dist/devtools.js 232 B 0 B
devtools/dist/devtools.module.js 241 B 0 B
devtools/dist/devtools.umd.js 315 B 0 B
dist/preact.min.js 4.38 kB 0 B
dist/preact.module.js 4.37 kB 0 B
hooks/dist/hooks.js 1.53 kB 0 B
hooks/dist/hooks.module.js 1.56 kB 0 B
hooks/dist/hooks.umd.js 1.62 kB 0 B
jsx-runtime/dist/jsxRuntime.js 360 B 0 B
jsx-runtime/dist/jsxRuntime.module.js 326 B 0 B
jsx-runtime/dist/jsxRuntime.umd.js 441 B 0 B
test-utils/dist/testUtils.js 453 B 0 B
test-utils/dist/testUtils.module.js 454 B 0 B
test-utils/dist/testUtils.umd.js 536 B 0 B

compressed-size-action

marvinhagemeister
marvinhagemeister approved these changes Jul 10, 2023
View reviewed changes
Copy link
Member

@marvinhagemeister marvinhagemeister left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

2B savings? I'll take it :D

@JoviDeCroock JoviDeCroock marked this pull request as ready for review July 10, 2023 07:45
@JoviDeCroock
Copy link
Member Author

@marvinhagemeister it will atleast reduce the stack a bit 😅 generally we might need to think of a way where we wrap _catchError/.. and only report the first stack we encounter, the thread has something about react and how they do it but need to look deeper into that

@JoviDeCroock
Copy link
Member Author

I had an idea on what might reduce the stack-size 😅 not including diffChildren

@JoviDeCroock JoviDeCroock merged commit 34e37c5 into main Jul 14, 2023
@JoviDeCroock JoviDeCroock deleted the reduce-stack-size branch July 14, 2023 07:19
@JoviDeCroock JoviDeCroock mentioned this pull request Aug 12, 2023
Merged
@JoviDeCroock JoviDeCroock mentioned this pull request Apr 27, 2024
Closed
13 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@marvinhagemeister marvinhagemeister Awaiting requested review from marvinhagemeister

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@JoviDeCroock @coveralls @marvinhagemeister