Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

type[compat]: add html attributes types #4099 #4100

Merged
merged 7 commits into from
Jul 1, 2024
Merged

type[compat]: add html attributes types #4099 #4100

merged 7 commits into from
Jul 1, 2024

Conversation

samsam-ahmadi
Copy link
Contributor

This PR is for: #4099

rschristian
rschristian reviewed Aug 16, 2023
View reviewed changes
compat/src/index.d.ts Outdated Show resolved Hide resolved
rschristian
rschristian reviewed Aug 16, 2023
View reviewed changes
compat/src/index.d.ts Outdated Show resolved Hide resolved
rschristian
rschristian reviewed Aug 16, 2023
View reviewed changes
src/jsx.d.ts Outdated Show resolved Hide resolved
rschristian
rschristian approved these changes Aug 16, 2023
View reviewed changes
Copy link
Member

@rschristian rschristian left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks very useful, thanks for doing this! We really appreciate it.

Might be nice to move the majority of these into core in the future, as I can see even non-compat users maybe wanting these, but that's an idea for another day.

@samsam-ahmadi samsam-ahmadi force-pushed the compat-add-html-attributes-types branch from c349cd9 to f5840a6 Compare August 17, 2023 08:25
@samsam-ahmadi
Copy link
Contributor Author

Thanks @rschristian,
I updated the branch and it's ready to merge.

@samsam-ahmadi
Copy link
Contributor Author

Hi @rschristian, Any update for this one? How we can get the approval to can merge it?

@baltarifcan
Copy link

Will this be merged anytime soon?

rschristian
rschristian approved these changes Jul 1, 2024
View reviewed changes
Copy link
Member

@rschristian rschristian left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd like to apologize for this PR, evidently I missed a couple of notifications and it then fell off my radar entirely -- I'm really sorry.

We certainly appreciate any & all contributions, and the time contributors invest into them.

Thanks again.

@rschristian rschristian merged commit 6cbb77e into preactjs:main Jul 1, 2024
1 check passed
@coveralls
Copy link

Coverage Status

coverage: 99.611%. remained the same
when pulling 146de2d on samsam-ahmadi:compat-add-html-attributes-types
into 7eef3e0 on preactjs:main.

@JoviDeCroock JoviDeCroock mentioned this pull request Jul 20, 2024
Merged
This was referenced Aug 14, 2024
Open
Open
@ramzimalhas ramzimalhas mentioned this pull request Aug 22, 2024
Open
This was referenced Sep 3, 2024
Open
Open
@arkid15r arkid15r mentioned this pull request Sep 11, 2024
Closed
@ntavassoli-dot ntavassoli-dot mentioned this pull request Sep 13, 2024
Open
This was referenced Sep 13, 2024
Open
Open
@organich organich mentioned this pull request Sep 24, 2024
Open
@X-oss-byte X-oss-byte mentioned this pull request Oct 5, 2024
Open
@X-oss-byte X-oss-byte mentioned this pull request Oct 18, 2024
Open
@X-oss-byte X-oss-byte mentioned this pull request Oct 25, 2024
Open
@Xcaciv Xcaciv mentioned this pull request Oct 27, 2024
Open
@dwhiteGUK dwhiteGUK mentioned this pull request Oct 28, 2024
Open
@abaum65 abaum65 mentioned this pull request Oct 31, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rschristian rschristian rschristian approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@samsam-ahmadi @baltarifcan @coveralls @rschristian