Remove focus from event capturing tests #4217
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Using focus as a test event for capturing is failing in some browsers (I tested Edge & Chrome). Adding timeouts seemed to fix it, but instead of trying to workaround flakiness, I'm removing focus testing as it doesn't seem necessary for this test.
marvinhagemeister
approved these changes
Nov 22, 2023
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Using focus as a test event for capturing is failing in some browsers (I tested Edge & Chrome). Adding timeouts seemed to fix it, but instead of trying to workaround flakiness, I'm removing focus testing as it doesn't seem necessary for this test.
This PR should get Saucelabs running green again.