Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Match null placeholders using skewed index #4290

Merged
merged 1 commit into from
Feb 22, 2024

Conversation

andrewiggins
Copy link
Member

If we've skewed our matching before hitting a null placeholder (e.g. we've inserted or removed an unmatched node) then let's pick up matching null placeholders from the skewedIndex.

Note I don't think we need to adjust the skew when we find a null placeholder, we treat it as "matching" the current node.

If we've skewed our matching before hitting a null placeholder (e.g. we've inserted or removed an unmatched node) then let's pick up matching null placeholders from the skewedIndex.

Note I don't think we need to adjust the skew when we find a null placeholder, we treat it as
"matching" the current node.
Copy link

github-actions bot commented Feb 22, 2024

📊 Tachometer Benchmark Results

Summary

duration

  • 02_replace1k: unsure 🔍 -2% - +1% (-1.93ms - +0.45ms)
    preact-local vs preact-main
  • 03_update10th1k_x16: unsure 🔍 -5% - +4% (-1.45ms - +1.34ms)
    preact-local vs preact-main
  • 07_create10k: unsure 🔍 -1% - +1% (-14.91ms - +14.65ms)
    preact-local vs preact-main
  • filter_list: unsure 🔍 -0% - +0% (-0.06ms - +0.05ms)
    preact-local vs preact-main
  • hydrate1k: unsure 🔍 -1% - +2% (-0.47ms - +1.45ms)
    preact-local vs preact-main
  • many_updates: unsure 🔍 -4% - +3% (-0.66ms - +0.50ms)
    preact-local vs preact-main
  • text_update: unsure 🔍 -2% - +5% (-0.04ms - +0.12ms)
    preact-local vs preact-main
  • todo: unsure 🔍 -1% - +1% (-0.23ms - +0.24ms)
    preact-local vs preact-main

usedJSHeapSize

  • 02_replace1k: unsure 🔍 -0% - +0% (-0.00ms - +0.00ms)
    preact-local vs preact-main
  • 03_update10th1k_x16: unsure 🔍 -0% - +0% (-0.01ms - +0.01ms)
    preact-local vs preact-main
  • 07_create10k: unsure 🔍 -0% - +0% (-0.00ms - +0.00ms)
    preact-local vs preact-main
  • filter_list: unsure 🔍 +0% - +0% (+0.00ms - +0.00ms)
    preact-local vs preact-main
  • hydrate1k: unsure 🔍 -0% - +0% (-0.01ms - +0.00ms)
    preact-local vs preact-main
  • many_updates: unsure 🔍 -0% - +0% (-0.00ms - +0.00ms)
    preact-local vs preact-main
  • text_update: unsure 🔍 +0% - +0% (+0.00ms - +0.00ms)
    preact-local vs preact-main
  • todo: unsure 🔍 -0% - -0% (-0.00ms - -0.00ms)
    preact-local vs preact-main

Results

02_replace1k

duration

VersionAvg timevs preact-mainvs preact-localvs preact-hooks
preact-main76.35ms - 78.06ms-unsure 🔍
-1% - +3%
-0.45ms - +1.93ms
unsure 🔍
-1% - +2%
-0.92ms - +1.49ms
preact-local75.64ms - 77.29msunsure 🔍
-2% - +1%
-1.93ms - +0.45ms
-unsure 🔍
-2% - +1%
-1.64ms - +0.73ms
preact-hooks76.08ms - 77.77msunsure 🔍
-2% - +1%
-1.49ms - +0.92ms
unsure 🔍
-1% - +2%
-0.73ms - +1.64ms
-

usedJSHeapSize

VersionAvg timevs preact-mainvs preact-localvs preact-hooks
preact-main3.48ms - 3.48ms-unsure 🔍
-0% - +0%
-0.00ms - +0.00ms
faster ✔
1% - 1%
0.02ms - 0.03ms
preact-local3.48ms - 3.48msunsure 🔍
-0% - +0%
-0.00ms - +0.00ms
-faster ✔
1% - 1%
0.02ms - 0.02ms
preact-hooks3.50ms - 3.50msslower ❌
1% - 1%
0.02ms - 0.03ms
slower ❌
1% - 1%
0.02ms - 0.02ms
-

run-warmup-0

VersionAvg timevs preact-mainvs preact-localvs preact-hooks
preact-main30.15ms - 31.35ms-unsure 🔍
-2% - +3%
-0.70ms - +0.95ms
unsure 🔍
-3% - +2%
-0.82ms - +0.69ms
preact-local30.05ms - 31.19msunsure 🔍
-3% - +2%
-0.95ms - +0.70ms
-unsure 🔍
-3% - +2%
-0.92ms - +0.54ms
preact-hooks30.35ms - 31.27msunsure 🔍
-2% - +3%
-0.69ms - +0.82ms
unsure 🔍
-2% - +3%
-0.54ms - +0.92ms
-

run-warmup-1

VersionAvg timevs preact-mainvs preact-localvs preact-hooks
preact-main38.94ms - 40.40ms-unsure 🔍
-3% - +3%
-1.07ms - +1.12ms
unsure 🔍
-4% - +0%
-1.60ms - +0.17ms
preact-local38.83ms - 40.46msunsure 🔍
-3% - +3%
-1.12ms - +1.07ms
-unsure 🔍
-4% - +1%
-1.70ms - +0.22ms
preact-hooks39.88ms - 40.89msunsure 🔍
-0% - +4%
-0.17ms - +1.60ms
unsure 🔍
-1% - +4%
-0.22ms - +1.70ms
-

run-warmup-2

VersionAvg timevs preact-mainvs preact-localvs preact-hooks
preact-main26.33ms - 26.62ms-unsure 🔍
-1% - +1%
-0.29ms - +0.31ms
unsure 🔍
-2% - +1%
-0.52ms - +0.33ms
preact-local26.21ms - 26.73msunsure 🔍
-1% - +1%
-0.31ms - +0.29ms
-unsure 🔍
-2% - +1%
-0.58ms - +0.37ms
preact-hooks26.18ms - 26.97msunsure 🔍
-1% - +2%
-0.33ms - +0.52ms
unsure 🔍
-1% - +2%
-0.37ms - +0.58ms
-

run-warmup-3

VersionAvg timevs preact-mainvs preact-localvs preact-hooks
preact-main25.44ms - 26.64ms-unsure 🔍
-1% - +5%
-0.29ms - +1.29ms
unsure 🔍
-2% - +4%
-0.57ms - +1.13ms
preact-local25.03ms - 26.05msunsure 🔍
-5% - +1%
-1.29ms - +0.29ms
-unsure 🔍
-4% - +2%
-1.01ms - +0.57ms
preact-hooks25.16ms - 26.36msunsure 🔍
-4% - +2%
-1.13ms - +0.57ms
unsure 🔍
-2% - +4%
-0.57ms - +1.01ms
-

run-warmup-4

VersionAvg timevs preact-mainvs preact-localvs preact-hooks
preact-main26.91ms - 28.65ms-unsure 🔍
-7% - +2%
-1.89ms - +0.71ms
faster ✔
1% - 8%
0.34ms - 2.27ms
preact-local27.40ms - 29.34msunsure 🔍
-3% - +7%
-0.71ms - +1.89ms
-unsure 🔍
-6% - +1%
-1.77ms - +0.35ms
preact-hooks28.66ms - 29.50msslower ❌
1% - 8%
0.34ms - 2.27ms
unsure 🔍
-1% - +6%
-0.35ms - +1.77ms
-

run-final

VersionAvg timevs preact-mainvs preact-localvs preact-hooks
preact-main23.72ms - 24.79ms-slower ❌
1% - 7%
0.26ms - 1.62ms
unsure 🔍
-2% - +4%
-0.50ms - +0.95ms
preact-local22.90ms - 23.73msfaster ✔
1% - 7%
0.26ms - 1.62ms
-faster ✔
0% - 6%
0.07ms - 1.35ms
preact-hooks23.54ms - 24.51msunsure 🔍
-4% - +2%
-0.95ms - +0.50ms
slower ❌
0% - 6%
0.07ms - 1.35ms
-
03_update10th1k_x16

duration

VersionAvg timevs preact-mainvs preact-localvs preact-hooks
preact-main30.18ms - 32.00ms-unsure 🔍
-4% - +5%
-1.34ms - +1.45ms
unsure 🔍
-4% - +5%
-1.09ms - +1.42ms
preact-local29.98ms - 32.09msunsure 🔍
-5% - +4%
-1.45ms - +1.34ms
-unsure 🔍
-4% - +5%
-1.25ms - +1.47ms
preact-hooks30.07ms - 31.79msunsure 🔍
-5% - +3%
-1.42ms - +1.09ms
unsure 🔍
-5% - +4%
-1.47ms - +1.25ms
-

usedJSHeapSize

VersionAvg timevs preact-mainvs preact-localvs preact-hooks
preact-main3.44ms - 3.45ms-unsure 🔍
-0% - +0%
-0.01ms - +0.01ms
faster ✔
0% - 1%
0.01ms - 0.03ms
preact-local3.44ms - 3.45msunsure 🔍
-0% - +0%
-0.01ms - +0.01ms
-faster ✔
0% - 1%
0.01ms - 0.03ms
preact-hooks3.46ms - 3.47msslower ❌
0% - 1%
0.01ms - 0.03ms
slower ❌
0% - 1%
0.01ms - 0.03ms
-
07_create10k

duration

VersionAvg timevs preact-mainvs preact-localvs preact-hooks
preact-main1132.23ms - 1153.48ms-unsure 🔍
-1% - +1%
-14.65ms - +14.91ms
unsure 🔍
-1% - +1%
-14.77ms - +14.19ms
preact-local1132.45ms - 1152.99msunsure 🔍
-1% - +1%
-14.91ms - +14.65ms
-unsure 🔍
-1% - +1%
-14.65ms - +13.80ms
preact-hooks1133.31ms - 1152.98msunsure 🔍
-1% - +1%
-14.19ms - +14.77ms
unsure 🔍
-1% - +1%
-13.80ms - +14.65ms
-

usedJSHeapSize

VersionAvg timevs preact-mainvs preact-localvs preact-hooks
preact-main26.48ms - 26.48ms-unsure 🔍
-0% - +0%
-0.00ms - +0.00ms
unsure 🔍
-0% - -0%
-0.02ms - -0.02ms
preact-local26.48ms - 26.48msunsure 🔍
-0% - +0%
-0.00ms - +0.00ms
-unsure 🔍
-0% - -0%
-0.02ms - -0.02ms
preact-hooks26.50ms - 26.50msunsure 🔍
+0% - +0%
+0.02ms - +0.02ms
unsure 🔍
+0% - +0%
+0.02ms - +0.02ms
-
filter_list

duration

VersionAvg timevs preact-mainvs preact-localvs preact-hooks
preact-main16.57ms - 16.67ms-unsure 🔍
-0% - +0%
-0.05ms - +0.06ms
unsure 🔍
-0% - +0%
-0.07ms - +0.08ms
preact-local16.59ms - 16.64msunsure 🔍
-0% - +0%
-0.06ms - +0.05ms
-unsure 🔍
-0% - +0%
-0.06ms - +0.06ms
preact-hooks16.56ms - 16.67msunsure 🔍
-0% - +0%
-0.08ms - +0.07ms
unsure 🔍
-0% - +0%
-0.06ms - +0.06ms
-

usedJSHeapSize

VersionAvg timevs preact-mainvs preact-localvs preact-hooks
preact-main1.49ms - 1.49ms-unsure 🔍
-0% - -0%
-0.00ms - -0.00ms
faster ✔
2% - 2%
0.02ms - 0.03ms
preact-local1.49ms - 1.50msunsure 🔍
+0% - +0%
+0.00ms - +0.00ms
-faster ✔
1% - 2%
0.02ms - 0.03ms
preact-hooks1.52ms - 1.52msslower ❌
2% - 2%
0.02ms - 0.03ms
slower ❌
1% - 2%
0.02ms - 0.03ms
-
hydrate1k

duration

VersionAvg timevs preact-mainvs preact-localvs preact-hooks
preact-main76.84ms - 78.09ms-unsure 🔍
-2% - +1%
-1.45ms - +0.47ms
unsure 🔍
-1% - +1%
-1.02ms - +0.45ms
preact-local77.23ms - 78.68msunsure 🔍
-1% - +2%
-0.47ms - +1.45ms
-unsure 🔍
-1% - +1%
-0.62ms - +1.02ms
preact-hooks77.37ms - 78.13msunsure 🔍
-1% - +1%
-0.45ms - +1.02ms
unsure 🔍
-1% - +1%
-1.02ms - +0.62ms
-

usedJSHeapSize

VersionAvg timevs preact-mainvs preact-localvs preact-hooks
preact-main6.17ms - 6.19ms-unsure 🔍
-0% - +0%
-0.00ms - +0.01ms
unsure 🔍
-0% - -0%
-0.03ms - -0.01ms
preact-local6.18ms - 6.18msunsure 🔍
-0% - +0%
-0.01ms - +0.00ms
-unsure 🔍
-0% - -0%
-0.03ms - -0.02ms
preact-hooks6.20ms - 6.21msunsure 🔍
+0% - +0%
+0.01ms - +0.03ms
unsure 🔍
+0% - +0%
+0.02ms - +0.03ms
-
many_updates

duration

VersionAvg timevs preact-mainvs preact-localvs preact-hooks
preact-main16.59ms - 17.42ms-unsure 🔍
-3% - +4%
-0.50ms - +0.66ms
unsure 🔍
-2% - +3%
-0.40ms - +0.56ms
preact-local16.52ms - 17.33msunsure 🔍
-4% - +3%
-0.66ms - +0.50ms
-unsure 🔍
-3% - +3%
-0.47ms - +0.47ms
preact-hooks16.69ms - 17.17msunsure 🔍
-3% - +2%
-0.56ms - +0.40ms
unsure 🔍
-3% - +3%
-0.47ms - +0.47ms
-

usedJSHeapSize

VersionAvg timevs preact-mainvs preact-localvs preact-hooks
preact-main4.60ms - 4.60ms-unsure 🔍
-0% - +0%
-0.00ms - +0.00ms
faster ✔
0% - 1%
0.02ms - 0.03ms
preact-local4.60ms - 4.60msunsure 🔍
-0% - +0%
-0.00ms - +0.00ms
-faster ✔
0% - 1%
0.02ms - 0.03ms
preact-hooks4.62ms - 4.62msslower ❌
0% - 1%
0.02ms - 0.03ms
slower ❌
0% - 1%
0.02ms - 0.03ms
-
text_update

duration

VersionAvg timevs preact-mainvs preact-localvs preact-hooks
preact-main2.45ms - 2.55ms-unsure 🔍
-5% - +2%
-0.12ms - +0.04ms
faster ✔
7% - 13%
0.20ms - 0.36ms
preact-local2.48ms - 2.60msunsure 🔍
-2% - +5%
-0.04ms - +0.12ms
-faster ✔
6% - 12%
0.16ms - 0.34ms
preact-hooks2.73ms - 2.85msslower ❌
8% - 15%
0.20ms - 0.36ms
slower ❌
6% - 13%
0.16ms - 0.34ms
-

usedJSHeapSize

VersionAvg timevs preact-mainvs preact-localvs preact-hooks
preact-main0.72ms - 0.72ms-unsure 🔍
-0% - -0%
-0.00ms - -0.00ms
faster ✔
3% - 3%
0.02ms - 0.02ms
preact-local0.72ms - 0.72msunsure 🔍
+0% - +0%
+0.00ms - +0.00ms
-faster ✔
3% - 3%
0.02ms - 0.02ms
preact-hooks0.75ms - 0.75msslower ❌
3% - 3%
0.02ms - 0.02ms
slower ❌
3% - 3%
0.02ms - 0.02ms
-
todo

duration

VersionAvg timevs preact-mainvs preact-localvs preact-hooks
preact-main26.43ms - 26.85ms-unsure 🔍
-1% - +1%
-0.24ms - +0.23ms
faster ✔
2% - 4%
0.54ms - 1.13ms
preact-local26.53ms - 26.76msunsure 🔍
-1% - +1%
-0.23ms - +0.24ms
-faster ✔
2% - 4%
0.59ms - 1.07ms
preact-hooks27.26ms - 27.69msslower ❌
2% - 4%
0.54ms - 1.13ms
slower ❌
2% - 4%
0.59ms - 1.07ms
-

usedJSHeapSize

VersionAvg timevs preact-mainvs preact-localvs preact-hooks
preact-main0.95ms - 0.95ms-unsure 🔍
+0% - +0%
+0.00ms - +0.00ms
faster ✔
3% - 3%
0.03ms - 0.03ms
preact-local0.95ms - 0.95msunsure 🔍
-0% - -0%
-0.00ms - -0.00ms
-faster ✔
3% - 3%
0.03ms - 0.03ms
preact-hooks0.98ms - 0.98msslower ❌
3% - 3%
0.03ms - 0.03ms
slower ❌
3% - 3%
0.03ms - 0.03ms
-

tachometer-reporter-action v2 for Benchmarks

Copy link

Size Change: -13 B (0%)

Total Size: 60.1 kB

Filename Size Change
dist/preact.js 4.55 kB -3 B (0%)
dist/preact.min.js 4.59 kB -2 B (0%)
dist/preact.min.module.js 4.59 kB -3 B (0%)
dist/preact.min.umd.js 4.62 kB -3 B (0%)
dist/preact.module.js 4.58 kB -2 B (0%)
ℹ️ View Unchanged
Filename Size Change
compat/dist/compat.js 4 kB 0 B
compat/dist/compat.module.js 3.92 kB 0 B
compat/dist/compat.umd.js 4.06 kB 0 B
debug/dist/debug.js 3.52 kB 0 B
debug/dist/debug.module.js 3.52 kB 0 B
debug/dist/debug.umd.js 3.6 kB 0 B
devtools/dist/devtools.js 232 B 0 B
devtools/dist/devtools.module.js 241 B 0 B
devtools/dist/devtools.umd.js 316 B 0 B
dist/preact.umd.js 4.63 kB 0 B
hooks/dist/hooks.js 1.55 kB 0 B
hooks/dist/hooks.module.js 1.59 kB 0 B
hooks/dist/hooks.umd.js 1.63 kB 0 B
jsx-runtime/dist/jsxRuntime.js 963 B 0 B
jsx-runtime/dist/jsxRuntime.module.js 938 B 0 B
jsx-runtime/dist/jsxRuntime.umd.js 1.04 kB 0 B
test-utils/dist/testUtils.js 453 B 0 B
test-utils/dist/testUtils.module.js 454 B 0 B
test-utils/dist/testUtils.umd.js 536 B 0 B

compressed-size-action

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants