Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add compat/client types #4345

Merged
merged 2 commits into from
Apr 23, 2024
Merged

feat: Add compat/client types #4345

merged 2 commits into from
Apr 23, 2024

Conversation

rschristian
Copy link
Member

Closes #3845 (but for real this time)

Semi-related: is it intentional that Preact can take a ComponentChild as a render arg whilst compat can only take VNode<any>? Doesn't seem like there's an immediately obvious issue w/ compat rendering a string, etc., as it's passed straight through to the core render(), more or less.

@coveralls
Copy link

coveralls commented Apr 22, 2024

Coverage Status

coverage: 99.605%. remained the same
when pulling bb064a3 on types/compat-client
into f0c3e1d on main.

@JoviDeCroock
Copy link
Member

You are right yes, that should be possible

@rschristian rschristian merged commit c1addc2 into main Apr 23, 2024
2 checks passed
@rschristian rschristian deleted the types/compat-client branch April 23, 2024 06:18
@JoviDeCroock JoviDeCroock mentioned this pull request Apr 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Missing types for react-dom/client package in compat
3 participants