chore: test types and warnings #4369
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rschristian
commented
May 2, 2024
Comment on lines
-13
to
+19
| .call(eval('Symbol.for')) | ||
| .call((0, eval)('Symbol.for')) | ||
| .match(/\[native code\]/) | ||
| ) { | ||
| // Concatenate these string literals to prevent the test | ||
| // harness and/or Babel from modifying the symbol value. | ||
| // eslint-disable-next-line | ||
| out = eval('Sym' + 'bol.for("' + name + '")'); | ||
| out = (0, eval)('Sym' + 'bol.for("' + name + '")'); |
There was a problem hiding this comment.
Silences this:
Warning: G] Using direct eval with a bundler is not recommended and may cause problems [direct-eval]
compat/test/browser/testUtils.js:11:41:
11 │ ...ction.prototype.toString.call(eval('Symbol.for')).match(/\[nati...
╵ ~~~~
You can read more about direct eval and bundling here: https://esbuild.github.io/link/direct-eval
Warning: G] Using direct eval with a bundler is not recommended and may cause problems [direct-eval]
compat/test/browser/testUtils.js:15:12:
15 │ out = eval('Sym' + 'bol.for("' + name + '")');
╵ ~~~~
You can read more about direct eval and bundling here: https://esbuild.github.io/link/direct-eval
Warning: G] Using direct eval with a bundler is not recommended and may cause problems [direct-eval]
compat/test/browser/testUtils.js:11:41:
11 │ ...ction.prototype.toString.call(eval('Symbol.for')).match(/\[nati...
╵ ~~~~
You can read more about direct eval and bundling here: https://esbuild.github.io/link/direct-eval
Warning: G] Using direct eval with a bundler is not recommended and may cause problems [direct-eval]
compat/test/browser/testUtils.js:15:12:
15 │ out = eval('Sym' + 'bol.for("' + name + '")');
╵ ~~~~
You can read more about direct eval and bundling here: https://esbuild.github.io/link/direct-eval
Comment on lines
+4
to
+9
| equalNode(node: Node | null, message?: string): void; | ||
| called: Assertion; | ||
| calledOnce: Assertion; | ||
| calledTwice: Assertion; | ||
| calledWith(...args: any[]): Assertion; | ||
| calledWithMatch(...args: Record<string, unknown>[]): Assertion; |
There was a problem hiding this comment.
There's still a few missing, but this should at least cut down on the number of squiggles.
JoviDeCroock
approved these changes
May 2, 2024
Merged
This was referenced Aug 14, 2024
This was referenced Sep 3, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.