Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: Skip running compressed-size builds twice #4377

Merged
merged 2 commits into from
May 9, 2024
Merged

Conversation

rschristian
Copy link
Member

Because we have a prepare script that builds the app, our compressed size action was building the apps once post-install, then again as our build script, resulting in 2 wasted builds per CI run.

You can easily see Microbundle's output here in both the 'Install Dependencies' and 'Build using npm' steps.

@coveralls
Copy link

coveralls commented May 9, 2024

Coverage Status

coverage: 99.609%. remained the same
when pulling d12d306 on ci/compressed-size
into bfdd189 on main.

@rschristian rschristian merged commit 1b4e683 into main May 9, 2024
2 checks passed
@rschristian rschristian deleted the ci/compressed-size branch May 9, 2024 20:25
@JoviDeCroock JoviDeCroock mentioned this pull request May 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants