Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: migrate to biome #4386

Merged
merged 6 commits into from
May 15, 2024
Merged

chore: migrate to biome #4386

merged 6 commits into from
May 15, 2024

Conversation

JoviDeCroock
Copy link
Member

@JoviDeCroock JoviDeCroock commented May 15, 2024

This is an initial attempt of migrating us to biome, a lot of formatting changes will happen because this will use the prettier v3 default settings 😅 wanted to see whether folks are interested in this, we can now also run biome migrate eslint or use oxlint for that.

@JoviDeCroock JoviDeCroock marked this pull request as ready for review May 15, 2024 08:19
Copy link

github-actions bot commented May 15, 2024

📊 Tachometer Benchmark Results

Summary

⏳ Benchmarks are currently running. Results below are out of date.

duration

  • create10k: unsure 🔍 -1% - +0% (-7.40ms - +1.91ms)
    preact-local vs preact-main
  • filter-list: unsure 🔍 -1% - +0% (-0.09ms - +0.07ms)
    preact-local vs preact-main
  • hydrate1k: unsure 🔍 -4% - +2% (-3.31ms - +1.41ms)
    preact-local vs preact-main
  • many-updates: unsure 🔍 -3% - +7% (-0.53ms - +1.41ms)
    preact-local vs preact-main
  • replace1k: unsure 🔍 -1% - +2% (-1.01ms - +1.17ms)
    preact-local vs preact-main
  • text-update: unsure 🔍 -1% - +4% (-0.02ms - +0.08ms)
    preact-local vs preact-main
  • todo: unsure 🔍 -1% - +2% (-0.25ms - +0.45ms)
    preact-local vs preact-main
  • update10th1k: unsure 🔍 -2% - +1% (-0.65ms - +0.21ms)
    preact-local vs preact-main

usedJSHeapSize

  • create10k: unsure 🔍 -0% - +0% (-0.01ms - +0.00ms)
    preact-local vs preact-main
  • filter-list: unsure 🔍 -0% - +0% (-0.00ms - +0.00ms)
    preact-local vs preact-main
  • hydrate1k: unsure 🔍 -3% - +2% (-0.37ms - +0.30ms)
    preact-local vs preact-main
  • many-updates: unsure 🔍 -0% - -0% (-0.00ms - -0.00ms)
    preact-local vs preact-main
  • replace1k: unsure 🔍 -0% - +1% (-0.01ms - +0.03ms)
    preact-local vs preact-main
  • text-update: unsure 🔍 -6% - +1% (-0.07ms - +0.01ms)
    preact-local vs preact-main
  • todo: unsure 🔍 -0% - -0% (-0.00ms - -0.00ms)
    preact-local vs preact-main
  • update10th1k: unsure 🔍 -0% - -0% (-0.00ms - -0.00ms)
    preact-local vs preact-main

Results

⏳ Benchmarks are currently running. Results below are out of date.
create10k

duration

VersionAvg timevs preact-localvs preact-main
preact-local903.23ms - 909.42ms-unsure 🔍
-1% - +0%
-7.40ms - +1.91ms
preact-main905.60ms - 912.55msunsure 🔍
-0% - +1%
-1.91ms - +7.40ms
-

usedJSHeapSize

VersionAvg timevs preact-localvs preact-main
preact-local26.75ms - 26.75ms-unsure 🔍
-0% - +0%
-0.01ms - +0.00ms
preact-main26.75ms - 26.76msunsure 🔍
-0% - +0%
-0.00ms - +0.01ms
-
filter-list

duration

VersionAvg timevs preact-localvs preact-main
preact-local16.60ms - 16.71ms-unsure 🔍
-1% - +0%
-0.09ms - +0.07ms
preact-main16.61ms - 16.72msunsure 🔍
-0% - +1%
-0.07ms - +0.09ms
-

usedJSHeapSize

VersionAvg timevs preact-localvs preact-main
preact-local1.75ms - 1.75ms-unsure 🔍
-0% - +0%
-0.00ms - +0.00ms
preact-main1.75ms - 1.75msunsure 🔍
-0% - +0%
-0.00ms - +0.00ms
-
hydrate1k

duration

VersionAvg timevs preact-localvs preact-main
preact-local73.36ms - 76.35ms-unsure 🔍
-4% - +2%
-3.31ms - +1.41ms
preact-main73.98ms - 77.62msunsure 🔍
-2% - +4%
-1.41ms - +3.31ms
-

usedJSHeapSize

VersionAvg timevs preact-localvs preact-main
preact-local14.15ms - 14.64ms-unsure 🔍
-3% - +2%
-0.37ms - +0.30ms
preact-main14.20ms - 14.66msunsure 🔍
-2% - +3%
-0.30ms - +0.37ms
-
many-updates

duration

VersionAvg timevs preact-localvs preact-main
preact-local20.42ms - 21.91ms-unsure 🔍
-3% - +7%
-0.53ms - +1.41ms
preact-main20.10ms - 21.34msunsure 🔍
-7% - +2%
-1.41ms - +0.53ms
-

usedJSHeapSize

VersionAvg timevs preact-localvs preact-main
preact-local4.85ms - 4.86ms-unsure 🔍
-0% - -0%
-0.00ms - -0.00ms
preact-main4.86ms - 4.86msunsure 🔍
+0% - +0%
+0.00ms - +0.00ms
-
replace1k

duration

VersionAvg timevs preact-localvs preact-main
preact-local69.01ms - 70.54ms-unsure 🔍
-1% - +2%
-1.01ms - +1.17ms
preact-main68.92ms - 70.48msunsure 🔍
-2% - +1%
-1.17ms - +1.01ms
-

usedJSHeapSize

VersionAvg timevs preact-localvs preact-main
preact-local3.66ms - 3.69ms-unsure 🔍
-0% - +1%
-0.01ms - +0.03ms
preact-main3.65ms - 3.68msunsure 🔍
-1% - +0%
-0.03ms - +0.01ms
-

run-warmup-0

VersionAvg timevs preact-localvs preact-main
preact-local28.77ms - 29.36ms-unsure 🔍
-1% - +2%
-0.38ms - +0.54ms
preact-main28.64ms - 29.34msunsure 🔍
-2% - +1%
-0.54ms - +0.38ms
-

run-warmup-1

VersionAvg timevs preact-localvs preact-main
preact-local35.60ms - 37.49ms-unsure 🔍
-4% - +3%
-1.46ms - +1.22ms
preact-main35.72ms - 37.62msunsure 🔍
-3% - +4%
-1.22ms - +1.46ms
-

run-warmup-2

VersionAvg timevs preact-localvs preact-main
preact-local25.89ms - 26.19ms-unsure 🔍
-1% - +1%
-0.22ms - +0.21ms
preact-main25.89ms - 26.20msunsure 🔍
-1% - +1%
-0.21ms - +0.22ms
-

run-warmup-3

VersionAvg timevs preact-localvs preact-main
preact-local24.37ms - 25.23ms-unsure 🔍
-0% - +5%
-0.04ms - +1.10ms
preact-main23.91ms - 24.64msunsure 🔍
-4% - +0%
-1.10ms - +0.04ms
-

run-warmup-4

VersionAvg timevs preact-localvs preact-main
preact-local29.19ms - 30.97ms-unsure 🔍
-3% - +5%
-0.91ms - +1.48ms
preact-main29.00ms - 30.60msunsure 🔍
-5% - +3%
-1.48ms - +0.91ms
-

run-final

VersionAvg timevs preact-localvs preact-main
preact-local23.48ms - 24.49ms-unsure 🔍
-5% - +2%
-1.14ms - +0.45ms
preact-main23.71ms - 24.94msunsure 🔍
-2% - +5%
-0.45ms - +1.14ms
-
text-update

duration

VersionAvg timevs preact-localvs preact-main
preact-local1.75ms - 1.83ms-unsure 🔍
-1% - +4%
-0.02ms - +0.08ms
preact-main1.73ms - 1.80msunsure 🔍
-4% - +1%
-0.08ms - +0.02ms
-

usedJSHeapSize

VersionAvg timevs preact-localvs preact-main
preact-local1.12ms - 1.18ms-unsure 🔍
-6% - +1%
-0.07ms - +0.01ms
preact-main1.15ms - 1.21msunsure 🔍
-1% - +6%
-0.01ms - +0.07ms
-
todo

duration

VersionAvg timevs preact-localvs preact-main
preact-local28.61ms - 29.12ms-unsure 🔍
-1% - +2%
-0.25ms - +0.45ms
preact-main28.52ms - 29.01msunsure 🔍
-2% - +1%
-0.45ms - +0.25ms
-

usedJSHeapSize

VersionAvg timevs preact-localvs preact-main
preact-local1.25ms - 1.25ms-unsure 🔍
-0% - -0%
-0.00ms - -0.00ms
preact-main1.25ms - 1.25msunsure 🔍
+0% - +0%
+0.00ms - +0.00ms
-
update10th1k

duration

VersionAvg timevs preact-localvs preact-main
preact-local30.68ms - 31.15ms-unsure 🔍
-2% - +1%
-0.65ms - +0.21ms
preact-main30.78ms - 31.50msunsure 🔍
-1% - +2%
-0.21ms - +0.65ms
-

usedJSHeapSize

VersionAvg timevs preact-localvs preact-main
preact-local3.69ms - 3.69ms-unsure 🔍
-0% - -0%
-0.00ms - -0.00ms
preact-main3.70ms - 3.70msunsure 🔍
+0% - +0%
+0.00ms - +0.00ms
-

tachometer-reporter-action v2 for Benchmarks

Copy link

github-actions bot commented May 15, 2024

Size Change: 0 B

Total Size: 61.4 kB

ℹ️ View Unchanged
Filename Size
compat/dist/compat.js 4.09 kB
compat/dist/compat.module.js 4.01 kB
compat/dist/compat.umd.js 4.14 kB
debug/dist/debug.js 3.71 kB
debug/dist/debug.module.js 3.71 kB
debug/dist/debug.umd.js 3.79 kB
devtools/dist/devtools.js 231 B
devtools/dist/devtools.module.js 240 B
devtools/dist/devtools.umd.js 314 B
dist/preact.js 4.63 kB
dist/preact.min.js 4.67 kB
dist/preact.min.module.js 4.66 kB
dist/preact.min.umd.js 4.69 kB
dist/preact.module.js 4.65 kB
dist/preact.umd.js 4.71 kB
hooks/dist/hooks.js 1.55 kB
hooks/dist/hooks.module.js 1.59 kB
hooks/dist/hooks.umd.js 1.63 kB
jsx-runtime/dist/jsxRuntime.js 976 B
jsx-runtime/dist/jsxRuntime.module.js 949 B
jsx-runtime/dist/jsxRuntime.umd.js 1.06 kB
test-utils/dist/testUtils.js 453 B
test-utils/dist/testUtils.module.js 454 B
test-utils/dist/testUtils.umd.js 536 B

compressed-size-action

@JoviDeCroock JoviDeCroock merged commit d60c5cb into main May 15, 2024
21 checks passed
@JoviDeCroock JoviDeCroock deleted the migrate-to-biome branch May 15, 2024 10:12
@coveralls
Copy link

coveralls commented May 15, 2024

Coverage Status

coverage: 99.61% (+0.001%) from 99.609%
when pulling 61588f4 on migrate-to-biome
into cece8c3 on main.

@g-plane
Copy link

g-plane commented May 15, 2024

Hey, Biome doesn't support HTML and CSS/SCSS at this moment. Would you like to migrate to dprint? We can use dprint with dprint-plugin-biome for JavaScript, Malva for CSS/SCSS and markup_fmt for HTML.

@JoviDeCroock JoviDeCroock mentioned this pull request Jun 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants