-
-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
compat: Improve React compatibility for Ref
type.
#4403
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The commit improves React compatibility by re-exporting `Ref` from core instead of hooks.
rschristian
reviewed
May 31, 2024
rschristian
approved these changes
Jun 2, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Cheers, thanks for going beyond too! It'll hopefully correct similar mismatches in the future.
Merged
miguelrk
added a commit
to netzo/dsa
that referenced
this pull request
Jul 9, 2024
…to DOM issues See the following for the changes introduced which might have caused this: - preactjs/preact#4409 - preactjs/preact#4421 - preactjs/preact#4403
This was referenced Aug 14, 2024
This was referenced Sep 3, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In React, the
Ref
type corresponds to theRef
type in preact core. However,preact/compat
re-exports theRef
type frompreact/hooks
instead of from core.The following snippet does not produce a type error in React, but it does when using preact:
In preact it produces
Type 'ForwardedRef<HTMLElement>' is not assignable to type 'Ref<HTMLElement>'.
This pull requests fixes this issue.