Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

graciously handle array shuffling #4413

Merged
merged 4 commits into from
Jun 25, 2024
Merged

graciously handle array shuffling #4413

merged 4 commits into from
Jun 25, 2024

Conversation

JoviDeCroock
Copy link
Member

Fixes #4412

I will have to do a second pass to make these comments better because every time I dive through this in search of bugs I have to re-ingest this whole algorithm

@github-actions GitHub Actions
Copy link

github-actions bot commented Jun 18, 2024 •
edited
Loading

📊 Tachometer Benchmark Results

Summary

duration

  • create10k: unsure 🔍 -1% - +1% (-8.96ms - +4.95ms)
    preact-local vs preact-main
  • filter-list: unsure 🔍 -1% - +4% (-0.12ms - +0.65ms)
    preact-local vs preact-main
  • hydrate1k: unsure 🔍 -2% - +1% (-1.63ms - +1.12ms)
    preact-local vs preact-main
  • many-updates: unsure 🔍 -4% - +1% (-0.62ms - +0.24ms)
    preact-local vs preact-main
  • replace1k: unsure 🔍 -3% - +2% (-2.18ms - +1.20ms)
    preact-local vs preact-main
  • text-update: unsure 🔍 -3% - +5% (-0.05ms - +0.09ms)
    preact-local vs preact-main
  • todo: unsure 🔍 -2% - +1% (-0.51ms - +0.17ms)
    preact-local vs preact-main
  • update10th1k: unsure 🔍 -2% - +2% (-0.50ms - +0.65ms)
    preact-local vs preact-main

usedJSHeapSize

  • create10k: unsure 🔍 +0% - +0% (+0.00ms - +0.00ms)
    preact-local vs preact-main
  • filter-list: slower ❌ 0% - 1% (0.00ms - 0.01ms)
    preact-local vs preact-main
  • hydrate1k: unsure 🔍 -1% - +2% (-0.17ms - +0.27ms)
    preact-local vs preact-main
  • many-updates: unsure 🔍 -0% - +0% (-0.00ms - +0.01ms)
    preact-local vs preact-main
  • replace1k: unsure 🔍 -0% - +1% (-0.00ms - +0.04ms)
    preact-local vs preact-main
  • text-update: unsure 🔍 +0% - +0% (+0.00ms - +0.00ms)
    preact-local vs preact-main
  • todo: unsure 🔍 +0% - +0% (+0.00ms - +0.00ms)
    preact-local vs preact-main
  • update10th1k: unsure 🔍 +0% - +0% (+0.00ms - +0.00ms)
    preact-local vs preact-main

Results

create10k

duration

VersionAvg timevs preact-localvs preact-main
preact-local862.44ms - 870.39ms-unsure 🔍
-1% - +1%
-8.96ms - +4.95ms
preact-main862.71ms - 874.13msunsure 🔍
-1% - +1%
-4.95ms - +8.96ms		-

usedJSHeapSize

VersionAvg timevs preact-localvs preact-main
preact-local25.15ms - 25.15ms-unsure 🔍
+0% - +0%
+0.00ms - +0.00ms
preact-main25.15ms - 25.15msunsure 🔍
-0% - -0%
-0.00ms - -0.00ms		-
filter-list

duration

VersionAvg timevs preact-localvs preact-main
preact-local16.57ms - 17.34ms-unsure 🔍
-1% - +4%
-0.12ms - +0.65ms
preact-main16.63ms - 16.75msunsure 🔍
-4% - +1%
-0.65ms - +0.12ms		-

usedJSHeapSize

VersionAvg timevs preact-localvs preact-main
preact-local1.69ms - 1.70ms-slower ❌
0% - 1%
0.00ms - 0.01ms
preact-main1.69ms - 1.69msfaster ✔
0% - 1%
0.00ms - 0.01ms		-
hydrate1k

duration

VersionAvg timevs preact-localvs preact-main
preact-local77.80ms - 79.39ms-unsure 🔍
-2% - +1%
-1.63ms - +1.12ms
preact-main77.72ms - 79.97msunsure 🔍
-1% - +2%
-1.12ms - +1.63ms		-

usedJSHeapSize

VersionAvg timevs preact-localvs preact-main
preact-local15.42ms - 15.76ms-unsure 🔍
-1% - +2%
-0.17ms - +0.27ms
preact-main15.40ms - 15.67msunsure 🔍
-2% - +1%
-0.27ms - +0.17ms		-
many-updates

duration

VersionAvg timevs preact-localvs preact-main
preact-local16.71ms - 17.26ms-unsure 🔍
-4% - +1%
-0.62ms - +0.24ms
preact-main16.84ms - 17.50msunsure 🔍
-1% - +4%
-0.24ms - +0.62ms		-

usedJSHeapSize

VersionAvg timevs preact-localvs preact-main
preact-local4.61ms - 4.62ms-unsure 🔍
-0% - +0%
-0.00ms - +0.01ms
preact-main4.61ms - 4.61msunsure 🔍
-0% - +0%
-0.01ms - +0.00ms		-
replace1k

duration

VersionAvg timevs preact-localvs preact-main
preact-local76.35ms - 78.71ms-unsure 🔍
-3% - +2%
-2.18ms - +1.20ms
preact-main76.81ms - 79.24msunsure 🔍
-2% - +3%
-1.20ms - +2.18ms		-

usedJSHeapSize

VersionAvg timevs preact-localvs preact-main
preact-local3.53ms - 3.56ms-unsure 🔍
-0% - +1%
-0.00ms - +0.04ms
preact-main3.51ms - 3.54msunsure 🔍
-1% - +0%
-0.04ms - +0.00ms		-

run-warmup-0

VersionAvg timevs preact-localvs preact-main
preact-local28.87ms - 29.39ms-unsure 🔍
-1% - +2%
-0.16ms - +0.54ms
preact-main28.70ms - 29.18msunsure 🔍
-2% - +1%
-0.54ms - +0.16ms		-

run-warmup-1

VersionAvg timevs preact-localvs preact-main
preact-local34.76ms - 36.73ms-unsure 🔍
-3% - +5%
-1.09ms - +1.64ms
preact-main34.51ms - 36.42msunsure 🔍
-5% - +3%
-1.64ms - +1.09ms		-

run-warmup-2

VersionAvg timevs preact-localvs preact-main
preact-local25.35ms - 25.87ms-unsure 🔍
-1% - +2%
-0.35ms - +0.56ms
preact-main25.13ms - 25.88msunsure 🔍
-2% - +1%
-0.56ms - +0.35ms		-

run-warmup-3

VersionAvg timevs preact-localvs preact-main
preact-local30.11ms - 31.77ms-unsure 🔍
-6% - +1%
-1.75ms - +0.42ms
preact-main30.91ms - 32.30msunsure 🔍
-1% - +6%
-0.42ms - +1.75ms		-

run-warmup-4

VersionAvg timevs preact-localvs preact-main
preact-local21.92ms - 23.26ms-unsure 🔍
-1% - +7%
-0.15ms - +1.56ms
preact-main21.35ms - 22.42msunsure 🔍
-7% - +1%
-1.56ms - +0.15ms		-

run-final

VersionAvg timevs preact-localvs preact-main
preact-local23.75ms - 24.82ms-slower ❌
0% - 7%
0.09ms - 1.54ms
preact-main22.98ms - 23.96msfaster ✔
0% - 6%
0.09ms - 1.54ms		-
text-update

duration

VersionAvg timevs preact-localvs preact-main
preact-local2.00ms - 2.10ms-unsure 🔍
-3% - +5%
-0.05ms - +0.09ms
preact-main1.98ms - 2.08msunsure 🔍
-5% - +3%
-0.09ms - +0.05ms		-

usedJSHeapSize

VersionAvg timevs preact-localvs preact-main
preact-local0.98ms - 0.98ms-unsure 🔍
+0% - +0%
+0.00ms - +0.00ms
preact-main0.98ms - 0.98msunsure 🔍
-0% - -0%
-0.00ms - -0.00ms		-
todo

duration

VersionAvg timevs preact-localvs preact-main
preact-local27.23ms - 27.41ms-unsure 🔍
-2% - +1%
-0.51ms - +0.17ms
preact-main27.16ms - 27.82msunsure 🔍
-1% - +2%
-0.17ms - +0.51ms		-

usedJSHeapSize

VersionAvg timevs preact-localvs preact-main
preact-local1.25ms - 1.25ms-unsure 🔍
+0% - +0%
+0.00ms - +0.00ms
preact-main1.25ms - 1.25msunsure 🔍
-0% - -0%
-0.00ms - -0.00ms		-
update10th1k

duration

VersionAvg timevs preact-localvs preact-main
preact-local30.59ms - 31.41ms-unsure 🔍
-2% - +2%
-0.50ms - +0.65ms
preact-main30.52ms - 31.33msunsure 🔍
-2% - +2%
-0.65ms - +0.50ms		-

usedJSHeapSize

VersionAvg timevs preact-localvs preact-main
preact-local3.55ms - 3.55ms-unsure 🔍
+0% - +0%
+0.00ms - +0.00ms
preact-main3.55ms - 3.55msunsure 🔍
-0% - -0%
-0.00ms - -0.00ms		-

tachometer-reporter-action v2 for Benchmarks

@github-actions GitHub Actions
Copy link

github-actions bot commented Jun 18, 2024 •
edited
Loading

Size Change: -29 B (-0.05%)

Total Size: 61.8 kB

Filename Size Change
dist/preact.js 4.67 kB -5 B (-0.11%)
dist/preact.min.js 4.71 kB -5 B (-0.11%)
dist/preact.min.module.js 4.7 kB -6 B (-0.13%)
dist/preact.min.umd.js 4.73 kB -4 B (-0.08%)
dist/preact.module.js 4.7 kB -4 B (-0.09%)
dist/preact.umd.js 4.75 kB -5 B (-0.11%)
ℹ️ View Unchanged
Filename Size
compat/dist/compat.js 4.09 kB
compat/dist/compat.module.js 4.01 kB
compat/dist/compat.umd.js 4.15 kB
debug/dist/debug.js 3.7 kB
debug/dist/debug.module.js 3.71 kB
debug/dist/debug.umd.js 3.78 kB
devtools/dist/devtools.js 259 B
devtools/dist/devtools.module.js 273 B
devtools/dist/devtools.umd.js 345 B
hooks/dist/hooks.js 1.56 kB
hooks/dist/hooks.module.js 1.59 kB
hooks/dist/hooks.umd.js 1.63 kB
jsx-runtime/dist/jsxRuntime.js 981 B
jsx-runtime/dist/jsxRuntime.module.js 956 B
jsx-runtime/dist/jsxRuntime.umd.js 1.06 kB
test-utils/dist/testUtils.js 451 B
test-utils/dist/testUtils.module.js 456 B
test-utils/dist/testUtils.umd.js 536 B

compressed-size-action

@coveralls
Copy link

Coverage Status

coverage: 99.611%. remained the same
when pulling eec4c12 on handle-shuffles
into 4c20c23 on main.

@coveralls
Copy link

Coverage Status

coverage: 99.611%. remained the same
when pulling eec4c12 on handle-shuffles
into 4c20c23 on main.

@coveralls
Copy link

Coverage Status

coverage: 99.611%. remained the same
when pulling cbd531c on handle-shuffles
into 4c20c23 on main.

@coveralls
Copy link

Coverage Status

coverage: 99.611%. remained the same
when pulling cbd531c on handle-shuffles
into 4c20c23 on main.

JoviDeCroock
JoviDeCroock commented Jun 18, 2024
View reviewed changes
src/diff/children.js Outdated Show resolved Hide resolved
@coveralls
Copy link

Coverage Status

coverage: 99.61% (-0.001%) from 99.611%
when pulling c189ade on handle-shuffles
into 4c20c23 on main.

@coveralls
Copy link

Coverage Status

coverage: 99.61% (-0.001%) from 99.611%
when pulling c189ade on handle-shuffles
into 4c20c23 on main.

@coveralls
Copy link

Coverage Status

coverage: 99.61% (-0.001%) from 99.611%
when pulling c189ade on handle-shuffles
into 4c20c23 on main.

@coveralls
Copy link

Coverage Status

coverage: 99.61% (-0.001%) from 99.611%
when pulling c189ade on handle-shuffles
into 4c20c23 on main.

@coveralls
Copy link

Coverage Status

coverage: 99.61% (-0.001%) from 99.611%
when pulling c189ade on handle-shuffles
into 4c20c23 on main.

@coveralls
Copy link

Coverage Status

coverage: 99.61% (-0.001%) from 99.611%
when pulling c189ade on handle-shuffles
into 4c20c23 on main.

@coveralls
Copy link

Coverage Status

coverage: 99.611%. remained the same
when pulling 2495988 on handle-shuffles
into 4c20c23 on main.

@coveralls
Copy link

Coverage Status

coverage: 99.611%. remained the same
when pulling 2495988 on handle-shuffles
into 4c20c23 on main.

@coveralls
Copy link

Coverage Status

coverage: 99.611%. remained the same
when pulling 2495988 on handle-shuffles
into 4c20c23 on main.

@coveralls
Copy link

Coverage Status

coverage: 99.611%. remained the same
when pulling 2495988 on handle-shuffles
into 4c20c23 on main.

@coveralls
Copy link

Coverage Status

coverage: 99.611%. remained the same
when pulling 8b7ed66 on handle-shuffles
into 4c20c23 on main.

@coveralls
Copy link

Coverage Status

coverage: 99.611%. remained the same
when pulling 8b7ed66 on handle-shuffles
into 4c20c23 on main.

@coveralls
Copy link

Coverage Status

coverage: 99.611%. remained the same
when pulling c739eae on handle-shuffles
into 4c20c23 on main.

@coveralls
Copy link

Coverage Status

coverage: 99.611%. remained the same
when pulling c739eae on handle-shuffles
into 4c20c23 on main.

@JoviDeCroock JoviDeCroock merged commit 92e86e9 into main Jun 25, 2024
13 checks passed
@JoviDeCroock JoviDeCroock deleted the handle-shuffles branch June 25, 2024 13:03
@JoviDeCroock JoviDeCroock mentioned this pull request Jun 30, 2024
Merged
@X-oss-byte X-oss-byte mentioned this pull request Jul 22, 2024
Open
@lorenzoAtBEIS lorenzoAtBEIS mentioned this pull request Aug 10, 2024
Merged
@ZeroXClem ZeroXClem mentioned this pull request Aug 12, 2024
Closed
This was referenced Aug 14, 2024
Open
Open
@ramzimalhas ramzimalhas mentioned this pull request Aug 22, 2024
Open
This was referenced Sep 3, 2024
Open
Open
@arkid15r arkid15r mentioned this pull request Sep 11, 2024
Closed
@ntavassoli-dot ntavassoli-dot mentioned this pull request Sep 13, 2024
Open
This was referenced Sep 13, 2024
Open
Open
@organich organich mentioned this pull request Sep 24, 2024
Open
@X-oss-byte X-oss-byte mentioned this pull request Oct 5, 2024
Open
@X-oss-byte X-oss-byte mentioned this pull request Oct 18, 2024
Open
@X-oss-byte X-oss-byte mentioned this pull request Oct 25, 2024
Open
@Xcaciv Xcaciv mentioned this pull request Oct 27, 2024
Open
@dwhiteGUK dwhiteGUK mentioned this pull request Oct 28, 2024
Open
@abaum65 abaum65 mentioned this pull request Oct 31, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@marvinhagemeister marvinhagemeister marvinhagemeister approved these changes

@developit developit Awaiting requested review from developit

@andrewiggins andrewiggins Awaiting requested review from andrewiggins

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

preact@10.22.0 unexpected child ordering with skew based diff
3 participants
@JoviDeCroock @coveralls @marvinhagemeister