Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add shuffling stress test and fix shifting to the front #4472

Merged
merged 1 commit into from
Aug 9, 2024
Merged

Add shuffling stress test and fix shifting to the front #4472

merged 1 commit into from
Aug 9, 2024

Conversation

JoviDeCroock
Copy link
Member

Another issue found in #4412 - now with shifting elements to the front so we'll hit the case more where the matchingIndex is smaller than the skewed one. This fix is highly similar to the original one, due to the issues we have seen here I decided to add in that stress test to uncover potential issues in the future. Open to removing it and leaving it in as a comment to uncover issues with certain patterns.

@github-actions GitHub Actions
Copy link

github-actions bot commented Aug 9, 2024 •
edited
Loading

📊 Tachometer Benchmark Results

Summary

duration

  • create10k: unsure 🔍 -1% - +2% (-11.56ms - +16.73ms)
    preact-local vs preact-main
  • filter-list: unsure 🔍 -3% - +2% (-0.54ms - +0.37ms)
    preact-local vs preact-main
  • hydrate1k: unsure 🔍 -3% - +2% (-2.19ms - +1.63ms)
    preact-local vs preact-main
  • many-updates: unsure 🔍 -0% - +1% (-0.04ms - +0.21ms)
    preact-local vs preact-main
  • replace1k: unsure 🔍 -1% - +4% (-0.76ms - +2.81ms)
    preact-local vs preact-main
  • text-update: unsure 🔍 -1% - +5% (-0.02ms - +0.09ms)
    preact-local vs preact-main
  • todo: unsure 🔍 -1% - +3% (-0.34ms - +0.84ms)
    preact-local vs preact-main
  • update10th1k: unsure 🔍 -2% - +4% (-0.67ms - +1.38ms)
    preact-local vs preact-main

usedJSHeapSize

  • create10k: unsure 🔍 -0% - +0% (-0.02ms - +0.00ms)
    preact-local vs preact-main
  • filter-list: unsure 🔍 -0% - +0% (-0.01ms - +0.00ms)
    preact-local vs preact-main
  • hydrate1k: unsure 🔍 -2% - +1% (-0.26ms - +0.17ms)
    preact-local vs preact-main
  • many-updates: unsure 🔍 -0% - +0% (-0.00ms - +0.00ms)
    preact-local vs preact-main
  • replace1k: unsure 🔍 -1% - +0% (-0.02ms - +0.02ms)
    preact-local vs preact-main
  • text-update: unsure 🔍 +0% - +0% (+0.00ms - +0.00ms)
    preact-local vs preact-main
  • todo: unsure 🔍 +0% - +0% (+0.00ms - +0.00ms)
    preact-local vs preact-main
  • update10th1k: unsure 🔍 -0% - +0% (-0.00ms - +0.01ms)
    preact-local vs preact-main

Results

create10k

duration

VersionAvg timevs preact-localvs preact-main
preact-local872.78ms - 893.32ms-unsure 🔍
-1% - +2%
-11.56ms - +16.73ms
preact-main870.74ms - 890.19msunsure 🔍
-2% - +1%
-16.73ms - +11.56ms		-

usedJSHeapSize

VersionAvg timevs preact-localvs preact-main
preact-local25.29ms - 25.32ms-unsure 🔍
-0% - +0%
-0.02ms - +0.00ms
preact-main25.31ms - 25.31msunsure 🔍
-0% - +0%
-0.00ms - +0.02ms		-
filter-list

duration

VersionAvg timevs preact-localvs preact-main
preact-local16.54ms - 17.01ms-unsure 🔍
-3% - +2%
-0.54ms - +0.37ms
preact-main16.47ms - 17.25msunsure 🔍
-2% - +3%
-0.37ms - +0.54ms		-

usedJSHeapSize

VersionAvg timevs preact-localvs preact-main
preact-local1.69ms - 1.70ms-unsure 🔍
-0% - +0%
-0.01ms - +0.00ms
preact-main1.70ms - 1.70msunsure 🔍
-0% - +0%
-0.00ms - +0.01ms		-
hydrate1k

duration

VersionAvg timevs preact-localvs preact-main
preact-local69.01ms - 71.04ms-unsure 🔍
-3% - +2%
-2.19ms - +1.63ms
preact-main68.69ms - 71.92msunsure 🔍
-2% - +3%
-1.63ms - +2.19ms		-

usedJSHeapSize

VersionAvg timevs preact-localvs preact-main
preact-local15.57ms - 15.84ms-unsure 🔍
-2% - +1%
-0.26ms - +0.17ms
preact-main15.58ms - 15.92msunsure 🔍
-1% - +2%
-0.17ms - +0.26ms		-
many-updates

duration

VersionAvg timevs preact-localvs preact-main
preact-local16.53ms - 16.57ms-unsure 🔍
-0% - +1%
-0.04ms - +0.21ms
preact-main16.34ms - 16.59msunsure 🔍
-1% - +0%
-0.21ms - +0.04ms		-

usedJSHeapSize

VersionAvg timevs preact-localvs preact-main
preact-local4.61ms - 4.61ms-unsure 🔍
-0% - +0%
-0.00ms - +0.00ms
preact-main4.61ms - 4.61msunsure 🔍
-0% - +0%
-0.00ms - +0.00ms		-
replace1k

duration

VersionAvg timevs preact-localvs preact-main
preact-local74.54ms - 77.13ms-unsure 🔍
-1% - +4%
-0.76ms - +2.81ms
preact-main73.58ms - 76.04msunsure 🔍
-4% - +1%
-2.81ms - +0.76ms		-

usedJSHeapSize

VersionAvg timevs preact-localvs preact-main
preact-local3.48ms - 3.50ms-unsure 🔍
-1% - +0%
-0.02ms - +0.02ms
preact-main3.48ms - 3.51msunsure 🔍
-0% - +1%
-0.02ms - +0.02ms		-

run-warmup-0

VersionAvg timevs preact-localvs preact-main
preact-local28.74ms - 29.25ms-unsure 🔍
-2% - +1%
-0.54ms - +0.32ms
preact-main28.76ms - 29.45msunsure 🔍
-1% - +2%
-0.32ms - +0.54ms		-

run-warmup-1

VersionAvg timevs preact-localvs preact-main
preact-local33.19ms - 34.58ms-unsure 🔍
-3% - +2%
-1.14ms - +0.82ms
preact-main33.35ms - 34.73msunsure 🔍
-2% - +3%
-0.82ms - +1.14ms		-

run-warmup-2

VersionAvg timevs preact-localvs preact-main
preact-local25.11ms - 25.59ms-unsure 🔍
-3% - +1%
-0.69ms - +0.27ms
preact-main25.14ms - 25.98msunsure 🔍
-1% - +3%
-0.27ms - +0.69ms		-

run-warmup-3

VersionAvg timevs preact-localvs preact-main
preact-local29.96ms - 31.64ms-unsure 🔍
-1% - +7%
-0.14ms - +1.93ms
preact-main29.30ms - 30.52msunsure 🔍
-6% - +0%
-1.93ms - +0.14ms		-

run-warmup-4

VersionAvg timevs preact-localvs preact-main
preact-local22.32ms - 23.97ms-unsure 🔍
-7% - +4%
-1.58ms - +0.93ms
preact-main22.53ms - 24.41msunsure 🔍
-4% - +7%
-0.93ms - +1.58ms		-

run-final

VersionAvg timevs preact-localvs preact-main
preact-local22.68ms - 23.63ms-unsure 🔍
-2% - +4%
-0.52ms - +0.86ms
preact-main22.48ms - 23.49msunsure 🔍
-4% - +2%
-0.86ms - +0.52ms		-
text-update

duration

VersionAvg timevs preact-localvs preact-main
preact-local1.90ms - 1.97ms-unsure 🔍
-1% - +5%
-0.02ms - +0.09ms
preact-main1.86ms - 1.94msunsure 🔍
-5% - +1%
-0.09ms - +0.02ms		-

usedJSHeapSize

VersionAvg timevs preact-localvs preact-main
preact-local0.98ms - 0.98ms-unsure 🔍
+0% - +0%
+0.00ms - +0.00ms
preact-main0.98ms - 0.98msunsure 🔍
-0% - -0%
-0.00ms - -0.00ms		-
todo

duration

VersionAvg timevs preact-localvs preact-main
preact-local26.24ms - 27.18ms-unsure 🔍
-1% - +3%
-0.34ms - +0.84ms
preact-main26.11ms - 26.81msunsure 🔍
-3% - +1%
-0.84ms - +0.34ms		-

usedJSHeapSize

VersionAvg timevs preact-localvs preact-main
preact-local1.25ms - 1.25ms-unsure 🔍
+0% - +0%
+0.00ms - +0.00ms
preact-main1.25ms - 1.25msunsure 🔍
-0% - -0%
-0.00ms - -0.00ms		-
update10th1k

duration

VersionAvg timevs preact-localvs preact-main
preact-local31.24ms - 32.69ms-unsure 🔍
-2% - +4%
-0.67ms - +1.38ms
preact-main30.89ms - 32.33msunsure 🔍
-4% - +2%
-1.38ms - +0.67ms		-

usedJSHeapSize

VersionAvg timevs preact-localvs preact-main
preact-local3.57ms - 3.58ms-unsure 🔍
-0% - +0%
-0.00ms - +0.01ms
preact-main3.56ms - 3.58msunsure 🔍
-0% - +0%
-0.01ms - +0.00ms		-

tachometer-reporter-action v2 for Benchmarks

@github-actions GitHub Actions
Copy link

github-actions bot commented Aug 9, 2024 •
edited
Loading

Size Change: +27 B (+0.04%)

Total Size: 62.1 kB

Filename Size Change
dist/preact.js 4.72 kB +5 B (+0.11%)
dist/preact.min.js 4.75 kB +5 B (+0.11%)
dist/preact.min.module.js 4.75 kB +5 B (+0.11%)
dist/preact.min.umd.js 4.78 kB +4 B (+0.08%)
dist/preact.module.js 4.74 kB +5 B (+0.11%)
dist/preact.umd.js 4.8 kB +3 B (+0.06%)
ℹ️ View Unchanged
Filename Size
compat/dist/compat.js 4.11 kB
compat/dist/compat.module.js 4.04 kB
compat/dist/compat.umd.js 4.18 kB
debug/dist/debug.js 3.7 kB
debug/dist/debug.module.js 3.71 kB
debug/dist/debug.umd.js 3.78 kB
devtools/dist/devtools.js 259 B
devtools/dist/devtools.module.js 274 B
devtools/dist/devtools.umd.js 345 B
hooks/dist/hooks.js 1.53 kB
hooks/dist/hooks.module.js 1.56 kB
hooks/dist/hooks.umd.js 1.6 kB
jsx-runtime/dist/jsxRuntime.js 981 B
jsx-runtime/dist/jsxRuntime.module.js 956 B
jsx-runtime/dist/jsxRuntime.umd.js 1.06 kB
test-utils/dist/testUtils.js 451 B
test-utils/dist/testUtils.module.js 456 B
test-utils/dist/testUtils.umd.js 536 B

compressed-size-action

@coveralls
Copy link

coveralls commented Aug 9, 2024 •
edited
Loading

Coverage Status

coverage: 99.486%. remained the same
when pulling 7bcf463 on add-stress-test
into 91679e5 on main.

@JoviDeCroock JoviDeCroock mentioned this pull request Aug 9, 2024
Closed
1 task
@JoviDeCroock JoviDeCroock merged commit 7b5b240 into main Aug 9, 2024
13 checks passed
@JoviDeCroock JoviDeCroock deleted the add-stress-test branch August 9, 2024 10:10
@JoviDeCroock JoviDeCroock mentioned this pull request Aug 12, 2024
Merged
@X-oss-byte X-oss-byte mentioned this pull request Sep 3, 2024
Open
@lorenzoAtBEIS lorenzoAtBEIS mentioned this pull request Sep 7, 2024
Merged
@X-oss-byte X-oss-byte mentioned this pull request Sep 8, 2024
Open
@arkid15r arkid15r mentioned this pull request Sep 11, 2024
Closed
@ntavassoli-dot ntavassoli-dot mentioned this pull request Sep 13, 2024
Open
This was referenced Sep 13, 2024
Open
Open
@organich organich mentioned this pull request Sep 24, 2024
Open
@X-oss-byte X-oss-byte mentioned this pull request Oct 5, 2024
Open
@lorenzoAtBEIS lorenzoAtBEIS mentioned this pull request Oct 7, 2024
Merged
@X-oss-byte X-oss-byte mentioned this pull request Oct 18, 2024
Open
@X-oss-byte X-oss-byte mentioned this pull request Oct 25, 2024
Open
@Xcaciv Xcaciv mentioned this pull request Oct 27, 2024
Open
@dwhiteGUK dwhiteGUK mentioned this pull request Oct 28, 2024
Open
@abaum65 abaum65 mentioned this pull request Oct 31, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@marvinhagemeister marvinhagemeister marvinhagemeister approved these changes

@developit developit Awaiting requested review from developit

@andrewiggins andrewiggins Awaiting requested review from andrewiggins

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@JoviDeCroock @coveralls @marvinhagemeister