-
-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improve performance and reduce memory allocation #4521
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
📊 Tachometer Benchmark ResultsSummaryduration
usedJSHeapSize
Resultscreate10k
duration
usedJSHeapSize
filter-list
duration
usedJSHeapSize
hydrate1k
duration
usedJSHeapSize
many-updates
duration
usedJSHeapSize
replace1k
duration
usedJSHeapSize
run-warmup-0
run-warmup-1
run-warmup-2
run-warmup-3
run-warmup-4
run-final
text-update
duration
usedJSHeapSize
todo
duration
usedJSHeapSize
update10th1k
duration
usedJSHeapSize
|
Size Change: +20 B (+0.03%) Total Size: 62.1 kB
ℹ️ View Unchanged
|
JoviDeCroock
force-pushed
the
less-memory-allocation
branch
2 times, most recently
from
October 2, 2024 16:30
e7e9396
to
33d1496
Compare
JoviDeCroock
requested review from
developit,
marvinhagemeister and
rschristian
October 2, 2024 16:31
rschristian
approved these changes
Oct 2, 2024
JoviDeCroock
force-pushed
the
less-memory-allocation
branch
from
October 2, 2024 18:24
faca985
to
5de3be2
Compare
JoviDeCroock
force-pushed
the
less-memory-allocation
branch
2 times, most recently
from
October 2, 2024 18:41
85f218d
to
79303ec
Compare
marvinhagemeister
approved these changes
Oct 3, 2024
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As @developit found out,
delete x
is much faster nowadays.jsx
we delete the ref and always keep the props object, no cloningforwardRef
we delete and re-apply theref
to the props object to avoid cloningforwardRef
we add a bail case where we keep props when noref
is passed to us