Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: Run PR Reporter even against PRs from forks #4643

Merged
merged 1 commit into from
Jan 25, 2025

Conversation

rschristian
Copy link
Member

@rschristian rschristian commented Jan 25, 2025

For a while now we haven't been getting benchmark comments on PRs from forks (e.g., #4642), only realized once @jviide brought it up last week.

It's a big time range, but as of #4325 it was working, and by #4471 it was not, and we didn't have any alterations to our config during that time.

Did some debugging in another repo and, as best as I can tell, it seems like it's the branches config that is the issue and seems to be born from a change GitHub made (due to use not altering this field, or any other, during the time frame mentioned above). If we remove that filter the reporter does seem to run just fine, with it, it never gets picked up. This config should be unnecessary anyhow, as the default behavior is to track everything, so removal seems correct.

@coveralls
Copy link

Coverage Status

coverage: 99.618%. remained the same
when pulling 2094be8 on ci/fix-pr-reporter-forks
into 4b7e231 on main.

@rschristian rschristian merged commit 818eafb into main Jan 25, 2025
5 checks passed
@rschristian rschristian deleted the ci/fix-pr-reporter-forks branch January 25, 2025 09:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants