ci: Run PR Reporter even against PRs from forks #4643
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For a while now we haven't been getting benchmark comments on PRs from forks (e.g., #4642), only realized once @jviide brought it up last week.
It's a big time range, but as of #4325 it was working, and by #4471 it was not, and we didn't have any alterations to our config during that time.
Did some debugging in another repo and, as best as I can tell, it seems like it's the
branches
config that is the issue and seems to be born from a change GitHub made (due to use not altering this field, or any other, during the time frame mentioned above). If we remove that filter the reporter does seem to run just fine, with it, it never gets picked up. This config should be unnecessary anyhow, as the default behavior is to track everything, so removal seems correct.