Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Look at impact of removing deprecated lifecycles #4656

Merged
merged 1 commit into from
Feb 13, 2025

Conversation

JoviDeCroock
Copy link
Member

No description provided.

Copy link

github-actions bot commented Feb 12, 2025

📊 Tachometer Benchmark Results

Summary

⏳ Benchmarks are currently running. Results below are out of date.

duration

  • create10k: unsure 🔍 -0% - +1% (-3.20ms - +5.42ms)
    preact-local vs preact-main
  • filter-list: unsure 🔍 -0% - +0% (-0.02ms - +0.05ms)
    preact-local vs preact-main
  • hydrate1k: unsure 🔍 -1% - +1% (-0.82ms - +0.90ms)
    preact-local vs preact-main
  • many-updates: unsure 🔍 -4% - +1% (-0.62ms - +0.10ms)
    preact-local vs preact-main
  • replace1k: unsure 🔍 -2% - +1% (-1.45ms - +0.69ms)
    preact-local vs preact-main
  • text-update: unsure 🔍 -5% - +1% (-0.10ms - +0.02ms)
    preact-local vs preact-main
  • todo: unsure 🔍 -1% - +2% (-0.42ms - +0.62ms)
    preact-local vs preact-main
  • update10th1k: unsure 🔍 -3% - +5% (-1.00ms - +1.51ms)
    preact-local vs preact-main

usedJSHeapSize

  • create10k: unsure 🔍 -0% - +0% (-0.00ms - +0.01ms)
    preact-local vs preact-main
  • filter-list: unsure 🔍 -1% - +1% (-0.01ms - +0.01ms)
    preact-local vs preact-main
  • hydrate1k: unsure 🔍 -1% - +7% (-0.10ms - +0.65ms)
    preact-local vs preact-main
  • many-updates: unsure 🔍 -0% - +0% (-0.00ms - +0.00ms)
    preact-local vs preact-main
  • replace1k: unsure 🔍 -1% - +0% (-0.02ms - +0.01ms)
    preact-local vs preact-main
  • text-update: unsure 🔍 +0% - +0% (+0.00ms - +0.00ms)
    preact-local vs preact-main
  • todo: unsure 🔍 -4% - +0% (-0.04ms - +0.00ms)
    preact-local vs preact-main
  • update10th1k: unsure 🔍 -1% - +1% (-0.02ms - +0.03ms)
    preact-local vs preact-main

Results

⏳ Benchmarks are currently running. Results below are out of date.
create10k

duration

VersionAvg timevs preact-localvs preact-main
preact-local919.49ms - 926.01ms-unsure 🔍
-0% - +1%
-3.20ms - +5.42ms
preact-main918.82ms - 924.46msunsure 🔍
-1% - +0%
-5.42ms - +3.20ms
-

usedJSHeapSize

VersionAvg timevs preact-localvs preact-main
preact-local19.17ms - 19.18ms-unsure 🔍
-0% - +0%
-0.00ms - +0.01ms
preact-main19.17ms - 19.18msunsure 🔍
-0% - +0%
-0.01ms - +0.00ms
-
filter-list

duration

VersionAvg timevs preact-localvs preact-main
preact-local16.56ms - 16.60ms-unsure 🔍
-0% - +0%
-0.02ms - +0.05ms
preact-main16.54ms - 16.59msunsure 🔍
-0% - +0%
-0.05ms - +0.02ms
-

usedJSHeapSize

VersionAvg timevs preact-localvs preact-main
preact-local1.50ms - 1.52ms-unsure 🔍
-1% - +1%
-0.01ms - +0.01ms
preact-main1.50ms - 1.52msunsure 🔍
-1% - +1%
-0.01ms - +0.01ms
-
hydrate1k

duration

VersionAvg timevs preact-localvs preact-main
preact-local75.87ms - 77.11ms-unsure 🔍
-1% - +1%
-0.82ms - +0.90ms
preact-main75.86ms - 77.05msunsure 🔍
-1% - +1%
-0.90ms - +0.82ms
-

usedJSHeapSize

VersionAvg timevs preact-localvs preact-main
preact-local9.77ms - 10.32ms-unsure 🔍
-1% - +7%
-0.10ms - +0.65ms
preact-main9.51ms - 10.03msunsure 🔍
-6% - +1%
-0.65ms - +0.10ms
-
many-updates

duration

VersionAvg timevs preact-localvs preact-main
preact-local16.76ms - 17.11ms-unsure 🔍
-4% - +1%
-0.62ms - +0.10ms
preact-main16.89ms - 17.51msunsure 🔍
-1% - +4%
-0.10ms - +0.62ms
-

usedJSHeapSize

VersionAvg timevs preact-localvs preact-main
preact-local3.75ms - 3.75ms-unsure 🔍
-0% - +0%
-0.00ms - +0.00ms
preact-main3.75ms - 3.75msunsure 🔍
-0% - +0%
-0.00ms - +0.00ms
-
replace1k
  • Browser: chrome-headless
  • Sample size: 100
  • Built by: CI #4328
  • Commit: 7e5854e

duration

VersionAvg timevs preact-localvs preact-main
preact-local67.39ms - 68.96ms-unsure 🔍
-2% - +1%
-1.45ms - +0.69ms
preact-main67.83ms - 69.28msunsure 🔍
-1% - +2%
-0.69ms - +1.45ms
-

usedJSHeapSize

VersionAvg timevs preact-localvs preact-main
preact-local2.96ms - 2.97ms-unsure 🔍
-1% - +0%
-0.02ms - +0.01ms
preact-main2.96ms - 2.98msunsure 🔍
-0% - +1%
-0.01ms - +0.02ms
-

run-warmup-0

VersionAvg timevs preact-localvs preact-main
preact-local29.99ms - 30.56ms-unsure 🔍
-1% - +2%
-0.33ms - +0.50ms
preact-main29.89ms - 30.49msunsure 🔍
-2% - +1%
-0.50ms - +0.33ms
-

run-warmup-1

VersionAvg timevs preact-localvs preact-main
preact-local33.91ms - 34.66ms-unsure 🔍
-1% - +2%
-0.43ms - +0.69ms
preact-main33.73ms - 34.57msunsure 🔍
-2% - +1%
-0.69ms - +0.43ms
-

run-warmup-2

VersionAvg timevs preact-localvs preact-main
preact-local26.20ms - 26.53ms-unsure 🔍
-1% - +1%
-0.18ms - +0.29ms
preact-main26.15ms - 26.47msunsure 🔍
-1% - +1%
-0.29ms - +0.18ms
-

run-warmup-3

VersionAvg timevs preact-localvs preact-main
preact-local27.29ms - 28.69ms-unsure 🔍
-2% - +5%
-0.49ms - +1.31ms
preact-main27.01ms - 28.15msunsure 🔍
-5% - +2%
-1.31ms - +0.49ms
-

run-warmup-4

VersionAvg timevs preact-localvs preact-main
preact-local24.98ms - 26.46ms-unsure 🔍
-5% - +3%
-1.35ms - +0.69ms
preact-main25.34ms - 26.76msunsure 🔍
-3% - +5%
-0.69ms - +1.35ms
-

run-final

VersionAvg timevs preact-localvs preact-main
preact-local20.84ms - 21.29ms-unsure 🔍
-2% - +1%
-0.46ms - +0.14ms
preact-main21.03ms - 21.43msunsure 🔍
-1% - +2%
-0.14ms - +0.46ms
-
text-update
  • Browser: chrome-headless
  • Sample size: 230
  • Built by: CI #4328
  • Commit: 7e5854e

duration

VersionAvg timevs preact-localvs preact-main
preact-local2.07ms - 2.16ms-unsure 🔍
-5% - +1%
-0.10ms - +0.02ms
preact-main2.11ms - 2.19msunsure 🔍
-1% - +5%
-0.02ms - +0.10ms
-

usedJSHeapSize

VersionAvg timevs preact-localvs preact-main
preact-local1.11ms - 1.11ms-unsure 🔍
+0% - +0%
+0.00ms - +0.00ms
preact-main1.11ms - 1.11msunsure 🔍
-0% - -0%
-0.00ms - -0.00ms
-
todo

duration

VersionAvg timevs preact-localvs preact-main
preact-local34.34ms - 34.88ms-unsure 🔍
-1% - +2%
-0.42ms - +0.62ms
preact-main34.07ms - 34.95msunsure 🔍
-2% - +1%
-0.62ms - +0.42ms
-

usedJSHeapSize

VersionAvg timevs preact-localvs preact-main
preact-local1.22ms - 1.24ms-unsure 🔍
-4% - +0%
-0.04ms - +0.00ms
preact-main1.23ms - 1.27msunsure 🔍
-0% - +4%
-0.00ms - +0.04ms
-
update10th1k

duration

VersionAvg timevs preact-localvs preact-main
preact-local30.67ms - 32.42ms-unsure 🔍
-3% - +5%
-1.00ms - +1.51ms
preact-main30.40ms - 32.19msunsure 🔍
-5% - +3%
-1.51ms - +1.00ms
-

usedJSHeapSize

VersionAvg timevs preact-localvs preact-main
preact-local2.93ms - 2.97ms-unsure 🔍
-1% - +1%
-0.02ms - +0.03ms
preact-main2.93ms - 2.96msunsure 🔍
-1% - +1%
-0.03ms - +0.02ms
-

tachometer-reporter-action v2 for CI

Copy link

github-actions bot commented Feb 12, 2025

Size Change: -241 B (-0.4%)

Total Size: 60.3 kB

Filename Size Change
compat/dist/compat.js 3.67 kB -79 B (-2.11%)
compat/dist/compat.module.js 3.59 kB -82 B (-2.23%)
compat/dist/compat.umd.js 3.73 kB -80 B (-2.1%)
ℹ️ View Unchanged
Filename Size
debug/dist/debug.js 3.87 kB
debug/dist/debug.module.js 3.87 kB
debug/dist/debug.umd.js 3.95 kB
devtools/dist/devtools.js 260 B
devtools/dist/devtools.module.js 274 B
devtools/dist/devtools.umd.js 346 B
dist/preact.js 4.56 kB
dist/preact.min.js 4.6 kB
dist/preact.min.module.js 4.59 kB
dist/preact.min.umd.js 4.63 kB
dist/preact.module.js 4.59 kB
dist/preact.umd.js 4.65 kB
hooks/dist/hooks.js 1.54 kB
hooks/dist/hooks.module.js 1.57 kB
hooks/dist/hooks.umd.js 1.61 kB
jsx-runtime/dist/jsxRuntime.js 957 B
jsx-runtime/dist/jsxRuntime.module.js 926 B
jsx-runtime/dist/jsxRuntime.umd.js 1.03 kB
test-utils/dist/testUtils.js 473 B
test-utils/dist/testUtils.module.js 477 B
test-utils/dist/testUtils.umd.js 555 B

compressed-size-action

@JoviDeCroock JoviDeCroock force-pushed the size-impact-deprecated-comp-lifecycles branch from debe7f2 to 7e5854e Compare February 12, 2025 08:59
@JoviDeCroock JoviDeCroock merged commit 4e74070 into v11-2 Feb 13, 2025
2 of 3 checks passed
@JoviDeCroock JoviDeCroock deleted the size-impact-deprecated-comp-lifecycles branch February 13, 2025 16:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants