Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Bump puppeteer #557

Merged
merged 2 commits into from
Oct 13, 2024
Merged

chore: Bump puppeteer #557

merged 2 commits into from
Oct 13, 2024

Conversation

rschristian
Copy link
Member

@rschristian rschristian commented Oct 13, 2024

Supersedes #554, which I can't reopen after a force push.

Just installing the deps takes 5 minutes on the ecosystem ci thanks to puppeteer, newer versions are supposed to fix that.

Copy link

changeset-bot bot commented Oct 13, 2024

⚠️ No Changeset found

Latest commit: 82621db

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@rschristian
Copy link
Member Author

rschristian commented Oct 13, 2024

Install is now down to 16s. Not terribly sure why this occurs, or why it's seemingly flakey (CI here doesn't seem to have the issue), but the recommendation seems to be to bump off these slightly older versions.

@rschristian rschristian marked this pull request as ready for review October 13, 2024 06:20
@rschristian rschristian merged commit 21b92ac into main Oct 13, 2024
1 check passed
@rschristian rschristian deleted the chore/bump-puppeteer branch October 13, 2024 06:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants