Merge pull request #137 from jviide/fix-type

preactjs · Sep 13, 2022 · 4823f83 · 4823f83
2 parents 627d837 + 4385ea8
commit 4823f83
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 1 deletion.
diff --git a/.changeset/quick-ladybugs-cry.md b/.changeset/quick-ladybugs-cry.md
@@ -0,0 +1,5 @@
+---
+"@preact/signals-core": patch
+---
+
+Fix `.subscribe`'s TypeScript type
diff --git a/packages/core/src/index.ts b/packages/core/src/index.ts
@@ -123,7 +123,7 @@ export class Signal<T = any> {
 		};
 	}
 
-	subscribe(fn: (value: T) => () => void) {
+	subscribe(fn: (value: T) => void): () => void {
 		return effect(() => fn(this.value));
 	}
-Original file line number
+Diff line change
@@ Expand Up / @@ -123,7 +123,7 @@ export class Signal<T = any> { @@
     		};
     	}
-    	subscribe(fn: (value: T) => () => void) {
+    	subscribe(fn: (value: T) => void): () => void {
     		return effect(() => fn(this.value));
     	}
@@ Expand Down @@