Merge pull request #527 from jviide/sub2

refactor: inline Signal.prototype.subscribe implementation

packages/core/src/index.ts

@@ -289,7 +289,14 @@ Signal.prototype._unsubscribe = function (node) {
 Signal.prototype.subscribe = function (fn) {
 	return effect(() => {
 		const value = this.value;
-		untracked(() => fn(value));
+
+		const prevContext = evalContext;
+		evalContext = undefined;
+		try {
+			fn(value);
+		} finally {
+			evalContext = prevContext;
+		}
 	});
 };
 

packages/core/test/signal.test.tsx

@@ -118,6 +118,16 @@ describe("signal", () => {
 			expect(spy).to.be.calledWith(1);
 		});
 
+		it("should run the callback when the signal value changes", () => {
+			const spy = sinon.spy();
+			const a = signal(1);
+
+			a.subscribe(spy);
+
+			a.value = 2;
+			expect(spy).to.be.calledWith(2);
+		});
+
 		it("should unsubscribe from a signal", () => {
 			const spy = sinon.spy();
 			const a = signal(1);