Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: remove unnecessary try...finally #516

Closed

Conversation

OnlyWick
Copy link

@OnlyWick OnlyWick commented Mar 6, 2024

there are no operations in the notify method that could cause program interruption.

Copy link

changeset-bot bot commented Mar 6, 2024

⚠️ No Changeset found

Latest commit: b406a0b

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Copy link

netlify bot commented Mar 6, 2024

Deploy Preview for preact-signals-demo ready!

Name Link
🔨 Latest commit b406a0b
🔍 Latest deploy log https://app.netlify.com/sites/preact-signals-demo/deploys/65e84f149d78e80008b729bd
😎 Deploy Preview https://deploy-preview-516--preact-signals-demo.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@developit
Copy link
Member

developit commented Mar 11, 2024

I don't think we can remove this try/catch: without it, a custom ._notify implementation throwing would cause the graph to become incorrect, which would break all signals+computeds in very unexpected ways.

@OnlyWick OnlyWick closed this Mar 12, 2024
@OnlyWick
Copy link
Author

Will it happen when used together with other frameworks? I see in the core that _notify does not throw any errors.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants