fix: Ensure that text effects get disposed #647
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for preact-signals-demo ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
jviide
force-pushed
the
dispose-text-effects
branch
from
dae6f51 to
e2ab081
Compare
🦋 Changeset detectedLatest commit: e3c4a26 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
jviide
force-pushed
the
dispose-text-effects
branch
from
e2ab081 to
8438477
Compare
JoviDeCroock
approved these changes
Jan 12, 2025
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request fixes a case in the Preact bindings where effects created for optimized text updates didn't get disposed. This in turn could cause intermediate computeds to never get garbage collected as long as their dependencies didn't get garbage collected.
There's a new test for this scenario. The test passes after applying this PR.
There is also an additional modification to mangle.json: The
pure_effectsoption is now set tofalse, because.valueaccesses for signals are not pure. This caused the minifier to remove and reorder important.valueaccesses in a way that internal effects weren't always depending on them properly, causing the production tests to fail.