-
-
Notifications
You must be signed in to change notification settings - Fork 108
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
support route parameters and inject them into the component #354
Conversation
🦋 Changeset detectedLatest commit: ff6c16c The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Size Change: +322 B (0%) Total Size: 688 kB
ℹ️ View Unchanged
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Left a few comments, let me.know what you think 👍
Co-authored-by: Marvin Hagemeister <hello@marvinh.dev>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is great! 🙌
Co-authored-by: Jason Miller <developit@users.noreply.github.com>
Valuable discussion: #300
Resolves: #298
Ideally we'd put this onto context but given our system allowing for multiple matched routes it seems safer to inject these props into the page.
An alternative solution would be to wrap the rendered routes in a context (on the Router side) and have a new useRoute hook.