Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bugfix:router hydration duplication #364

Merged
merged 3 commits into from
Feb 23, 2021

Conversation

developit
Copy link
Member

The router flicker fix from #358 and #337 didn't account for hydration, and was resulting in lazy() components being deopted out of hydration and their contents duplicated. This fixes that issue by only applying the VNode reorder workaround to client-side route transitions.

@changeset-bot
Copy link

changeset-bot bot commented Feb 23, 2021

🦋 Changeset detected

Latest commit: c4118d6

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
preact-iso Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@github-actions
Copy link
Contributor

github-actions bot commented Feb 23, 2021

Size Change: -71 B (0%)

Total Size: 689 kB

Filename Size Change
packages/wmr/demo/dist/chunks/class-fields.********.js 200 B -1 B (0%)
packages/wmr/demo/dist/chunks/compat.********.js 15.3 kB -1 B (0%)
packages/wmr/demo/dist/chunks/index.********.js 199 B -104 B (-34%) 🎉
packages/wmr/demo/dist/chunks/prerender.********.js 2.45 kB -1 B (0%)
packages/wmr/demo/dist/compat/index.html 1.42 kB -2 B (0%)
packages/wmr/demo/dist/env/index.html 713 B +1 B (0%)
packages/wmr/demo/dist/files/index.html 675 B -1 B (0%)
packages/wmr/demo/dist/index.********.js 7.07 kB +39 B (+1%)
packages/wmr/demo/dist/lazy-and-late/index.html 657 B -1 B (0%)
ℹ️ View Unchanged
Filename Size Change
packages/wmr/demo/dist/about/index.html 657 B 0 B
packages/wmr/demo/dist/assets/Calendar.********.css 702 B 0 B
packages/wmr/demo/dist/assets/style.********.css 386 B 0 B
packages/wmr/demo/dist/class-fields/index.html 635 B 0 B
packages/wmr/demo/dist/error/index.html 646 B 0 B
packages/wmr/demo/dist/index.html 703 B 0 B
packages/wmr/wmr.cjs 656 kB 0 B

compressed-size-action

Copy link
Member

@cristianbote cristianbote left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch 🙂

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants