-
-
Notifications
You must be signed in to change notification settings - Fork 109
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bugfix:router hydration duplication #364
Conversation
🦋 Changeset detectedLatest commit: c4118d6 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Size Change: -71 B (0%) Total Size: 689 kB
ℹ️ View Unchanged
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good catch 🙂
The router flicker fix from #358 and #337 didn't account for hydration, and was resulting in
lazy()
components being deopted out of hydration and their contents duplicated. This fixes that issue by only applying the VNode reorder workaround to client-side route transitions.