Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

preact-iso: Fix hydrate parent definition #368

Merged
merged 2 commits into from
Feb 23, 2021

Conversation

piotr-cz
Copy link
Contributor

This fixes parent argument definition to be compatible with preact.render and preact.hydrate which are called under the hood:

Use case:

// Argument of type 'HTMLElement' is not assignable to parameter of type 'VNode<{}>'.
hydrate(<App />, document.body)

@changeset-bot
Copy link

changeset-bot bot commented Feb 23, 2021

🦋 Changeset detected

Latest commit: 977ebb0

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
preact-iso Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link
Member

@JoviDeCroock JoviDeCroock left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome! Thank you

@JoviDeCroock JoviDeCroock merged commit ee75298 into preactjs:main Feb 23, 2021
@github-actions github-actions bot mentioned this pull request Feb 23, 2021
@piotr-cz piotr-cz deleted the bugfix/hydrate-parent-definition branch February 23, 2021 12:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants