Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[preact-iso] Support manual URL via <LocationProvider url="/" /> #534

Merged
merged 2 commits into from
Apr 11, 2021

Conversation

developit
Copy link
Member

@changeset-bot
Copy link

changeset-bot bot commented Apr 9, 2021

🦋 Changeset detected

Latest commit: ad9e1e6

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
preact-iso Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@codepunkt
Copy link
Contributor

codepunkt commented Apr 9, 2021

  1. Type addition for router.d.ts:

    interface LocationProviderProps {
        url?: string
    }
    
    export const LocationProvider: FunctionComponent<LocationProviderProps>;
  2. useMemo and UPDATE also use global location. This is where usage without location available would error next.

@JoviDeCroock JoviDeCroock merged commit 8d5d1d8 into main Apr 11, 2021
@JoviDeCroock JoviDeCroock deleted the preact-iso-manual-url-prop branch April 11, 2021 14:35
@github-actions github-actions bot mentioned this pull request Apr 11, 2021
@codepunkt
Copy link
Contributor

@JoviDeCroock but it doesn't help? Confused why this was merged. 🤔

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants