-
-
Notifications
You must be signed in to change notification settings - Fork 109
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refactor/shared tooling #665
Conversation
🦋 Changeset detectedLatest commit: 62840d8 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
"lint-staged": { | ||
"packages/**/{src,test}/**/*.js": [ | ||
"packages/**/*.{js,ts}": [ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I did have to run npm rebuild
/ npm rebuild --update-binary
in order to make Husky play nice. Lint staged kept strangely erroring out otherwise.
Size Change: 0 B Total Size: 5.95 kB ℹ️ View Unchanged
|
Stems from #664, an issue that ESLint would've caught had it been set up.
packages/wmr
. It's all duplicated at the package root. We don't need it.preact-iso
.ts
files in pre-commit hook so no more needing to runprettier
manually on them