Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor/shared tooling #665

Merged
merged 7 commits into from
Jun 4, 2021
Merged

Refactor/shared tooling #665

merged 7 commits into from
Jun 4, 2021

Conversation

rschristian
Copy link
Member

@rschristian rschristian commented Jun 4, 2021

Stems from #664, an issue that ESLint would've caught had it been set up.

  • Removes ESLint, Husky, and Prettier config from packages/wmr. It's all duplicated at the package root. We don't need it.
  • Updates workflows
  • Fixes low-hanging linting issues in preact-iso
  • Includes .ts files in pre-commit hook so no more needing to run prettier manually on them

@changeset-bot
Copy link

changeset-bot bot commented Jun 4, 2021

🦋 Changeset detected

Latest commit: 62840d8

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
preact-iso Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Comment on lines 69 to +70
"lint-staged": {
"packages/**/{src,test}/**/*.js": [
"packages/**/*.{js,ts}": [
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I did have to run npm rebuild / npm rebuild --update-binary in order to make Husky play nice. Lint staged kept strangely erroring out otherwise.

@github-actions
Copy link
Contributor

github-actions bot commented Jun 4, 2021

Size Change: 0 B

Total Size: 5.95 kB

ℹ️ View Unchanged
Filename Size Change
packages/preact-iso/.dist/index.********.js 1.58 kB 0 B
packages/preact-iso/.dist/prerender.********.js 344 B 0 B
packages/preact-iso/hydrate.js 290 B 0 B
packages/preact-iso/index.js 195 B 0 B
packages/preact-iso/lazy.js 594 B 0 B
packages/preact-iso/prerender.js 629 B 0 B
packages/preact-iso/router.js 2.32 kB 0 B

compressed-size-action

@marvinhagemeister marvinhagemeister merged commit 58340f1 into main Jun 4, 2021
@marvinhagemeister marvinhagemeister deleted the refactor/shared-tooling branch June 4, 2021 08:30
This was referenced Jun 4, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants