fix appnexus segment field format (#6013)

prebid · Nov 21, 2020 · 022bcea · 022bcea
1 parent e5e899d
commit 022bcea
Show file tree

Hide file tree

Showing 2 changed files with 14 additions and 15 deletions.
diff --git a/modules/haloRtdProvider.js b/modules/haloRtdProvider.js
@@ -33,9 +33,8 @@ const segmentMappers = {
     set(bid, 'params.user.segments', []);
     let appnexusSegments = [];
     segments.forEach(segment => {
-      if (typeof segment.value != 'undefined' && segment.value != null) {
-        let appnexusSegment = {'id': segment.id, 'value': segment.value};
-        appnexusSegments.push(appnexusSegment);
+      if (typeof segment.id != 'undefined' && segment.id != null) {
+        appnexusSegments.push(parseInt(segment.id));
       }
     })
     bid.params.user.segments = bid.params.user.segments.concat(appnexusSegments);

diff --git a/test/spec/modules/haloRtdProvider_spec.js b/test/spec/modules/haloRtdProvider_spec.js
@@ -34,7 +34,7 @@ describe('haloRtdProvider', function() {
                       id: 'appnexus',
                       segment: [
                         {
-                          id: 'apnseg0'
+                          id: '0'
                         }
                       ]
                     }
@@ -43,7 +43,7 @@ describe('haloRtdProvider', function() {
               },
               params: {
                 user: {
-                  segments: [{'id': 'apnseg0', 'value': 0}]
+                  segments: [0]
                 }
               }
             }
@@ -82,22 +82,22 @@ describe('haloRtdProvider', function() {
       ];
 
       const data = {
-        appnexus: [{id: 'apnseg1', value: 0}, {id: 'apnseg2', value: 2}, {id: 'apnseg3'}],
+        appnexus: [{id: '1'}, {id: '2'}, {id: '3'}],
         generic: [{id: 'seg1'}, {id: 'seg2'}, {id: 'seg3'}]
       };
 
     	addSegmentData(adUnits, data, config);
 
-      expect(adUnits[0].bids[0].fpd.user.data[0].segment[0]).to.have.deep.property('id', 'apnseg0');
-      expect(adUnits[0].bids[0].fpd.user.data[0].segment[1]).to.have.deep.property('id', 'apnseg1');
-      expect(adUnits[0].bids[0].fpd.user.data[0].segment[2]).to.have.deep.property('id', 'apnseg2');
-      expect(adUnits[0].bids[0].fpd.user.data[0].segment[3]).to.have.deep.property('id', 'apnseg3');
-      expect(adUnits[0].bids[0].params.user).to.have.deep.property('segments', [{'id': 'apnseg0', 'value': 0}, {'id': 'apnseg1', 'value': 0}, {'id': 'apnseg2', 'value': 2}]);
+      expect(adUnits[0].bids[0].fpd.user.data[0].segment[0]).to.have.deep.property('id', '0');
+      expect(adUnits[0].bids[0].fpd.user.data[0].segment[1]).to.have.deep.property('id', '1');
+      expect(adUnits[0].bids[0].fpd.user.data[0].segment[2]).to.have.deep.property('id', '2');
+      expect(adUnits[0].bids[0].fpd.user.data[0].segment[3]).to.have.deep.property('id', '3');
+      expect(adUnits[0].bids[0].params.user).to.have.deep.property('segments', [0, 1, 2, 3]);
 
-      expect(adUnits[1].bids[0].fpd.user.data[0].segment[0]).to.have.deep.property('id', 'apnseg1');
-      expect(adUnits[1].bids[0].fpd.user.data[0].segment[1]).to.have.deep.property('id', 'apnseg2');
-      expect(adUnits[1].bids[0].fpd.user.data[0].segment[2]).to.have.deep.property('id', 'apnseg3');
-      expect(adUnits[1].bids[0].params.user).to.have.deep.property('segments', [{'id': 'apnseg1', 'value': 0}, {'id': 'apnseg2', 'value': 2}]);
+      expect(adUnits[1].bids[0].fpd.user.data[0].segment[0]).to.have.deep.property('id', '1');
+      expect(adUnits[1].bids[0].fpd.user.data[0].segment[1]).to.have.deep.property('id', '2');
+      expect(adUnits[1].bids[0].fpd.user.data[0].segment[2]).to.have.deep.property('id', '3');
+      expect(adUnits[1].bids[0].params.user).to.have.deep.property('segments', [1, 2, 3]);
 
       expect(adUnits[1].bids[1].fpd.user.data[0].segment[0]).to.have.deep.property('id', 'seg1');
       expect(adUnits[1].bids[1].fpd.user.data[0].segment[1]).to.have.deep.property('id', 'seg2');