Skip to content

Commit

Permalink
Feature/remove on set targeting (#3919)
Browse files Browse the repository at this point in the history
* initial orbidder version in personal github repo

* use adUnits from orbidder_example.html

* replace obsolete functions

* forgot to commit the test

* check if bidderRequest object is available

* try to fix weird safari/ie issue

* ebayK: add more params

* update orbidderBidAdapter.md

* use spec.<function> instead of this.<function> for consistency reasons

* add bidfloor parameter to params object

* fix gdpr object handling

* default to consentRequired: false when not explicitly given

* wip - use onSetTargeting callback

* add tests for onSetTargeting callback

* fix params and respective tests

* Remove onSetTargeting
  • Loading branch information
ujuettner authored and jsnellbaker committed Jun 18, 2019
1 parent 842cc19 commit 1c1035a
Show file tree
Hide file tree
Showing 2 changed files with 0 additions and 10 deletions.
4 changes: 0 additions & 4 deletions modules/orbidderBidAdapter.js
Original file line number Diff line number Diff line change
Expand Up @@ -74,10 +74,6 @@ export const spec = {
this.onHandler(bid, '/win');
},

onSetTargeting (bid) {
this.onHandler(bid, '/targeting');
},

onHandler (bid, route) {
const getRefererInfo = detectReferer(window);

Expand Down
6 changes: 0 additions & 6 deletions test/spec/modules/orbidderBidAdapter_spec.js
Original file line number Diff line number Diff line change
Expand Up @@ -178,12 +178,6 @@ describe('orbidderBidAdapter', () => {
expect(ajaxStub.firstCall.args[0].indexOf('https://')).to.equal(0);
expect(ajaxStub.firstCall.args[0]).to.equal(`${spec.orbidderHost}/win`);
expect(ajaxStub.firstCall.args[1]).to.equal(JSON.stringify(bidObjClone));

spec.onSetTargeting(bidObj);
expect(ajaxStub.calledTwice).to.equal(true);
expect(ajaxStub.secondCall.args[0].indexOf('https://')).to.equal(0);
expect(ajaxStub.secondCall.args[0]).to.equal(`${spec.orbidderHost}/targeting`);
expect(ajaxStub.secondCall.args[1]).to.equal(JSON.stringify(bidObjClone));
});
});

Expand Down

0 comments on commit 1c1035a

Please sign in to comment.