Skip to content

Commit

Permalink
Various files: fix LGTM trailing semi-colon (#8811)
Browse files Browse the repository at this point in the history
* akamaiDapRtdProvider: fix LGTM trailing semi-colon

* newspassidBidAdapter: fix LGTM trailing semi-colon

* native: fix LGTM trailing semi-colon

* kueezBidAdapter: fix LGTM trailing semi-colon

* shinezBidAdapter: fix LGTM trailing semi-colon

* openxOrtbBidAdapter: fix LGTM trailing semi-colon

* bliinkBidAdapter: fix LGTM trailing semi-colon

* c1xBidAdapter: fix LGTM trailing semi-colon

* improvedigitalBidAdapter: fix LGTM trailing semi-colon

* weboramaRtdProvider: fix LGTM trailing semi-colon

* 1plusXRtdProvider: fix LGTM trailing semi-colon

* byDataAnalyticsAdapter: fix LGTM trailing semi-colon

* index: fix LGTM trailing semi-colon

* userId/index: fix LGTM trailing semi-colon

* taboolaBidAdapter: fix LGTM trailing semi-colon

* mediafuseBidAdapter: fix LGTM trailing semi-colon

* videoheroesBidAdapter: fix LGTM trailing semi-colon

* gulpfile: fix LGTM trailing semi-colon

* criteoBidAdapter: fix LGTM trailing semi-colon

* eplanningBidAdapter: fix LGTM trailing semi-colon

* hadronAnalyticsAdapter: fix LGTM trailing semi-colon

* config: fix LGTM trailing semi-colon

* imuIdSystem: fix LGTM trailing semi-colon

* spotxBidAdapter: fix LGTM trailing semi-colon
  • Loading branch information
caseywhitmire authored Aug 11, 2022
1 parent 9afa2b0 commit 2ee4d3f
Show file tree
Hide file tree
Showing 24 changed files with 56 additions and 56 deletions.
10 changes: 5 additions & 5 deletions gulpfile.js
Original file line number Diff line number Diff line change
Expand Up @@ -246,7 +246,7 @@ function bundle(dev, moduleArr) {
const dependencies = new Set();
[coreFile].concat(moduleFiles).map(name => path.basename(name)).forEach((file) => {
(depGraph[file] || []).forEach((dep) => dependencies.add(helpers.getBuiltPath(dev, dep)));
})
});

const entries = [coreFile].concat(Array.from(dependencies), moduleFiles);

Expand Down Expand Up @@ -449,7 +449,7 @@ gulp.task('build-bundle-verbose', gulp.series(makeWebpackPkg({

// public tasks (dependencies are needed for each task since they can be ran on their own)
gulp.task('test-only', test);
gulp.task('test-all-features-disabled', testTaskMaker({disableFeatures: require('./features.json'), oneBrowser: 'chrome', watch: false}))
gulp.task('test-all-features-disabled', testTaskMaker({disableFeatures: require('./features.json'), oneBrowser: 'chrome', watch: false}));
gulp.task('test', gulp.series(clean, lint, gulp.series('test-all-features-disabled', 'test-only')));

gulp.task('test-coverage', gulp.series(clean, testCoverage));
Expand All @@ -464,12 +464,12 @@ gulp.task('serve', gulp.series(clean, lint, gulp.parallel('build-bundle-dev', wa
gulp.task('serve-fast', gulp.series(clean, gulp.parallel('build-bundle-dev', watchFast)));
gulp.task('serve-prod', gulp.series(clean, gulp.parallel('build-bundle-prod', startLocalServer)));
gulp.task('serve-and-test', gulp.series(clean, gulp.parallel('build-bundle-dev', watchFast, testTaskMaker({watch: true}))));
gulp.task('serve-e2e', gulp.series(clean, 'build-bundle-prod', gulp.parallel(() => startIntegServer(), startLocalServer)))
gulp.task('serve-e2e-dev', gulp.series(clean, 'build-bundle-dev', gulp.parallel(() => startIntegServer(true), startLocalServer)))
gulp.task('serve-e2e', gulp.series(clean, 'build-bundle-prod', gulp.parallel(() => startIntegServer(), startLocalServer)));
gulp.task('serve-e2e-dev', gulp.series(clean, 'build-bundle-dev', gulp.parallel(() => startIntegServer(true), startLocalServer)));

gulp.task('default', gulp.series(clean, 'build-bundle-prod'));

gulp.task('e2e-test-only', () => runWebdriver({file: argv.file}))
gulp.task('e2e-test-only', () => runWebdriver({file: argv.file}));
gulp.task('e2e-test', gulp.series(clean, 'build-bundle-prod', testTaskMaker({e2e: true})));
// other tasks
gulp.task(bundleToStdout);
Expand Down
2 changes: 1 addition & 1 deletion modules/1plusXRtdProvider.js
Original file line number Diff line number Diff line change
Expand Up @@ -138,7 +138,7 @@ export const updateBidderConfig = (bidder, ortb2Updates, bidderConfigs) => {

if (site) {
// Legacy : cf. comment on buildOrtb2Updates first lines
const currentSite = deepAccess(bidderConfigCopy, 'ortb2.site')
const currentSite = deepAccess(bidderConfigCopy, 'ortb2.site');
const updatedSite = mergeDeep(currentSite, site);
deepSetValue(bidderConfigCopy, 'ortb2.site', updatedSite);
}
Expand Down
4 changes: 2 additions & 2 deletions modules/akamaiDapRtdProvider.js
Original file line number Diff line number Diff line change
Expand Up @@ -202,7 +202,7 @@ export const dapUtils = {
dapUtils.dapTokenize(configAsync, config.identity, onDone,
function(token, status, xhr, onDone) {
item.expires_at = now + DAP_DEFAULT_TOKEN_TTL;
let exp = dapUtils.dapExtractExpiryFromToken(token)
let exp = dapUtils.dapExtractExpiryFromToken(token);
if (typeof exp == 'number') {
item.expires_at = exp - 10;
}
Expand Down Expand Up @@ -303,7 +303,7 @@ export const dapUtils = {
dapUtils.dapEncryptedMembership(configAsync, token, onDone,
function(encToken, status, xhr, onDone) {
item.expires_at = now + DAP_DEFAULT_TOKEN_TTL;
let exp = dapUtils.dapExtractExpiryFromToken(encToken)
let exp = dapUtils.dapExtractExpiryFromToken(encToken);
if (typeof exp == 'number') {
item.expires_at = exp - 10;
}
Expand Down
2 changes: 1 addition & 1 deletion modules/bliinkBidAdapter.js
Original file line number Diff line number Diff line change
Expand Up @@ -96,7 +96,7 @@ export function getKeywords() {
* @return {({cpm, netRevenue: boolean, requestId, width: number, currency, ttl: number, creativeId, height: number}&{mediaType: string, vastXml})|null}
*/
export const buildBid = (bidResponse) => {
const mediaType = deepAccess(bidResponse, 'creative.media_type')
const mediaType = deepAccess(bidResponse, 'creative.media_type');
if (!mediaType) return null;

let bid;
Expand Down
2 changes: 1 addition & 1 deletion modules/byDataAnalyticsAdapter.js
Original file line number Diff line number Diff line change
Expand Up @@ -266,7 +266,7 @@ ascAdapter.getVisitorData = function (data = {}) {
}

const { clientId } = initOptions;
var userId = storage.getDataFromLocalStorage('userId')
var userId = storage.getDataFromLocalStorage('userId');
if (!userId) {
userId = generateUid();
storage.setDataInLocalStorage('userId', userId);
Expand Down
2 changes: 1 addition & 1 deletion modules/c1xBidAdapter.js
Original file line number Diff line number Diff line change
Expand Up @@ -78,7 +78,7 @@ export const c1xAdapter = {
url: URL,
data: payloadString,
bids: bidIdTags
})
});
return bidRequest;
},

Expand Down
2 changes: 1 addition & 1 deletion modules/criteoBidAdapter.js
Original file line number Diff line number Diff line change
Expand Up @@ -513,7 +513,7 @@ function buildCdbRequest(context, bidRequests, bidderRequest) {
ext: {
schain: schain
}
}
};
};
request.user = {
ext: bidderRequest.userExt
Expand Down
6 changes: 3 additions & 3 deletions modules/eplanningBidAdapter.js
Original file line number Diff line number Diff line change
Expand Up @@ -38,14 +38,14 @@ export const spec = {
const spaces = getSpaces(bidRequests, urlConfig.ml);
// TODO: do the fallbacks make sense here?
const pageUrl = bidderRequest.refererInfo.page || bidderRequest.refererInfo.topmostLocation;
const domain = bidderRequest.refererInfo.domain || window.location.host
const domain = bidderRequest.refererInfo.domain || window.location.host;
if (urlConfig.t) {
url = 'https://' + urlConfig.isv + '/layers/t_pbjs_2.json';
params = {};
} else {
url = 'https://' + (urlConfig.sv || DEFAULT_SV) + '/pbjs/1/' + urlConfig.ci + '/' + dfpClientId + '/' + domain + '/' + sec;
// TODO: does the fallback make sense here?
const referrerUrl = bidderRequest.refererInfo.ref || bidderRequest.refererInfo.topmostLocation
const referrerUrl = bidderRequest.refererInfo.ref || bidderRequest.refererInfo.topmostLocation;

if (storage.hasLocalStorage()) {
registerViewabilityAllBids(bidRequests);
Expand Down Expand Up @@ -150,7 +150,7 @@ export const spec = {

return syncs;
},
}
};

function getUserAgent() {
return window.navigator.userAgent;
Expand Down
4 changes: 2 additions & 2 deletions modules/hadronAnalyticsAdapter.js
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,7 @@ import {getRefererInfo} from '../src/refererDetection.js';
* hadronAnalyticsAdapter.js - Audigent Hadron Analytics Adapter
*/

const HADRON_ANALYTICS_URL = 'https://analytics.hadron.ad.gt/api/v1/analytics'
const HADRON_ANALYTICS_URL = 'https://analytics.hadron.ad.gt/api/v1/analytics';
const HADRONID_ANALYTICS_VER = 'pbadgt0';
const DEFAULT_PARTNER_ID = 0;
const AU_GVLID = 561;
Expand Down Expand Up @@ -152,7 +152,7 @@ hadronAnalyticsAdapter.enableAnalytics = function(conf = {}) {
}

hadronAnalyticsAdapter.originEnableAnalytics(conf);
}
};

function flush() {
// Don't send anything if no partner id was declared
Expand Down
4 changes: 2 additions & 2 deletions modules/improvedigitalBidAdapter.js
Original file line number Diff line number Diff line change
Expand Up @@ -123,7 +123,7 @@ export const spec = {

if (bidderRequest) {
// GDPR
const gdprConsent = deepAccess(bidderRequest, 'gdprConsent')
const gdprConsent = deepAccess(bidderRequest, 'gdprConsent');
if (gdprConsent) {
if (typeof gdprConsent.gdprApplies === 'boolean') {
deepSetValue(request, 'regs.ext.gdpr', Number(gdprConsent.gdprApplies));
Expand Down Expand Up @@ -508,7 +508,7 @@ const ID_REQUEST = {
const url = deepAccess(bidderRequest, 'refererInfo.page');
if (url) {
site.page = url;
site.domain = bidderRequest.refererInfo.domain
site.domain = bidderRequest.refererInfo.domain;
}
const configSiteSettings = config.getConfig('site') || {};
const fpdSiteSettings = deepAccess(bidderRequest, 'ortb2.site') || {};
Expand Down
2 changes: 1 addition & 1 deletion modules/imuIdSystem.js
Original file line number Diff line number Diff line change
Expand Up @@ -146,7 +146,7 @@ export const imuIdSubmodule = {
}

if (!localData.id) {
return {callback: callImuidApi(apiUrl)}
return {callback: callImuidApi(apiUrl)};
}
if (localData.expired) {
callImuidApi(apiUrl)();
Expand Down
4 changes: 2 additions & 2 deletions modules/kueezBidAdapter.js
Original file line number Diff line number Diff line change
Expand Up @@ -309,7 +309,7 @@ function generateSharedParams(sharedParams, bidderRequest) {
wrapper_type: 'prebidjs',
wrapper_vendor: '$$PREBID_GLOBAL$$',
wrapper_version: '$prebid.version$'
}
};

if (syncEnabled) {
const allowedSyncMethod = getSyncMethod(filterSettings, bidderCode);
Expand Down Expand Up @@ -352,7 +352,7 @@ function generateSharedParams(sharedParams, bidderRequest) {
params.userIds = JSON.stringify(userIds);
}

return params
return params;
}

/**
Expand Down
16 changes: 8 additions & 8 deletions modules/mediafuseBidAdapter.js
Original file line number Diff line number Diff line change
Expand Up @@ -177,15 +177,15 @@ export const spec = {
payload['iab_support'] = {
omidpn: 'Mediafuse',
omidpv: '$prebid.version$'
}
};
}

if (member > 0) {
payload.member_id = member;
}

if (appDeviceObjBid) {
payload.device = appDeviceObj
payload.device = appDeviceObj;
}
if (appIdObjBid) {
payload.app = appIdObj;
Expand Down Expand Up @@ -227,7 +227,7 @@ export const spec = {
}

if (bidderRequest && bidderRequest.uspConsent) {
payload.us_privacy = bidderRequest.uspConsent
payload.us_privacy = bidderRequest.uspConsent;
}

if (bidderRequest && bidderRequest.refererInfo) {
Expand All @@ -237,7 +237,7 @@ export const spec = {
rd_top: bidderRequest.refererInfo.reachedTop,
rd_ifs: bidderRequest.refererInfo.numIframes,
rd_stk: bidderRequest.refererInfo.stack.map((url) => encodeURIComponent(url)).join(',')
}
};
payload.referrer_detection = refererinfo;
}

Expand Down Expand Up @@ -386,7 +386,7 @@ export const spec = {
reloadViewabilityScriptWithCorrectParameters(bid);
}
}
}
};

function isPopulatedArray(arr) {
return !!(isArray(arr) && arr.length > 0);
Expand All @@ -404,7 +404,7 @@ function reloadViewabilityScriptWithCorrectParameters(bid) {
if (viewJsPayload) {
let prebidParams = 'pbjs_adid=' + bid.adId + ';pbjs_auc=' + bid.adUnitCode;

let jsTrackerSrc = getViewabilityScriptUrlFromPayload(viewJsPayload)
let jsTrackerSrc = getViewabilityScriptUrlFromPayload(viewJsPayload);

let newJsTrackerSrc = jsTrackerSrc.replace('dom_id=%native_dom_id%', prebidParams);

Expand Down Expand Up @@ -498,7 +498,7 @@ function formatRequest(payload, bidderRequest) {
if (getParameterByName('apn_test').toUpperCase() === 'TRUE' || config.getConfig('apn_test') === true) {
options.customHeaders = {
'X-Is-Test': 1
}
};
}

if (payload.tags.length > MAX_IMPS_PER_REQUEST) {
Expand Down Expand Up @@ -733,7 +733,7 @@ function bidToTag(bid) {
tag.code = bid.params.invCode;
}
tag.allow_smaller_sizes = bid.params.allowSmallerSizes || false;
tag.use_pmt_rule = bid.params.usePaymentRule || false
tag.use_pmt_rule = bid.params.usePaymentRule || false;
tag.prebid = true;
tag.disable_psa = true;
let bidFloor = getBidFloor(bid);
Expand Down
2 changes: 1 addition & 1 deletion modules/newspassidBidAdapter.js
Original file line number Diff line number Diff line change
Expand Up @@ -66,7 +66,7 @@ export const spec = {
this.loadConfiguredData(bid);
logInfo('isBidRequestValid : ', config.getConfig(), bid);
let adUnitCode = bid.adUnitCode; // adunit[n].code
let err1 = 'VALIDATION FAILED : missing {param} : siteId, placementId and publisherId are REQUIRED'
let err1 = 'VALIDATION FAILED : missing {param} : siteId, placementId and publisherId are REQUIRED';
if (!(bid.params.hasOwnProperty('placementId'))) {
logError(err1.replace('{param}', 'placementId'), adUnitCode);
return false;
Expand Down
6 changes: 3 additions & 3 deletions modules/openxOrtbBidAdapter.js
Original file line number Diff line number Diff line change
Expand Up @@ -157,7 +157,7 @@ function createVideoRequest(bid, bidderRequest) {
method: 'POST',
url: REQUEST_URL,
data: data
}
};
}

function getBaseRequest(bid, bidderRequest) {
Expand Down Expand Up @@ -191,7 +191,7 @@ function getBaseRequest(bid, bidderRequest) {
utils.deepSetValue(req, 'ext.delDomain', bid.params.delDomain);
}
if (bid.params.test) {
req.test = 1
req.test = 1;
}
if (bidderRequest.gdprConsent) {
if (bidderRequest.gdprConsent.gdprApplies !== undefined) {
Expand Down Expand Up @@ -309,7 +309,7 @@ function interpretResponse(resp, req) {
response.meta.paf.content_id = utils.deepAccess(bid, 'ext.paf.content_id');
}

return response
return response;
})];
});

Expand Down
14 changes: 7 additions & 7 deletions modules/prebidServerBidAdapter/index.js
Original file line number Diff line number Diff line change
Expand Up @@ -360,7 +360,7 @@ function _appendSiteAppDevice(request, pageUrl, accountId) {
// ORTB specifies app OR site
if (typeof config.getConfig('app') === 'object') {
request.app = config.getConfig('app');
request.app.publisher = {id: accountId}
request.app.publisher = {id: accountId};
} else {
request.site = {};
if (isPlainObject(config.getConfig('site'))) {
Expand Down Expand Up @@ -531,7 +531,7 @@ Object.assign(ORTB2.prototype, {
if (bid.mediaTypes != null) {
logWarn(`Prebid Server adapter does not (yet) support bidder-specific mediaTypes for the same adUnit. Size mapping configuration will be ignored for adUnit: ${adUnit.code}, bidder: ${bid.bidder}`);
}
})
});

// in case there is a duplicate imp.id, add '-2' suffix to the second imp.id.
// e.g. if there are 2 adUnits (case of twin adUnit codes) with code 'test',
Expand Down Expand Up @@ -599,7 +599,7 @@ Object.assign(ORTB2.prototype, {
}, {});
}
}
const nativeReq = deepAccess(adUnit, 'nativeOrtbRequest')
const nativeReq = deepAccess(adUnit, 'nativeOrtbRequest');
if (FEATURES.NATIVE && nativeReq) {
const defaultRequest = {
// TODO: determine best way to pass these and if we allow defaults
Expand Down Expand Up @@ -727,7 +727,7 @@ Object.assign(ORTB2.prototype, {

if (floor) {
imp.bidfloor = floor.floor;
imp.bidfloorcur = floor.currency
imp.bidfloorcur = floor.currency;
}

if (imp.banner || imp.video || imp.native) {
Expand Down Expand Up @@ -766,11 +766,11 @@ Object.assign(ORTB2.prototype, {
}

// This is no longer overwritten unless name and version explicitly overwritten by extPrebid (mergeDeep)
request.ext.prebid = Object.assign(request.ext.prebid, {channel: {name: 'pbjs', version: $$PREBID_GLOBAL$$.version}})
request.ext.prebid = Object.assign(request.ext.prebid, {channel: {name: 'pbjs', version: $$PREBID_GLOBAL$$.version}});

// set debug flag if in debug mode
if (getConfig('debug')) {
request.ext.prebid = Object.assign(request.ext.prebid, {debug: true})
request.ext.prebid = Object.assign(request.ext.prebid, {debug: true});
}

// s2sConfig video.ext.prebid is passed through openrtb to PBS
Expand Down Expand Up @@ -1010,7 +1010,7 @@ Object.assign(ORTB2.prototype, {
if (isPlainObject(ortb) && Array.isArray(ortb.assets)) {
bidObject.native = {
ortb,
}
};
} else {
logError('prebid server native response contained no assets');
}
Expand Down
4 changes: 2 additions & 2 deletions modules/shinezBidAdapter.js
Original file line number Diff line number Diff line change
Expand Up @@ -382,7 +382,7 @@ function generateGeneralParams(generalObject, bidderRequest) {
ua: navigator.userAgent,
session_id: getBidIdParameter('auctionId', generalObject),
tmax: timeout
}
};

const userIdsParam = getBidIdParameter('userId', generalObject);
if (userIdsParam) {
Expand Down Expand Up @@ -431,5 +431,5 @@ function generateGeneralParams(generalObject, bidderRequest) {
generalParams.page_url = generalParams.page_url || config.getConfig('pageUrl') || deepAccess(window, 'location.href');
}

return generalParams
return generalParams;
}
Loading

0 comments on commit 2ee4d3f

Please sign in to comment.