Set bid response ID to bid request ID for AOL

prebid · Oct 12, 2016 · 38bd3ae · 38bd3ae
1 parent 67c307a
commit 38bd3ae
Show file tree

Hide file tree

Showing 2 changed files with 24 additions and 2 deletions.
diff --git a/src/adapters/aol.js b/src/adapters/aol.js
@@ -60,7 +60,7 @@ var AolAdapter = function AolAdapter() {
   }
 
   function _addErrorBidResponse(bid, response = {}) {
-    var bidResponse = bidfactory.createBid(2);
+    const bidResponse = bidfactory.createBid(2, bid);
     bidResponse.bidderCode = BIDDER_CODE;
     bidResponse.reason = response.nbr;
     bidResponse.raw = response;
@@ -97,7 +97,7 @@ var AolAdapter = function AolAdapter() {
       ad += bidData.ext.pixels;
     }
 
-    var bidResponse = bidfactory.createBid(1);
+    const bidResponse = bidfactory.createBid(1, bid);
     bidResponse.bidderCode = BIDDER_CODE;
     bidResponse.ad = ad;
     bidResponse.cpm = cpm;

diff --git a/test/spec/adapters/aol_spec.js b/test/spec/adapters/aol_spec.js
@@ -244,6 +244,15 @@ describe('AolAdapter', () => {
         expect(bidmanager.addBidResponse.firstCall.args[1]).to.have.property('bidderCode', 'aol');
       });
 
+      it('should have adId matching the bidId from related bid request', () => {
+        server.respondWith(JSON.stringify(DEFAULT_PUBAPI_RESPONSE));
+        adapter.callBids(DEFAULT_BIDDER_REQUEST);
+        server.respond();
+        expect(bidmanager.addBidResponse.calledOnce).to.be.true;
+        expect(bidmanager.addBidResponse.firstCall.args[1])
+          .to.have.property('adId', DEFAULT_BIDDER_REQUEST.bids[0].bidId);
+      });
+
       it('should be added to bidmanager as invalid in case of empty response', () => {
         server.respondWith('');
         adapter.callBids(DEFAULT_BIDDER_REQUEST);
@@ -272,6 +281,19 @@ describe('AolAdapter', () => {
         expect(bidmanager.addBidResponse.firstCall.args[1].getStatusCode()).to.equal(2);
       });
 
+      it('should have adId matching the bidId from bid request in case of no bid data', () => {
+        server.respondWith(JSON.stringify({
+          "id": "245730051428950632",
+          "cur": "USD",
+          "seatbid": []
+        }));
+        adapter.callBids(DEFAULT_BIDDER_REQUEST);
+        server.respond();
+        expect(bidmanager.addBidResponse.calledOnce).to.be.true;
+        expect(bidmanager.addBidResponse.firstCall.args[1])
+          .to.have.property('adId', DEFAULT_BIDDER_REQUEST.bids[0].bidId);
+      });
+
       it('should be added to bidmanager as invalid in case of empty price', () => {
         server.respondWith(JSON.stringify({
           "id": "245730051428950632",