Skip to content

Commit

Permalink
Change protocol to https (#4513)
Browse files Browse the repository at this point in the history
* Outcon bid adapter.

* Fix identation

* Fixes

* Fixes

* Fixes

* Spec fixes

* Fixes

* Fix urls

* Fix

* Fix parameters

* Fix space operators

* Fix bidder timeout

* Update

* Fix whitespace

* no message

* Outcon unit test

* no message

* no message

* no message

* no message

* Fixes

* Fixes

* Change url

* no message

* no message

* no message

* Added bidId

* no message

* no message

* no message

* no message

* Wrapping url with html

* no message

* no message

* no message

* Fix mediaTypes

* no message

* Update outconBidAdapter_spec.js

* Adding VAS response

* no message

* no message

* no message

* Fix

* Changed ttl

* no message

* supportedMediaTypes

* no message

* no message

* Change protocol to https

* no message
  • Loading branch information
TinchoF authored and jsnellbaker committed Dec 3, 2019
1 parent 0925112 commit 3af10ac
Show file tree
Hide file tree
Showing 2 changed files with 7 additions and 10 deletions.
6 changes: 3 additions & 3 deletions modules/outconBidAdapter.js
Original file line number Diff line number Diff line change
Expand Up @@ -18,13 +18,13 @@ export const spec = {
switch (validBidRequests[i].params.env) {
case 'test':
par = par + '&demo=true';
url = 'http://test.outcondigital.com:8048/ad/' + par;
url = 'https://test.outcondigital.com/ad/' + par;
break;
case 'api':
url = 'http://api.outcondigital.com:8048/ad/' + par;
url = 'https://api.outcondigital.com/ad/' + par;
break;
case 'stg':
url = 'http://stg.outcondigital.com:8048/ad/' + par;
url = 'https://stg.outcondigital.com/ad/' + par;
break;
}
return {
Expand Down
11 changes: 4 additions & 7 deletions test/spec/modules/outconBidAdapter_spec.js
Original file line number Diff line number Diff line change
Expand Up @@ -23,7 +23,6 @@ describe('outconBidAdapter', function () {
})).to.equal(true);
});
});

describe('buildRequests', function () {
it('Build requests with pod param', function () {
expect(spec.buildRequests([{
Expand All @@ -34,7 +33,6 @@ describe('outconBidAdapter', function () {
}
}])).to.have.keys('method', 'url', 'data');
});

it('Build requests with internalID and publisherID params', function () {
expect(spec.buildRequests([{
bidder: 'outcon',
Expand All @@ -46,11 +44,10 @@ describe('outconBidAdapter', function () {
}])).to.have.keys('method', 'url', 'data');
});
});

describe('interpretResponse', function () {
const bidRequest = {
method: 'GET',
url: 'http://test.outcondigital.com:8048/ad/',
url: 'https://test.outcondigital.com/ad/',
data: {
pod: '5d603538eba7192ae14e39a4',
env: 'test',
Expand All @@ -64,7 +61,7 @@ describe('outconBidAdapter', function () {
exp: 10,
creatives: [
{
url: 'http://test.outcondigital.com/uploads/5d42e7a7306ea4689b67c122/frutas.mp4',
url: 'https://test.outcondigital.com/uploads/5d42e7a7306ea4689b67c122/frutas.mp4',
size: 3,
width: 1920,
height: 1080,
Expand All @@ -74,8 +71,8 @@ describe('outconBidAdapter', function () {
ad: '5d6e6aef22063e392bf7f564',
type: 'video',
campaign: '5d42e44b306ea469593c76a2',
trackingURL: 'http://test.outcondigital.com:8048/ad/track?track=5d6e6aef22063e392bf7f564',
vastURL: 'http://test.outcondigital.com:8048/outcon.xml?impression=5d6e6aef22063e392bf7f564&demo=true'
trackingURL: 'https://test.outcondigital.com/ad/track?track=5d6e6aef22063e392bf7f564',
vastURL: 'https://test.outcondigital.com/outcon.xml?impression=5d6e6aef22063e392bf7f564&demo=true'
},
};
it('check all the keys that are needed to interpret the response', function () {
Expand Down

0 comments on commit 3af10ac

Please sign in to comment.