Skip to content

Commit

Permalink
Addresses #11628
Browse files Browse the repository at this point in the history
  • Loading branch information
robertrmartinez committed Jun 5, 2024
1 parent 47e6561 commit 3c4bebc
Show file tree
Hide file tree
Showing 2 changed files with 60 additions and 3 deletions.
12 changes: 12 additions & 0 deletions libraries/pbsExtensions/processors/aliases.js
Original file line number Diff line number Diff line change
@@ -1,4 +1,5 @@
import adapterManager from '../../../src/adapterManager.js';
import {config} from '../../../src/config.js';
import {deepSetValue} from '../../../src/utils.js';

export function setRequestExtPrebidAliases(ortbRequest, bidderRequest, context, {am = adapterManager} = {}) {
Expand All @@ -7,11 +8,22 @@ export function setRequestExtPrebidAliases(ortbRequest, bidderRequest, context,
// adding alias only if alias source bidder exists and alias isn't configured to be standalone
// pbs adapter
if (!bidder || !bidder.getSpec().skipPbsAliasing) {
// set alias
deepSetValue(
ortbRequest,
`ext.prebid.aliases.${bidderRequest.bidderCode}`,
am.aliasRegistry[bidderRequest.bidderCode]
);

// set alias gvlids if present also
const gvlId = bidder?.getSpec?.().gvlid || config.getConfig(`gvlMapping.${bidderRequest.bidderCode}`);
if (gvlId) {
deepSetValue(
ortbRequest,
`ext.prebid.aliasgvlids.${bidderRequest.bidderCode}`,
gvlId
);
}
}
}
}
51 changes: 48 additions & 3 deletions test/spec/ortbConverter/pbsExtensions/aliases_spec.js
Original file line number Diff line number Diff line change
@@ -1,4 +1,5 @@
import {setRequestExtPrebidAliases} from '../../../../libraries/pbsExtensions/processors/aliases.js';
import {config} from 'src/config.js';

describe('PBS - ortb ext.prebid.aliases', () => {
let aliasRegistry, bidderRegistry;
Expand All @@ -17,7 +18,11 @@ describe('PBS - ortb ext.prebid.aliases', () => {
beforeEach(() => {
aliasRegistry = {};
bidderRegistry = {};
})
config.resetConfig();
});
afterEach(() => {
config.resetConfig();
});

describe('has no effect if', () => {
it('bidder is not an alias', () => {
Expand All @@ -37,13 +42,16 @@ describe('PBS - ortb ext.prebid.aliases', () => {
});
});

it('sets ext.prebid.aliases.BIDDER', () => {
function initAlias(spec = {}) {
aliasRegistry['alias'] = 'bidder';
bidderRegistry['alias'] = {
getSpec() {
return {}
return spec
}
};
}
it('sets ext.prebid.aliases.BIDDER', () => {
initAlias();
expect(setAliases({bidderCode: 'alias'})).to.eql({
ext: {
prebid: {
Expand All @@ -54,4 +62,41 @@ describe('PBS - ortb ext.prebid.aliases', () => {
}
})
});

it('sets ext.prebid.aliasgvlids.BIDDER if set on spec', () => {
initAlias({ gvlid: 24 });
expect(setAliases({ bidderCode: 'alias' })).to.eql({
ext: {
prebid: {
aliases: {
alias: 'bidder'
},
aliasgvlids: {
alias: 24
}
}
}
})
});

it('sets ext.prebid.aliasgvlids.BIDDER if set on config', () => {
config.setConfig({
gvlMapping: {
alias: 24
}
});
initAlias();
expect(setAliases({ bidderCode: 'alias' })).to.eql({
ext: {
prebid: {
aliases: {
alias: 'bidder'
},
aliasgvlids: {
alias: 24
}
}
}
})
});
})

0 comments on commit 3c4bebc

Please sign in to comment.