Sonobi Adapter - Support UnifiedId/tradedesk from user id module (#3743)

* Sonobi Adapter added support for UnifiedId/tdid * fixed unit test * added semi colons * removed fallback tdid on crumbs
prebid · Apr 19, 2019 · 542b990 · 542b990
1 parent 3e97e59
commit 542b990
Show file tree

Hide file tree

Showing 2 changed files with 28 additions and 11 deletions.
diff --git a/modules/sonobiBidAdapter.js b/modules/sonobiBidAdapter.js
@@ -78,6 +78,10 @@ export const spec = {
       payload.hfa = `PRE-${validBidRequests[0].crumbs.pubcid}`;
     }
 
+    if (deepAccess(validBidRequests[0], 'userId.tdid')) {
+      payload.tdid = validBidRequests[0].userId.tdid;
+    }
+
     if (validBidRequests[0].params.referrer) {
       payload.ref = validBidRequests[0].params.referrer;
     }

diff --git a/test/spec/modules/sonobiBidAdapter_spec.js b/test/spec/modules/sonobiBidAdapter_spec.js
@@ -290,29 +290,42 @@ describe('SonobiBidAdapter', function () {
       delete bidRequest[1].params.hfa;
       bidRequest[0].crumbs = {'pubcid': 'abcd-efg-0101'};
       bidRequest[1].crumbs = {'pubcid': 'abcd-efg-0101'};
-      const bidRequests = spec.buildRequests(bidRequest, bidderRequests)
-      expect(bidRequests.url).to.equal('https://apex.go.sonobi.com/trinity.json')
-      expect(bidRequests.method).to.equal('GET')
-      expect(bidRequests.data.ref).not.to.be.empty
-      expect(bidRequests.data.s).not.to.be.empty
+      const bidRequests = spec.buildRequests(bidRequest, bidderRequests);
+      expect(bidRequests.url).to.equal('https://apex.go.sonobi.com/trinity.json');
+      expect(bidRequests.method).to.equal('GET');
+      expect(bidRequests.data.ref).not.to.be.empty;
+      expect(bidRequests.data.s).not.to.be.empty;
       expect(bidRequests.data.hfa).to.equal('PRE-abcd-efg-0101');
-    })
+    });
 
     it('should return a properly formatted request with commonid from User ID as hfa', function () {
       delete bidRequest[0].params.hfa;
       delete bidRequest[1].params.hfa;
       bidRequest[0].userId = {'pubcid': 'abcd-efg-0101'};
       bidRequest[1].userId = {'pubcid': 'abcd-efg-0101'};
-      const bidRequests = spec.buildRequests(bidRequest, bidderRequests)
-      expect(bidRequests.url).to.equal('https://apex.go.sonobi.com/trinity.json')
-      expect(bidRequests.method).to.equal('GET')
-      expect(bidRequests.data.ref).not.to.be.empty
-      expect(bidRequests.data.s).not.to.be.empty
+      const bidRequests = spec.buildRequests(bidRequest, bidderRequests);
+      expect(bidRequests.url).to.equal('https://apex.go.sonobi.com/trinity.json');
+      expect(bidRequests.method).to.equal('GET');
+      expect(bidRequests.data.ref).not.to.be.empty;
+      expect(bidRequests.data.s).not.to.be.empty;
       expect(bidRequests.data.hfa).to.equal('PRE-abcd-efg-0101');
       delete bidRequest[0].userId;
       delete bidRequest[1].userId;
     })
 
+    it('should return a properly formatted request with unified id from User ID as tdid', function () {
+      delete bidRequest[0].params.tdid;
+      delete bidRequest[1].params.tdid;
+      bidRequest[0].userId = {'tdid': 'td-abcd-efg-0101'};
+      bidRequest[1].userId = {'tdid': 'td-abcd-efg-0101'};
+      const bidRequests = spec.buildRequests(bidRequest, bidderRequests);
+      expect(bidRequests.url).to.equal('https://apex.go.sonobi.com/trinity.json');
+      expect(bidRequests.method).to.equal('GET');
+      expect(bidRequests.data.ref).not.to.be.empty;
+      expect(bidRequests.data.s).not.to.be.empty;
+      expect(bidRequests.data.tdid).to.equal('td-abcd-efg-0101');
+    })
+
     it('should return a properly formatted request with hfa preferred over commonid', function () {
       bidRequest[0].params.hfa = 'hfakey';
       bidRequest[1].params.hfa = 'hfakey';