added display count global object to track number of times requestBid…

…s has been called per ad-unit (#2802)
prebid · Jul 30, 2018 · 54f23fa · 54f23fa
1 parent 3e3ba81
commit 54f23fa
Show file tree

Hide file tree

Showing 4 changed files with 35 additions and 14 deletions.
diff --git a/modules/medianetBidAdapter.js b/modules/medianetBidAdapter.js
@@ -122,7 +122,8 @@ function slotParams(bidRequest) {
   let params = {
     id: bidRequest.bidId,
     ext: {
-      dfp_id: bidRequest.adUnitCode
+      dfp_id: bidRequest.adUnitCode,
+      display_count: bidRequest.displayCount
     },
     banner: transformSizes(bidRequest.sizes),
     all: bidRequest.params

diff --git a/src/adaptermanager.js b/src/adaptermanager.js
@@ -8,11 +8,13 @@ import { ajaxBuilder } from 'src/ajax';
 import { config, RANDOM } from 'src/config';
 import includes from 'core-js/library/fn/array/includes';
 import find from 'core-js/library/fn/array/find';
+import { getGlobal } from './prebidGlobal';
 
 var utils = require('./utils.js');
 var CONSTANTS = require('./constants.json');
 var events = require('./events');
 let s2sTestingModule; // store s2sTesting module if it's loaded
+const $$PREBID_GLOBAL$$ = getGlobal();
 
 var _bidderRegistry = {};
 exports.bidderRegistry = _bidderRegistry;
@@ -95,7 +97,8 @@ function getBids({bidderCode, auctionId, bidderRequestId, adUnits, labels}) {
               sizes: sizes,
               bidId: bid.bid_id || utils.getUniqueIdentifierStr(),
               bidderRequestId,
-              auctionId
+              auctionId,
+              displayCount: $$PREBID_GLOBAL$$.displayCount[adUnit.code]
             }));
           }
           return bids;

diff --git a/src/prebid.js b/src/prebid.js
@@ -47,6 +47,9 @@ utils.logInfo('Prebid.js v$prebid.version$ loaded');
 // create adUnit array
 $$PREBID_GLOBAL$$.adUnits = $$PREBID_GLOBAL$$.adUnits || [];
 
+// store the number of times requestBids has been called per ad Unit
+$$PREBID_GLOBAL$$.displayCount = $$PREBID_GLOBAL$$.displayCount || {};
+
 // Allow publishers who enable user sync override to trigger their sync
 $$PREBID_GLOBAL$$.triggerUserSyncs = triggerUserSyncs;
 
@@ -367,6 +370,8 @@ $$PREBID_GLOBAL$$.requestBids = createHook('asyncSeries', function ({ bidsBackHa
         adUnit.bids = adUnit.bids.filter(bid => bid.bidder !== bidder);
       }
     });
+    // increment the number of times requestBids has been called for this adUnit
+    $$PREBID_GLOBAL$$.displayCount[adUnit.code] = ($$PREBID_GLOBAL$$.displayCount[adUnit.code] + 1) || 1;
   });
 
   if (!adUnits || adUnits.length === 0) {

diff --git a/test/spec/modules/medianetBidAdapter_spec.js b/test/spec/modules/medianetBidAdapter_spec.js
@@ -17,7 +17,8 @@ let VALID_BID_REQUEST = [{
     'sizes': [[300, 250]],
     'bidId': '28f8f8130a583e',
     'bidderRequestId': '1e9b1f07797c1c',
-    'auctionId': 'aafabfd0-28c0-4ac0-aa09-99689e88b81d'
+    'auctionId': 'aafabfd0-28c0-4ac0-aa09-99689e88b81d',
+    'displayCount': 1
   }, {
     'bidder': 'medianet',
     'params': {
@@ -33,7 +34,8 @@ let VALID_BID_REQUEST = [{
     'sizes': [[300, 251]],
     'bidId': '3f97ca71b1e5c2',
     'bidderRequestId': '1e9b1f07797c1c',
-    'auctionId': 'aafabfd0-28c0-4ac0-aa09-99689e88b81d'
+    'auctionId': 'aafabfd0-28c0-4ac0-aa09-99689e88b81d',
+    'displayCount': 1
   }],
   VALID_BID_REQUEST_INVALID_BIDFLOOR = [{
     'bidder': 'medianet',
@@ -51,7 +53,8 @@ let VALID_BID_REQUEST = [{
     'sizes': [[300, 250]],
     'bidId': '28f8f8130a583e',
     'bidderRequestId': '1e9b1f07797c1c',
-    'auctionId': 'aafabfd0-28c0-4ac0-aa09-99689e88b81d'
+    'auctionId': 'aafabfd0-28c0-4ac0-aa09-99689e88b81d',
+    'displayCount': 1
   }, {
     'bidder': 'medianet',
     'params': {
@@ -67,7 +70,8 @@ let VALID_BID_REQUEST = [{
     'sizes': [[300, 251]],
     'bidId': '3f97ca71b1e5c2',
     'bidderRequestId': '1e9b1f07797c1c',
-    'auctionId': 'aafabfd0-28c0-4ac0-aa09-99689e88b81d'
+    'auctionId': 'aafabfd0-28c0-4ac0-aa09-99689e88b81d',
+    'displayCount': 1
   }],
   VALID_AUCTIONDATA = {
     'timeout': config.getConfig('bidderTimeout'),
@@ -103,7 +107,8 @@ let VALID_BID_REQUEST = [{
             x: 100,
             y: 100
           }
-        }
+        },
+        'display_count': 1
       },
       'banner': [{
         'w': 300,
@@ -133,7 +138,8 @@ let VALID_BID_REQUEST = [{
             x: 100,
             y: 100
           }
-        }
+        },
+        'display_count': 1
       },
       'banner': [{
         'w': 300,
@@ -181,7 +187,8 @@ let VALID_BID_REQUEST = [{
             x: 100,
             y: 100
           }
-        }
+        },
+        'display_count': 1
       },
       'banner': [{
         'w': 300,
@@ -210,7 +217,8 @@ let VALID_BID_REQUEST = [{
             x: 100,
             y: 100
           }
-        }
+        },
+        'display_count': 1
       },
       'banner': [{
         'w': 300,
@@ -372,7 +380,8 @@ let VALID_BID_REQUEST = [{
     'sizes': [300, 250],
     'bidId': '28f8f8130a583e',
     'bidderRequestId': '1e9b1f07797c1c',
-    'auctionId': 'aafabfd0-28c0-4ac0-aa09-99689e88b81d'
+    'auctionId': 'aafabfd0-28c0-4ac0-aa09-99689e88b81d',
+    'displayCount': 1
   }, {
     'bidder': 'medianet',
     'params': {
@@ -388,7 +397,8 @@ let VALID_BID_REQUEST = [{
     'sizes': [300, 251],
     'bidId': '3f97ca71b1e5c2',
     'bidderRequestId': '1e9b1f07797c1c',
-    'auctionId': 'aafabfd0-28c0-4ac0-aa09-99689e88b81d'
+    'auctionId': 'aafabfd0-28c0-4ac0-aa09-99689e88b81d',
+    'displayCount': 1
   }],
   VALID_BIDDER_REQUEST_WITH_GDPR = {
     'gdprConsent': {
@@ -429,7 +439,8 @@ let VALID_BID_REQUEST = [{
             x: 100,
             y: 100
           }
-        }
+        },
+        'display_count': 1
       },
       'banner': [{
         'w': 300,
@@ -458,7 +469,8 @@ let VALID_BID_REQUEST = [{
             x: 100,
             y: 100
           }
-        }
+        },
+        'display_count': 1
       },
       'banner': [{
         'w': 300,