Skip to content

Commit

Permalink
Sonobi - Added an extra key to each bid for video support (#2628)
Browse files Browse the repository at this point in the history
* added vp param to trinity request

* added lib_name and lib_v to trinity

* return null from buildRequests if there is no keymakers

* added test case for empty keymaker

* only importing functions we need from utils

* changed window.pbjs.version to use the gulp repalced macro .version$

* fixed issue where isEmpty was being called from old utils var. Changed test port expectations to the original 9876 port

* fixed lint issue

* fixed issue where sonobi getUserSync was throwing an error on timeout

* sonobi support referrer param

* fixed unit test for testing the ref param on bid request

* return null from buildRequests if there is no keymakers

* fixed issue where isEmpty was being called from old utils var. Changed test port expectations to the original 9876 port

* Add gdpr support

* fixed issue where we were no longer exposing the aid in the bidsBackHandler. Added an 'aid' property to each bid.
  • Loading branch information
JonGoSonobi authored and snapwich committed May 29, 2018
1 parent d3cfafa commit 7507e51
Show file tree
Hide file tree
Showing 2 changed files with 5 additions and 2 deletions.
1 change: 1 addition & 0 deletions modules/sonobiBidAdapter.js
Original file line number Diff line number Diff line change
Expand Up @@ -115,6 +115,7 @@ export const spec = {
ad: createCreative(bidResponse.sbi_dc, bid.sbi_aid),
ttl: 500,
creativeId: bid.sbi_crid || bid.sbi_aid,
aid: bid.sbi_aid,
netRevenue: true,
currency: 'USD'
};
Expand Down
6 changes: 4 additions & 2 deletions test/spec/modules/sonobiBidAdapter_spec.js
Original file line number Diff line number Diff line change
Expand Up @@ -271,7 +271,8 @@ describe('SonobiBidAdapter', () => {
'ttl': 500,
'creativeId': '1234abcd',
'netRevenue': true,
'currency': 'USD'
'currency': 'USD',
'aid': '30292e432662bd5f86d90774b944b039'
},
{
'requestId': '30b31c1838de1e',
Expand All @@ -283,7 +284,8 @@ describe('SonobiBidAdapter', () => {
'creativeId': '30292e432662bd5f86d90774b944b038',
'netRevenue': true,
'currency': 'USD',
'dealId': 'dozerkey'
'dealId': 'dozerkey',
'aid': '30292e432662bd5f86d90774b944b038'
}
];

Expand Down

0 comments on commit 7507e51

Please sign in to comment.