use sinon local storage stubs for haloid module (#6619)

prebid · Apr 20, 2021 · 7635599 · 7635599
1 parent 1696773
commit 7635599
Show file tree

Hide file tree

Showing 2 changed files with 16 additions and 1 deletion.
diff --git a/modules/haloIdSystem.js b/modules/haloIdSystem.js
@@ -29,6 +29,10 @@ export const haloIdSubmodule = {
    * @returns {{haloId:Object}}
    */
   decode(value) {
+    let haloId = storage.getDataFromLocalStorage('auHaloId');
+    if (utils.isStr(haloId)) {
+      return {haloId: haloId};
+    }
     return (value && typeof value['haloId'] === 'string') ? { 'haloId': value['haloId'] } : undefined;
   },
   /**

diff --git a/test/spec/modules/haloIdSystem_spec.js b/test/spec/modules/haloIdSystem_spec.js
@@ -4,6 +4,16 @@ import * as utils from 'src/utils.js';
 
 describe('HaloIdSystem', function () {
   describe('getId', function() {
+    let getDataFromLocalStorageStub;
+
+    beforeEach(function() {
+      getDataFromLocalStorageStub = sinon.stub(storage, 'getDataFromLocalStorage');
+    });
+
+    afterEach(function () {
+      getDataFromLocalStorageStub.restore();
+    });
+
     it('gets a haloId', function() {
       const config = {
         params: {}
@@ -21,7 +31,8 @@ describe('HaloIdSystem', function () {
       const config = {
         params: {}
       };
-      storage.setDataInLocalStorage('auHaloId', 'tstCachedHaloId1');
+      getDataFromLocalStorageStub.withArgs('auHaloId').returns('tstCachedHaloId1');
+
       const callbackSpy = sinon.spy();
       const callback = haloIdSubmodule.getId(config).callback;
       callback(callbackSpy);