Add User ID Targeting to googletag.cmd as a fallback when GPT API is …

…not ready (#5925)

* Add User IDs to googletag.cmd

The purpose of this change is to allow the userIdTargeting module to function even when googletag has not been defined yet.

* Fixing indentation errors

Fixing indentation errors thrown by

* Fix 'googletag' is not defined errors

* Added unit test for userIdTargeting fallback

modules/userIdTargeting.js

@@ -20,14 +20,16 @@ export function userIdTargeting(userIds, config) {
 
   if (!SHARE_WITH_GAM) {
     logInfo(MODULE_NAME + ': Not enabled for ' + GAM);
-  }
-
-  if (window.googletag && isFn(window.googletag.pubads) && hasOwn(window.googletag.pubads(), 'setTargeting') && isFn(window.googletag.pubads().setTargeting)) {
+  } else if (window.googletag && isFn(window.googletag.pubads) && hasOwn(window.googletag.pubads(), 'setTargeting') && isFn(window.googletag.pubads().setTargeting)) {
     GAM_API = window.googletag.pubads().setTargeting;
   } else {
-    SHARE_WITH_GAM = false;
-    logInfo(MODULE_NAME + ': Could not find googletag.pubads().setTargeting API. Not adding User Ids in targeting.')
-    return;
+    window.googletag = window.googletag || {};
+    window.googletag.cmd = window.googletag.cmd || [];
+    GAM_API = function (key, value) {
+      window.googletag.cmd.push(function () {
+        window.googletag.pubads().setTargeting(key, value);
+      });
+    };
   }
 
   Object.keys(userIds).forEach(function(key) {

test/spec/modules/shareUserIds_spec.js

@@ -50,6 +50,16 @@ describe('#userIdTargeting', function() {
     pubads.setTargeting('test', ['TEST']);
     config.GAM_KEYS.tdid = '';
     userIdTargeting(userIds, config);
+    expect(pubads.getTargeting('tdid')).to.be.an('array').that.is.empty;
     expect(pubads.getTargeting('test')).to.deep.equal(['TEST']);
   });
+
+  it('User Id Targeting is added to googletag queue when GPT is not ready', function() {
+    let pubads = window.googletag.pubads;
+    delete window.googletag.pubads;
+    userIdTargeting(userIds, config);
+    window.googletag.pubads = pubads;
+    window.googletag.cmd.map(command => command());
+    expect(window.googletag.pubads().getTargeting('TD_ID')).to.deep.equal(['my-tdid']);
+  });
 });