Skip to content

Commit

Permalink
greenbids Analytics Adapter: fix double sampling bug (#11090)
Browse files Browse the repository at this point in the history
* greenbidsAnalyticsAdapter: fix double sampling bug

* greenbidsAnalyticsAdapter bump version
  • Loading branch information
jbogp authored Feb 14, 2024
1 parent 6eeb99e commit 7fbe4e9
Showing 1 changed file with 5 additions and 4 deletions.
9 changes: 5 additions & 4 deletions modules/greenbidsAnalyticsAdapter.js
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@ import {deepClone, generateUUID, logError, logInfo, logWarn} from '../src/utils.

const analyticsType = 'endpoint';

export const ANALYTICS_VERSION = '2.0.0';
export const ANALYTICS_VERSION = '2.1.0';

const ANALYTICS_SERVER = 'https://a.greenbids.ai';

Expand All @@ -33,7 +33,6 @@ export const isSampled = function(greenbidsId, samplingRate) {
return true;
}
const hashInt = parseInt(greenbidsId.slice(-4), 16);

return hashInt < samplingRate * (0xFFFF + 1);
}

Expand All @@ -59,8 +58,6 @@ export const greenbidsAnalyticsAdapter = Object.assign(adapter({ANALYTICS_SERVER
if (typeof analyticsOptions.options.sampling === 'number') {
logWarn('"options.sampling" is deprecated, please use "greenbidsSampling" instead.');
analyticsOptions.options.greenbidsSampling = analyticsOptions.options.sampling;
// Set sampling to null to prevent prebid analytics integrated sampling to happen
analyticsOptions.options.sampling = null;
}

/**
Expand Down Expand Up @@ -228,6 +225,10 @@ greenbidsAnalyticsAdapter.originEnableAnalytics = greenbidsAnalyticsAdapter.enab

greenbidsAnalyticsAdapter.enableAnalytics = function(config) {
this.initConfig(config);
if (typeof config.options.sampling === 'number') {
// Set sampling to 1 to prevent prebid analytics integrated sampling to happen
config.options.sampling = 1;
}
logInfo('loading greenbids analytics');
greenbidsAnalyticsAdapter.originEnableAnalytics(config);
};
Expand Down

0 comments on commit 7fbe4e9

Please sign in to comment.