Skip to content

Commit

Permalink
Prebid 7: Clean up misc halo references (#8468)
Browse files Browse the repository at this point in the history
* Update eids.js

* Update openxBidAdapter.js

* Update ixBidAdapter.js

* Update ucfunnelBidAdapter.js

* Update openxBidAdapter.js

* Update beachfrontBidAdapter.js

* Update beachfrontBidAdapter_spec.js
  • Loading branch information
patmmccann authored May 26, 2022
1 parent f7910d4 commit 823fa5a
Show file tree
Hide file tree
Showing 6 changed files with 10 additions and 16 deletions.
2 changes: 1 addition & 1 deletion modules/beachfrontBidAdapter.js
Original file line number Diff line number Diff line change
Expand Up @@ -31,7 +31,7 @@ export const SUPPORTED_USER_IDS = [
{ key: 'tdid', source: 'adserver.org', rtiPartner: 'TDID', queryParam: 'tdid' },
{ key: 'idl_env', source: 'liveramp.com', rtiPartner: 'idl', queryParam: 'idl' },
{ key: 'uid2.id', source: 'uidapi.com', rtiPartner: 'UID2', queryParam: 'uid2' },
{ key: 'haloId', source: 'audigent.com', atype: 1, queryParam: 'haloid' }
{ key: 'hadronId', source: 'audigent.com', atype: 1, queryParam: 'hadronid' }
];

let appId = '';
Expand Down
2 changes: 1 addition & 1 deletion modules/ixBidAdapter.js
Original file line number Diff line number Diff line change
Expand Up @@ -75,7 +75,7 @@ const SOURCE_RTI_MAPPING = {
'id5-sync.com': '', // ID5 Universal ID, configured as id5Id
'crwdcntrl.net': '', // Lotame Panorama ID, lotamePanoramaId
'epsilon.com': '', // Publisher Link, publinkId
'audigent.com': '', // Halo ID from Audigent, haloId
'audigent.com': '', // Hadron ID from Audigent, hadronId
'pubcid.org': '', // SharedID, pubcid
'trustpid.com': '' // Trustpid
};
Expand Down
2 changes: 1 addition & 1 deletion modules/openxBidAdapter.js
Original file line number Diff line number Diff line change
Expand Up @@ -28,7 +28,7 @@ export const USER_ID_CODE_TO_QUERY_ARG = {
britepoolid: 'britepoolid', // BritePool ID
criteoId: 'criteoid', // CriteoID
fabrickId: 'nuestarid', // Fabrick ID by Nuestar
haloId: 'audigentid', // Halo ID from Audigent
hadronId: 'audigentid', // Hadron ID from Audigent
id5id: 'id5id', // ID5 ID
idl_env: 'lre', // LiveRamp IdentityLink
IDP: 'zeotapid', // zeotapIdPlus ID+
Expand Down
6 changes: 3 additions & 3 deletions modules/ucfunnelBidAdapter.js
Original file line number Diff line number Diff line change
Expand Up @@ -338,9 +338,9 @@ function addUserId(bidData, userId) {
bidData['eids'] = '';
_each(userId, (userIdObjectOrValue, userIdProviderKey) => {
switch (userIdProviderKey) {
case 'haloId':
if (userIdObjectOrValue.haloId) {
bidData[userIdProviderKey + 'haloId'] = userIdObjectOrValue.haloId;
case 'hadronId':
if (userIdObjectOrValue.hadronId) {
bidData[userIdProviderKey + 'hadronId'] = userIdObjectOrValue.hadronId;
}
if (userIdObjectOrValue.auSeg) {
bidData[userIdProviderKey + '_auSeg'] = userIdObjectOrValue.auSeg;
Expand Down
6 changes: 0 additions & 6 deletions modules/userId/eids.js
Original file line number Diff line number Diff line change
Expand Up @@ -181,12 +181,6 @@ export const USER_IDS_CONFIG = {
atype: 1
},

// haloId (deprecated in 7.0, use hadronId)
'haloId': {
source: 'audigent.com',
atype: 1
},

// quantcastId
'quantcastId': {
source: 'quantcast.com',
Expand Down
8 changes: 4 additions & 4 deletions test/spec/modules/beachfrontBidAdapter_spec.js
Original file line number Diff line number Diff line change
Expand Up @@ -322,7 +322,7 @@ describe('BeachfrontAdapter', function () {
tdid: '54017816',
idl_env: '13024996',
uid2: { id: '45843401' },
haloId: { haloId: '60314917', auSeg: ['segment1', 'segment2'] }
hadronId: { hadronId: '60314917', auSeg: ['segment1', 'segment2'] }
};
const bidRequest = bidRequests[0];
bidRequest.mediaTypes = { video: {} };
Expand Down Expand Up @@ -360,7 +360,7 @@ describe('BeachfrontAdapter', function () {
{
source: 'audigent.com',
uids: [{
id: userId.haloId,
id: userId.hadronId,
atype: 1,
}]
}
Expand Down Expand Up @@ -543,7 +543,7 @@ describe('BeachfrontAdapter', function () {
tdid: '54017816',
idl_env: '13024996',
uid2: { id: '45843401' },
haloId: { haloId: '60314917', auSeg: ['segment1', 'segment2'] }
hadronId: { hadronId: '60314917', auSeg: ['segment1', 'segment2'] }
};
const bidRequest = bidRequests[0];
bidRequest.mediaTypes = { banner: {} };
Expand All @@ -553,7 +553,7 @@ describe('BeachfrontAdapter', function () {
expect(data.tdid).to.equal(userId.tdid);
expect(data.idl).to.equal(userId.idl_env);
expect(data.uid2).to.equal(userId.uid2.id);
expect(data.haloid).to.equal(userId.haloId);
expect(data.hadronid).to.equal(userId.hadronId);
});
});

Expand Down

0 comments on commit 823fa5a

Please sign in to comment.