Skip to content

Commit

Permalink
cleanup references to allowAuctionWithoutConsent (#11129)
Browse files Browse the repository at this point in the history
  • Loading branch information
bretg authored Feb 22, 2024
1 parent 6a8f2d5 commit 9485c6b
Show file tree
Hide file tree
Showing 6 changed files with 4 additions and 8 deletions.
3 changes: 1 addition & 2 deletions integrationExamples/gpt/gdpr_hello_world.html
Original file line number Diff line number Diff line change
Expand Up @@ -54,8 +54,7 @@
pbjs.setConfig({
consentManagement: {
cmpApi: 'iab',
timeout: 5000,
allowAuctionWithoutConsent: true
timeout: 5000
},
pubcid: {
enable: false
Expand Down
2 changes: 1 addition & 1 deletion modules/consentManagement.js
Original file line number Diff line number Diff line change
Expand Up @@ -250,7 +250,7 @@ export function resetConsentData() {

/**
* A configuration function that initializes some module variables, as well as add a hook into the requestBids function
* @param {{cmp:string, timeout:number, allowAuctionWithoutConsent:boolean, defaultGdprScope:boolean}} config required; consentManagement module config settings; cmp (string), timeout (int), allowAuctionWithoutConsent (boolean)
* @param {{cmp:string, timeout:number, defaultGdprScope:boolean}} config required; consentManagement module config settings; cmp (string), timeout (int))
*/
export function setConsentConfig(config) {
// if `config.gdpr`, `config.usp` or `config.gpp` exist, assume new config format.
Expand Down
2 changes: 1 addition & 1 deletion modules/consentManagementGpp.js
Original file line number Diff line number Diff line change
Expand Up @@ -455,7 +455,7 @@ export function resetConsentData() {

/**
* A configuration function that initializes some module variables, as well as add a hook into the requestBids function
* @param {{cmp:string, timeout:number, allowAuctionWithoutConsent:boolean, defaultGdprScope:boolean}} config required; consentManagement module config settings; cmp (string), timeout (int), allowAuctionWithoutConsent (boolean)
* @param {{cmp:string, timeout:number, defaultGdprScope:boolean}} config required; consentManagement module config settings; cmp (string), timeout (int))
*/
export function setConsentConfig(config) {
config = config && config.gpp;
Expand Down
2 changes: 1 addition & 1 deletion modules/consentManagementUsp.js
Original file line number Diff line number Diff line change
Expand Up @@ -202,7 +202,7 @@ export function resetConsentData() {

/**
* A configuration function that initializes some module variables, as well as add a hook into the requestBids function
* @param {object} config required; consentManagementUSP module config settings; usp (string), timeout (int), allowAuctionWithoutConsent (boolean)
* @param {object} config required; consentManagementUSP module config settings; usp (string), timeout (int)
*/
export function setConsentConfig(config) {
config = config && config.usp;
Expand Down
1 change: 0 additions & 1 deletion test/pages/consent_mgt_gdpr.html
Original file line number Diff line number Diff line change
Expand Up @@ -150,7 +150,6 @@
consentManagement: {
gdpr: {
cmpApi: 'static',
allowAuctionWithoutConsent: true,
consentData: {
getConsentData: {
'gdprApplies': true,
Expand Down
2 changes: 0 additions & 2 deletions test/spec/modules/gdprEnforcement_spec.js
Original file line number Diff line number Diff line change
Expand Up @@ -37,7 +37,6 @@ describe('gdpr enforcement', function () {
let staticConfig = {
cmpApi: 'static',
timeout: 7500,
allowAuctionWithoutConsent: false,
consentData: {
getTCData: {
'tcString': 'COuqj-POu90rDBcBkBENAZCgAPzAAAPAACiQFwwBAABAA1ADEAbQC4YAYAAgAxAG0A',
Expand Down Expand Up @@ -894,7 +893,6 @@ describe('gdpr enforcement', function () {
setEnforcementConfig({
gdpr: {
cmpApi: 'iab',
allowAuctionWithoutConsent: true,
timeout: 5000
}
});
Expand Down

0 comments on commit 9485c6b

Please sign in to comment.