solve sinon stubbing sessionStorage issue with dependency injection

prebid · Jun 6, 2018 · 9c5ba91 · 9c5ba91
1 parent d48c7c4
commit 9c5ba91
Show file tree

Hide file tree

Showing 2 changed files with 11 additions and 10 deletions.
diff --git a/src/debugging.js b/src/debugging.js
@@ -77,10 +77,10 @@ export function getConfig(debugging) {
 }
 config.getConfig('debugging', ({debugging}) => getConfig(debugging));
 
-export function sessionLoader() {
+export function sessionLoader(storage = window.sessionStorage) {
   let overrides;
   try {
-    overrides = JSON.parse(window.sessionStorage.getItem(OVERRIDE_KEY));
+    overrides = JSON.parse(storage.getItem(OVERRIDE_KEY));
   } catch (e) {
   }
   if (overrides) {

diff --git a/test/spec/debugging_spec.js b/test/spec/debugging_spec.js
@@ -12,14 +12,13 @@ describe('bid overrides', () => {
   });
 
   afterEach(() => {
+    window.sessionStorage.clear();
     sandbox.restore();
   });
 
   describe('initialization', () => {
     beforeEach(() => {
       sandbox.stub(config, 'setConfig');
-      sandbox.stub(window.sessionStorage, 'setItem');
-      sandbox.stub(window.sessionStorage, 'removeItem');
     });
 
     afterEach(() => {
@@ -35,17 +34,19 @@ describe('bid overrides', () => {
     });
 
     it('should happen when configuration found in sessionStorage', () => {
-      sandbox.stub(window.sessionStorage, 'getItem').returns('{"enabled": true}');
-
-      sessionLoader();
+      sessionLoader({
+        getItem: () => ('{"enabled": true}')
+      });
       expect(addBidResponse.hasHook(boundHook)).to.equal(true);
     });
 
     it('should not throw if sessionStorage is inaccessible', () => {
-      sandbox.stub(window.sessionStorage, 'getItem').throws();
-
       expect(() => {
-        sessionLoader();
+        sessionLoader({
+          getItem() {
+            throw new Error('test');
+          }
+        });
       }).not.to.throw();
     });
   });