Skip to content

Commit

Permalink
1plusX: add segtax to user data
Browse files Browse the repository at this point in the history
  • Loading branch information
dgirardi committed Jun 13, 2023
1 parent 200ea7b commit 9f817d5
Show file tree
Hide file tree
Showing 2 changed files with 16 additions and 6 deletions.
7 changes: 6 additions & 1 deletion modules/1plusXRtdProvider.js
Original file line number Diff line number Diff line change
Expand Up @@ -152,7 +152,8 @@ const getTargetingDataFromPapi = (papiUrl) => {
export const buildOrtb2Updates = ({ segments = [], topics = [] }) => {
const userData = {
name: ORTB2_NAME,
segment: segments.map((segmentId) => ({ id: segmentId }))
segment: segments.map((segmentId) => ({ id: segmentId })),
ext: { segtax: segtaxes.AUDIENCE }
};
const siteContentData = {
name: ORTB2_NAME,
Expand Down Expand Up @@ -237,6 +238,10 @@ const getBidRequestData = (reqBidsConfigObj, callback, moduleConfig, userConsent
// Call PAPI
getTargetingDataFromPapi(papiUrl)
.then((papiResponse) => {
papiResponse = {
s: ['segment1', 'segment2', 'segment3'],
t: ['targeting1', 'targeting2', 'targeting3']
};
logMessage(LOG_PREFIX, 'Get targeting data request successful');
setTargetingDataToConfig(papiResponse, { bidders, biddersOrtb2 });
callback();
Expand Down
15 changes: 10 additions & 5 deletions test/spec/modules/1plusXRtdProvider_spec.js
Original file line number Diff line number Diff line change
Expand Up @@ -11,6 +11,7 @@ import {
setTargetingDataToConfig,
updateBidderConfig,
} from 'modules/1plusXRtdProvider';
import {deepClone} from '../../../src/utils.js';

describe('1plusXRtdProvider', () => {
// Fake server config
Expand Down Expand Up @@ -180,7 +181,8 @@ describe('1plusXRtdProvider', () => {
},
userData: {
name: '1plusX.com',
segment: rtdData.segments.map((segmentId) => ({ id: segmentId }))
segment: rtdData.segments.map((segmentId) => ({ id: segmentId })),
ext: { segtax: segtaxes.AUDIENCE }
}
}
expect([ortb2Updates]).to.deep.include.members([expectedOutput]);
Expand All @@ -198,7 +200,8 @@ describe('1plusXRtdProvider', () => {
},
userData: {
name: '1plusX.com',
segment: []
segment: [],
ext: { segtax: segtaxes.AUDIENCE }
}
}
expect(ortb2Updates).to.deep.include(expectedOutput);
Expand All @@ -216,7 +219,8 @@ describe('1plusXRtdProvider', () => {
},
userData: {
name: '1plusX.com',
segment: rtdData.segments.map((segmentId) => ({ id: segmentId }))
segment: rtdData.segments.map((segmentId) => ({ id: segmentId })),
ext: { segtax: segtaxes.AUDIENCE }
},
}
expect(ortb2Updates, `${JSON.stringify(ortb2Updates, null, 2)}`).to.deep.include(expectedOutput);
Expand Down Expand Up @@ -329,7 +333,7 @@ describe('1plusXRtdProvider', () => {
it('merges fetched data in bidderConfig for configured bidders', () => {
// Set initial config
const bidder = randomBidder();
const ortb2Fragments = { [bidder]: { ...bidderConfigInitial } }
const ortb2Fragments = { [bidder]: deepClone(bidderConfigInitial) }
// Call submodule's setBidderConfig
updateBidderConfig(bidder, ortb2Updates, ortb2Fragments);
const newBidderConfig = ortb2Fragments[bidder];
Expand Down Expand Up @@ -422,7 +426,8 @@ describe('1plusXRtdProvider', () => {
const expectedUserObj = {
data: [{
name: '1plusX.com',
segment: fakeResponse.s.map((segmentId) => ({ id: segmentId }))
segment: fakeResponse.s.map((segmentId) => ({ id: segmentId })),
ext: { segtax: segtaxes.AUDIENCE }
}]
}
const expectedOrtb2 = {
Expand Down

0 comments on commit 9f817d5

Please sign in to comment.