consentManagementGpp: fix handling of CMP errors (#10811)

prebid · Dec 20, 2023 · a5c2e06 · a5c2e06
1 parent 0b59d4d
commit a5c2e06
Show file tree

Hide file tree

Showing 2 changed files with 10 additions and 5 deletions.
diff --git a/modules/consentManagementGpp.js b/modules/consentManagementGpp.js
@@ -70,13 +70,18 @@ export class GPPClient {
    *  - a promise to GPP data.
    */
   static init(mkCmp = cmpClient) {
-    if (this.INST == null) {
-      this.INST = this.ping(mkCmp).catch(e => {
-        this.INST = null;
+    let inst = this.INST;
+    if (!inst) {
+      let err;
+      const reset = () => err && (this.INST = null);
+      inst = this.INST = this.ping(mkCmp).catch(e => {
+        err = true;
+        reset();
         throw e;
       });
+      reset();
     }
-    return this.INST.then(([client, pingData]) => [
+    return inst.then(([client, pingData]) => [
       client,
       client.initialized ? client.refresh() : client.init(pingData)
     ]);

diff --git a/test/spec/modules/consentManagementGpp_spec.js b/test/spec/modules/consentManagementGpp_spec.js
@@ -290,7 +290,7 @@ describe('consentManagementGpp', function () {
     });
 
     it('should not re-use errors', (done) => {
-      cmpResult = Promise.reject(new Error());
+      cmpResult = GreedyPromise.reject(new Error());
       GPPClient.init(makeCmp).catch(() => {
         cmpResult = {signalStatus: 'ready'};
         return GPPClient.init(makeCmp).then(([client]) => {