Skip to content

Commit

Permalink
change expire recommendation from 90 to 30 (#11130)
Browse files Browse the repository at this point in the history
Co-authored-by: Anthony Lin <anthony.lin@33across.com>
  • Loading branch information
carlosfelix and Anthony Lin authored Feb 22, 2024
1 parent 11bbd29 commit b2ace9f
Show file tree
Hide file tree
Showing 2 changed files with 4 additions and 4 deletions.
4 changes: 2 additions & 2 deletions modules/33acrossIdSystem.md
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,7 @@ pbjs.setConfig({
storage: {
name: "33acrossId",
type: "html5",
expires: 90,
expires: 30,
refreshInSeconds: 8*3600
},
params: {
Expand All @@ -41,7 +41,7 @@ The following settings are available for the `storage` property in the `userSync
| --- | --- | --- | --- | --- |
| name | Required | String| Name of the cookie or HTML5 local storage where the user ID will be stored | `"33acrossId"` |
| type | Required | String | `"html5"` (preferred) or `"cookie"` | `"html5"` |
| expires | Strongly Recommended | Number | How long (in days) the user ID information will be stored. 33Across recommends `90`. | `90` |
| expires | Strongly Recommended | Number | How long (in days) the user ID information will be stored. 33Across recommends `30`. | `30` |
| refreshInSeconds | Strongly Recommended | Number | The interval (in seconds) for refreshing the user ID. 33Across recommends no more than 8 hours between refreshes. | `8*3600` |

### Params
Expand Down
4 changes: 2 additions & 2 deletions test/spec/modules/33acrossIdSystem_spec.js
Original file line number Diff line number Diff line change
Expand Up @@ -63,7 +63,7 @@ describe('33acrossIdSystem', () => {
},
storage: {
type: 'cookie',
expires: 90
expires: 30
}
});

Expand Down Expand Up @@ -184,7 +184,7 @@ describe('33acrossIdSystem', () => {
},
storage: {
type: 'cookie',
expires: 90
expires: 30
}
});

Expand Down

0 comments on commit b2ace9f

Please sign in to comment.