fix mismatch (#11208)

prebid · Mar 14, 2024 · b8a8031 · b8a8031
1 parent 77254c2
commit b8a8031
Show file tree

Hide file tree

Showing 2 changed files with 54 additions and 8 deletions.
diff --git a/modules/sovrnBidAdapter.js b/modules/sovrnBidAdapter.js
@@ -107,18 +107,11 @@ export const spec = {
         }
         iv = iv || getBidIdParameter('iv', bid.params)
 
-        const floorInfo = (bid.getFloor && typeof bid.getFloor === 'function') ? bid.getFloor({
-          currency: 'USD',
-          mediaType: bid.mediaTypes && bid.mediaTypes.banner ? 'banner' : 'video',
-          size: '*'
-        }) : {}
-        floorInfo.floor = floorInfo.floor || getBidIdParameter('bidfloor', bid.params)
-
         const imp = {
           adunitcode: bid.adUnitCode,
           id: bid.bidId,
           tagid: String(getBidIdParameter('tagid', bid.params)),
-          bidfloor: floorInfo.floor
+          bidfloor: _getBidFloors(bid)
         }
 
         if (deepAccess(bid, 'mediaTypes.banner')) {
@@ -332,4 +325,18 @@ function _buildVideoRequestObj(bid) {
   return videoObj
 }
 
+function _getBidFloors(bid) {
+  const floorInfo = (bid.getFloor && typeof bid.getFloor === 'function') ? bid.getFloor({
+    currency: 'USD',
+    mediaType: bid.mediaTypes && bid.mediaTypes.banner ? 'banner' : 'video',
+    size: '*'
+  }) : {}
+  const floorModuleValue = parseFloat(floorInfo.floor)
+  if (!isNaN(floorModuleValue)) {
+    return floorModuleValue
+  }
+  const paramValue = parseFloat(getBidIdParameter('bidfloor', bid.params))
+  return !isNaN(paramValue) ? paramValue : undefined
+}
+
 registerBidder(spec)
diff --git a/test/spec/modules/sovrnBidAdapter_spec.js b/test/spec/modules/sovrnBidAdapter_spec.js
@@ -530,6 +530,45 @@ describe('sovrnBidAdapter', function() {
 
       expect(impression.bidfloor).to.equal(2.00)
     })
+    it('floor should be undefined if there is no floor from the floor module and params', function() {
+      const floorBid = {
+        ...baseBidRequest
+      }
+      floorBid.params = {
+        tagid: 1234
+      }
+      const request = spec.buildRequests([floorBid], baseBidderRequest)
+      const impression = JSON.parse(request.data).imp[0]
+
+      expect(impression.bidfloor).to.be.undefined
+    })
+    it('floor should be undefined if there is incorrect floor value from the floor module', function() {
+      const floorBid = {
+        ...baseBidRequest,
+        getFloor: () => ({currency: 'USD', floor: 'incorrect_value'}),
+        params: {
+          tagid: 1234
+        }
+      }
+      const request = spec.buildRequests([floorBid], baseBidderRequest)
+      const impression = JSON.parse(request.data).imp[0]
+
+      expect(impression.bidfloor).to.be.undefined
+    })
+    it('floor should be undefined if there is incorrect floor value from the params', function() {
+      const floorBid = {
+        ...baseBidRequest,
+        getFloor: () => ({})
+      }
+      floorBid.params = {
+        tagid: 1234,
+        bidfloor: 'incorrect_value'
+      }
+      const request = spec.buildRequests([floorBid], baseBidderRequest)
+      const impression = JSON.parse(request.data).imp[0]
+
+      expect(impression.bidfloor).to.be.undefined
+    })
     describe('First Party Data', function () {
       it('should provide first party data if provided', function() {
         const ortb2 = {