Skip to content

Commit

Permalink
Gumgum: fix how we send TTD global placement ID (#7310)
Browse files Browse the repository at this point in the history
* Gumgum: ADJS-1064 Fix how we send TTD global placement ID

* updated unit tests

* undo unnecessary changes
  • Loading branch information
lbenmore authored Aug 17, 2021
1 parent 718e164 commit d43427d
Show file tree
Hide file tree
Showing 2 changed files with 3 additions and 4 deletions.
3 changes: 1 addition & 2 deletions modules/gumgumBidAdapter.js
Original file line number Diff line number Diff line change
Expand Up @@ -346,8 +346,7 @@ function buildRequests (validBidRequests, bidderRequest) {
sizes,
url: BID_ENDPOINT,
method: 'GET',
gpid: gpid,
data: Object.assign(data, _getBrowserParams(topWindowUrl), _getDigiTrustQueryParams(userId))
data: Object.assign(data, _getBrowserParams(topWindowUrl), _getDigiTrustQueryParams(userId), { gpid })
})
});
return bids;
Expand Down
4 changes: 2 additions & 2 deletions test/spec/modules/gumgumBidAdapter_spec.js
Original file line number Diff line number Diff line change
Expand Up @@ -192,8 +192,8 @@ describe('gumgumAdapter', function () {
it('should set the global placement id (gpid)', function () {
const req = { ...bidRequests[0], ortb2Imp: { ext: { data: { adserver: { name: 'test', adslot: 123456 } } } } }
const bidRequest = spec.buildRequests([req])[0];
expect(bidRequest).to.have.property('gpid');
expect(bidRequest.gpid).to.equal(123456);
expect(bidRequest.data).to.have.property('gpid');
expect(bidRequest.data.gpid).to.equal(123456);
});

it('should set the bid floor if getFloor module is not present but static bid floor is defined', function () {
Expand Down

0 comments on commit d43427d

Please sign in to comment.