Skip to content

Commit

Permalink
Undertone, Unruly, Concert, Adform: stub support for advertiserDomains (
Browse files Browse the repository at this point in the history
#6727)

* Update eids.js

* Update eids_spec.js

* Update eids.js

* Update pubmaticBidAdapter_spec.js

* Update eids.js

* Update eids_spec.js

* Update conversantBidAdapter_spec.js

* Update rubiconBidAdapter_spec.js

* Update conversantBidAdapter_spec.js

* Delete test/spec/adapters directory

* Update userId_spec.js

* Delete iasBidAdapter.js

* Add files via upload

* Update openxBidAdapter.js

* Update openxBidAdapter.js

* Update concertBidAdapter.js

* Update unrulyBidAdapter.js

* Update undertoneBidAdapter.js

* Update adformBidAdapter.js

* Update adformBidAdapter_spec.js

* Update unrulyBidAdapter_spec.js

* Update concertBidAdapter_spec.js

* Update undertoneBidAdapter_spec.js

* Update undertoneBidAdapter.js

* Update adformBidAdapter_spec.js

* Update adformBidAdapter_spec.js

* Update undertoneBidAdapter_spec.js

* Update adformBidAdapter_spec.js

* Update adformBidAdapter_spec.js
  • Loading branch information
patmmccann authored May 8, 2021
1 parent 6797935 commit d7a7f1b
Show file tree
Hide file tree
Showing 8 changed files with 9 additions and 2 deletions.
1 change: 1 addition & 0 deletions modules/adformBidAdapter.js
Original file line number Diff line number Diff line change
Expand Up @@ -170,6 +170,7 @@ export const spec = {
currency: response.win_cur,
netRevenue: bidRequest.netRevenue !== 'gross',
ttl: 360,
meta: { advertiserDomains: response && response.adomain ? response.adomain : [] },
ad: response.banner,
bidderCode: bidRequest.bidder,
transactionId: bid.transactionId,
Expand Down
1 change: 1 addition & 0 deletions modules/concertBidAdapter.js
Original file line number Diff line number Diff line change
Expand Up @@ -98,6 +98,7 @@ export const spec = {
height: bid.height,
ad: bid.ad,
ttl: bid.ttl,
meta: { advertiserDomains: bid && bid.adomain ? bid.adomain : [] },
creativeId: bid.creativeId,
netRevenue: bid.netRevenue,
currency: bid.currency
Expand Down
3 changes: 2 additions & 1 deletion modules/undertoneBidAdapter.js
Original file line number Diff line number Diff line change
Expand Up @@ -158,7 +158,8 @@ export const spec = {
creativeId: bidRes.adId,
currency: bidRes.currency,
netRevenue: bidRes.netRevenue,
ttl: bidRes.ttl || 360
ttl: bidRes.ttl || 360,
meta: { advertiserDomains: bidRes.adomain ? bidRes.adomain : [] }
};
if (bidRes.mediaType && bidRes.mediaType === 'video') {
bid.vastXml = bidRes.ad;
Expand Down
1 change: 1 addition & 0 deletions modules/unrulyBidAdapter.js
Original file line number Diff line number Diff line change
Expand Up @@ -31,6 +31,7 @@ const serverResponseToBid = (bid, rendererInstance) => ({
netRevenue: true,
creativeId: bid.bidId,
ttl: 360,
meta: { advertiserDomains: bid && bid.adomain ? bid.adomain : [] },
currency: 'USD',
renderer: rendererInstance,
mediaType: VIDEO
Expand Down
1 change: 1 addition & 0 deletions test/spec/modules/adformBidAdapter_spec.js
Original file line number Diff line number Diff line change
Expand Up @@ -258,6 +258,7 @@ describe('Adform adapter', function () {
assert.equal(result.currency, 'EUR');
assert.equal(result.netRevenue, true);
assert.equal(result.ttl, 360);
assert.deepEqual(result.meta.advertiserDomains, [])
assert.equal(result.ad, '<tag1>');
assert.equal(result.bidderCode, 'adform');
assert.equal(result.transactionId, '5f33781f-9552-4ca1');
Expand Down
2 changes: 1 addition & 1 deletion test/spec/modules/concertBidAdapter_spec.js
Original file line number Diff line number Diff line change
Expand Up @@ -116,7 +116,7 @@ describe('ConcertAdapter', function () {
describe('spec.interpretResponse', function() {
it('should return bids in the shape expected by prebid', function() {
const bids = spec.interpretResponse(bidResponse, bidRequest);
const requiredFields = ['requestId', 'cpm', 'width', 'height', 'ad', 'ttl', 'creativeId', 'netRevenue', 'currency'];
const requiredFields = ['requestId', 'cpm', 'width', 'height', 'ad', 'ttl', 'meta', 'creativeId', 'netRevenue', 'currency'];

requiredFields.forEach(function(field) {
expect(bids[0]).to.have.property(field);
Expand Down
1 change: 1 addition & 0 deletions test/spec/modules/undertoneBidAdapter_spec.js
Original file line number Diff line number Diff line change
Expand Up @@ -358,6 +358,7 @@ describe('Undertone Adapter', () => {
expect(bid.cpm).to.equal(100);
expect(bid.width).to.equal(300);
expect(bid.height).to.equal(250);
expect(bid.meta.advertiserDomains).to.deep.equal([]);
expect(bid.creativeId).to.equal(15);
expect(bid.currency).to.equal('USD');
expect(bid.netRevenue).to.equal(true);
Expand Down
1 change: 1 addition & 0 deletions test/spec/modules/unrulyBidAdapter_spec.js
Original file line number Diff line number Diff line change
Expand Up @@ -148,6 +148,7 @@ describe('UnrulyAdapter', function () {
netRevenue: true,
creativeId: 'mockBidId',
ttl: 360,
meta: { advertiserDomains: [] },
currency: 'USD',
renderer: fakeRenderer,
mediaType: 'video'
Expand Down

0 comments on commit d7a7f1b

Please sign in to comment.