Criteo ID Module: Add error callback for pixel sync call

prebid · Apr 3, 2023 · ecec568 · ecec568
1 parent 0a665d7
commit ecec568
Show file tree

Hide file tree

Showing 2 changed files with 41 additions and 0 deletions.
diff --git a/modules/criteoIdSystem.js b/modules/criteoIdSystem.js
@@ -102,6 +102,9 @@ function callSyncPixel(domain, pixel) {
               saveOnAllStorages(pixel.storageKeyName, jsonResponse[pixel.bundlePropertyName], domain);
             }
           }
+        },
+        error: error => {
+          logError(`criteoIdSystem: unable to sync user id`, error);
         }
       },
       undefined,

diff --git a/test/spec/modules/criteoIdSystem_spec.js b/test/spec/modules/criteoIdSystem_spec.js
@@ -185,6 +185,44 @@ describe('CriteoId module', function () {
     expect(setLocalStorageStub.calledWith('cto_pixel_test', 'ok')).to.be.true;
   });
 
+  it('should call sync pixels and use error handler', function () {
+    const expirationTs = new Date(nowTimestamp + cookiesMaxAge).toString();
+
+    const result = criteoIdSubmodule.getId();
+    result.callback((id) => {
+    });
+
+    const response = {
+      pixels: [
+        {
+          pixelUrl: 'pixelUrlWithBundle',
+          writeBundleInStorage: true,
+          bundlePropertyName: 'abc',
+          storageKeyName: 'cto_pixel_test'
+        }
+      ]
+    };
+
+    server.requests[0].respond(
+      200,
+      { 'Content-Type': 'application/json' },
+      JSON.stringify(response)
+    );
+
+    server.requests[1].respond(
+      500,
+      { 'Content-Type': 'application/json' },
+      JSON.stringify({
+        abc: 'ok'
+      })
+    );
+
+    expect(triggerPixelStub.called).to.be.false;
+    expect(setCookieStub.calledWith('cto_pixel_test', 'ok', expirationTs, null, '.com')).to.be.false;
+    expect(setCookieStub.calledWith('cto_pixel_test', 'ok', expirationTs, null, '.testdev.com')).to.be.false;
+    expect(setLocalStorageStub.calledWith('cto_pixel_test', 'ok')).to.be.false;
+  });
+
   gdprConsentTestCases.forEach(testCase => it('should call user sync url with the gdprConsent', function () {
     let callBackSpy = sinon.spy();
     let result = criteoIdSubmodule.getId(undefined, testCase.consentData);