delete unnecessary tests from AMX ID adapter + fix formatting, possib…

…le flakey test
prebid · Apr 4, 2023 · f1a55bc · f1a55bc
1 parent 77f38f8
commit f1a55bc
Show file tree

Hide file tree

Showing 4 changed files with 7 additions and 56 deletions.
diff --git a/modules/amxIdSystem.js b/modules/amxIdSystem.js
@@ -11,7 +11,7 @@ import {submodule} from '../src/hook.js';
 import {getRefererInfo} from '../src/refererDetection.js';
 import {deepAccess, logError} from '../src/utils.js';
 import {getStorageManager} from '../src/storageManager.js';
-import { domainOverrideToRootDomain } from '../libraries/domainOverrideToRootDomain/index.js';
+import {domainOverrideToRootDomain} from '../libraries/domainOverrideToRootDomain/index.js';
 
 const NAME = 'amxId';
 const GVL_ID = 737;

diff --git a/modules/sharedIdSystem.js b/modules/sharedIdSystem.js
@@ -5,12 +5,12 @@
  * @requires module:modules/userId
  */
 
-import { parseUrl, buildUrl, triggerPixel, logInfo, hasDeviceAccess, generateUUID } from '../src/utils.js';
+import {parseUrl, buildUrl, triggerPixel, logInfo, hasDeviceAccess, generateUUID} from '../src/utils.js';
 import {submodule} from '../src/hook.js';
-import { coppaDataHandler } from '../src/adapterManager.js';
+import {coppaDataHandler} from '../src/adapterManager.js';
 import {getStorageManager} from '../src/storageManager.js';
 import {VENDORLESS_GVLID} from '../src/consentHandler.js';
-import { domainOverrideToRootDomain } from '../libraries/domainOverrideToRootDomain/index.js';
+import {domainOverrideToRootDomain} from '../libraries/domainOverrideToRootDomain/index.js';
 
 export const storage = getStorageManager({moduleName: 'pubCommonId', gvlid: VENDORLESS_GVLID});
 const COOKIE = 'cookie';

diff --git a/test/spec/libraries/domainOverrideToRootDomain/index_spec.js b/test/spec/libraries/domainOverrideToRootDomain/index_spec.js
@@ -34,6 +34,9 @@ describe('domainOverride', () => {
     domain = 'greatpublisher.com'
     rejectCookiesFor = 'greatpublisher.com'
 
+    // stub Date.now() to return a constant value
+    sandbox.stub(Date, 'now').returns(1234567890)
+
     const randomName = `adapterV${(Math.random() * 1e8).toString(16)}`
     const localDomainOverride = domainOverrideToRootDomain(storage, randomName)
 

diff --git a/test/spec/modules/amxIdSystem_spec.js b/test/spec/modules/amxIdSystem_spec.js
@@ -38,58 +38,6 @@ describe('decode', () => {
   });
 });
 
-describe('domainOverride', () => {
-  let sandbox, domain, cookies, rejectCookiesFor;
-  beforeEach(() => {
-    sandbox = sinon.createSandbox();
-    sandbox.stub(document, 'domain').get(() => domain);
-    cookies = {};
-    sandbox.stub(storage, 'getCookie').callsFake((key) => cookies[key]);
-    rejectCookiesFor = null;
-    sandbox.stub(storage, 'setCookie').callsFake((key, value, expires, sameSite, domain) => {
-      if (domain !== rejectCookiesFor) {
-        if (expires != null) {
-          expires = new Date(expires);
-        }
-        if (expires == null || expires > Date.now()) {
-          cookies[key] = value;
-        } else {
-          delete cookies[key];
-        }
-      }
-    });
-  });
-
-  afterEach(() => sandbox.restore())
-
-  it('will return the root domain when given a subdomain', () => {
-    const test_domains = [
-      'deeply.nested.subdomain.for.greatpublisher.com',
-      'greatpublisher.com',
-      'subdomain.greatpublisher.com',
-      'a-subdomain.greatpublisher.com',
-    ];
-
-    test_domains.forEach((testDomain) => {
-      domain = testDomain
-      rejectCookiesFor = 'com'
-      expect(amxIdSubmodule.domainOverride()).to.equal('greatpublisher.com');
-    });
-  });
-
-  it(`If we can't set cookies on the root domain, we'll return the subdomain`, () => {
-    domain = 'subdomain.greatpublisher.com'
-    rejectCookiesFor = 'greatpublisher.com'
-    expect(amxIdSubmodule.domainOverride()).to.equal('subdomain.greatpublisher.com');
-  });
-
-  it('Will return undefined if we can\'t set cookies on the root domain or the subdomain', () => {
-    domain = 'subdomain.greatpublisher.com'
-    rejectCookiesFor = 'subdomain.greatpublisher.com'
-    expect(amxIdSubmodule.domainOverride()).to.equal(undefined);
-  });
-});
-
 describe('validateConfig', () => {
   let logErrorSpy;