fix failing test and remove redundant "&" in URL

prebid · May 25, 2018 · f7bf27d · f7bf27d
1 parent 9a71939
commit f7bf27d
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 3 deletions.
diff --git a/modules/gambidBidAdapter.js b/modules/gambidBidAdapter.js
@@ -62,7 +62,7 @@ export const spec = {
     return validBidRequests.map(bidRequest => {
       const { adUnitCode, auctionId, mediaTypes, params, sizes, transactionId } = bidRequest;
       const baseEndpoint = params[ 'rtbEndpoint' ] || 'https://rtb.gambid.io';
-      const rtbEndpoint = `${baseEndpoint}/r/${params.supplyPartnerId}/bidr?rformat=open_rtb&bidder=prebid&` + params.query || '';
+      const rtbEndpoint = `${baseEndpoint}/r/${params.supplyPartnerId}/bidr?rformat=open_rtb&bidder=prebid` + (params.query ? '&' + params.query : '');
       const rtbBidRequest = {
         'id': auctionId,
         'site': {

diff --git a/test/spec/modules/gambidBidAdapter_spec.js b/test/spec/modules/gambidBidAdapter_spec.js
@@ -72,13 +72,13 @@ describe('GambidAdapter', () => {
 
       response = spec.buildRequests([ bidRequest ])[ 0 ];
       expect(response.method).to.equal('POST');
-      expect(response.url).to.match(new RegExp(`^https://rtb\\.gambid\\.io/r/${supplyPartnerId}/bidr\\?bidder=prebid&_cb=\\d+$`, 'g'));
+      expect(response.url).to.match(new RegExp(`^https://rtb\\.gambid\\.io/r/${supplyPartnerId}/bidr\\?rformat=open_rtb&bidder=prebid$`, 'g'));
       expect(response.data.id).to.equal(bidRequest.auctionId);
 
       const bidRequestWithEndpoint = deepClone(bidRequest);
       bidRequestWithEndpoint.params.rtbEndpoint = 'https://rtb2.gambid.io/a12';
       response = spec.buildRequests([ bidRequestWithEndpoint ])[ 0 ];
-      expect(response.url).to.match(new RegExp(`^https://rtb2\\.gambid\\.io/a12/r/${supplyPartnerId}/bidr\\?bidder=prebid&_cb=\\d+$`, 'g'));
+      expect(response.url).to.match(new RegExp(`^https://rtb2\\.gambid\\.io/a12/r/${supplyPartnerId}/bidr\\?rformat=open_rtb&bidder=prebid$`, 'g'));
     });
 
     it('builds request correctly', () => {