Skip to content

Commit

Permalink
Yieldlab Bid Adapter: Fix meta.advertiserDomains (#12223)
Browse files Browse the repository at this point in the history
meta.advertiserDomains should've been an array all this time. Specs: https://docs.prebid.org/dev-docs/bidder-adaptor.html
  • Loading branch information
mirkorean authored Sep 10, 2024
1 parent 6429318 commit fa33f7c
Show file tree
Hide file tree
Showing 2 changed files with 3 additions and 3 deletions.
2 changes: 1 addition & 1 deletion modules/yieldlabBidAdapter.js
Original file line number Diff line number Diff line change
Expand Up @@ -201,7 +201,7 @@ export const spec = {
referrer: '',
ad: `<script src="${ENDPOINT}/d/${matchedBid.id}/${bidRequest.params.supplyId}/?ts=${timestamp}${extId}${gdprApplies}${gdprConsent}${pvId}${iabContent}"></script>`,
meta: {
advertiserDomains: (matchedBid.advertiser) ? matchedBid.advertiser : 'n/a',
advertiserDomains: [(matchedBid.advertiser) ? matchedBid.advertiser : 'n/a'],
},
};

Expand Down
4 changes: 2 additions & 2 deletions test/spec/modules/yieldlabBidAdapter_spec.js
Original file line number Diff line number Diff line change
Expand Up @@ -682,7 +682,7 @@ describe('yieldlabBidAdapter', () => {
expect(result[0].netRevenue).to.equal(false);
expect(result[0].ttl).to.equal(300);
expect(result[0].referrer).to.equal('');
expect(result[0].meta.advertiserDomains).to.equal('yieldlab');
expect(result[0].meta.advertiserDomains).to.deep.equal(['yieldlab']);
expect(result[0].ad).to.include('<script src="https://ad.yieldlab.net/d/1111/2222/?ts=');
expect(result[0].ad).to.include('&id=abc');
});
Expand Down Expand Up @@ -719,7 +719,7 @@ describe('yieldlabBidAdapter', () => {
expect(result[0].netRevenue).to.equal(false);
expect(result[0].ttl).to.equal(300);
expect(result[0].referrer).to.equal('');
expect(result[0].meta.advertiserDomains).to.equal('yieldlab');
expect(result[0].meta.advertiserDomains).to.deep.equal(['yieldlab']);
expect(result[0].ad).to.include('<script src="https://ad.yieldlab.net/d/1111/2222/?ts=');
expect(result[0].ad).to.include('&id=abc');
});
Expand Down

0 comments on commit fa33f7c

Please sign in to comment.